[Bug 27318] New: make shibboleth instructions customizable in the loginModal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Bug ID: 27318 Summary: make shibboleth instructions customizable in the loginModal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If you enable shibboleth for sign on in the OPAC and go to the loginModal the instructions say "If you have a Shibboleth account, please click here to login." That language is confusing to most users who don't know what shibboleth is. This area should be editable via the News Tool so librarians can add their own language here. I have moved some things in the loginModal in Bug 25405 and this would build upon that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114755&action=edit Bug 27318: Add ShibbolethLoginInstructions to News This patch adds ShibbolethLoginInstructions as an option in the News Tool so librarians customize the wording within the loginModal To test: 1. Enable shibboleth in your koha-conf.xml by changng the value of <useshibboleth> to 1. 2. I also add the following to my koha-conf: <shibboleth> <matchpoint>email</matchpoint> <mapping> <email is="SHIB_ATTR_email"></email> </mapping> </shibboleth> 3. Look at the OPAC loginModal and make sure something like "If you have a Shibboleth account, please click here to login." is visiible. 4. Apply patch 5. Go to /cgi-bin/koha/tools/koha-news.pl and make a New entry 6. Choose ShibbolethLoginInstructions and enter something like: '<h1>Sign in using:</h1> <a href="localhost:8080/Shibboleth.sso/Login?target=localhost:8080/cgi-bin/koha/opac-main.pl"><div class="shibGoogle">Google</div></a>' 7. Reload the OPAC and look at the loginModal again, it should show your new login instructions instead of the default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25405 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I like this idea in theory. As I noted on Bug 25405, I agree that most users aren't going to know what Shibboleth is. Moreover, it's not meaningful, since many Koha libraries don't actually use Shibboleth as an Identity Provider, and we really do want to be referencing the Identity Provider branding at this point (whether it is Google, Facebook, Department of X, et cetera). However, this patch isn't really workable at the moment, since we lose the "shibbolethLoginUrl" variable, which is dynamically defined based on the page you are on at any given time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Cook from comment #2)
I like this idea in theory.
As I noted on Bug 25405, I agree that most users aren't going to know what Shibboleth is. Moreover, it's not meaningful, since many Koha libraries don't actually use Shibboleth as an Identity Provider, and we really do want to be referencing the Identity Provider branding at this point (whether it is Google, Facebook, Department of X, et cetera).
However, this patch isn't really workable at the moment, since we lose the "shibbolethLoginUrl" variable, which is dynamically defined based on the page you are on at any given time.
David, I appreciate you testing this. It is unfortunate that we loose the shibbolethLoginUrl variable and I see that this makes this solution unworkable. Since we cannot use Template Toolkit from within the News Editor I don't see anyway to let the user add the variable back into the custom field. Therefore I think the best thing we can do is add class names and ID's as you mentioned in Bug 25405 in order to make it easier to customize via jQuery/CSS. I'll close this bug at this time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass from comment #3)
David,
I appreciate you testing this. It is unfortunate that we loose the shibbolethLoginUrl variable and I see that this makes this solution unworkable. Since we cannot use Template Toolkit from within the News Editor I don't see anyway to let the user add the variable back into the custom field.
Therefore I think the best thing we can do is add class names and ID's as you mentioned in Bug 25405 in order to make it easier to customize via jQuery/CSS.
I'll close this bug at this time.
Sorry for being a buzzkill! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Bug 27318 depends on bug 25405, which changed state. Bug 25405 Summary: Make separation of Shibboleth and Local login clearer in modal login on OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org