http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |eskaaren@yahoo.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #1 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Created attachment 39104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39104&action=edit Added the functionality to most staff header search boxes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #3 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Created attachment 39106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39106&action=edit Added the functionality to most staff header search boxes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39107|0 |1 is obsolete| | --- Comment #5 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Created attachment 39108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39108&action=edit Made text persist when clicking the tabs under the searchbox To test: Apply the patch and see that the text now is there in the search box when clicking the tabs: check in, check out etc.. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39108|0 |1 is obsolete| | --- Comment #6 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Created attachment 39110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39110&action=edit Made text persist when clicking the tabs under the searchbox To test: Apply the patch and see that the text now is there in the search box when clicking the tabs: check in, check out etc.. (More files changed for persistent text in searchbox) Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- Created attachment 39112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39112&action=edit Bug 14189 - [SIGNED-OFF] Made text persist when clicking the tabs under the searchbox To test: Apply the patch and see that the text now is there in the search box when clicking the tabs: check in, check out etc.. (More files changed for persistent text in searchbox) Sponsored-by: Halland County Library http://bugs.koha-community.org/show_bug.cgi?id=14189 Signed-off-by: Magnus Enger <magnus@enger.priv.no> This is something I have wanted quite a few times over the years... Tested by going to every main area of Koha, entering some random text into the search box and then clicking on all the available tabs to check that the entered text is carried over to all the boxes. There are a couple of places where text is not carried over, but I guess that might be because one of the boxes is structurally different to the others. These are: - "Vendor search" and "Orders search" in Acquisitions - "Search subscriptions" in Serials I have not looked at how this is implemented, just that it works as it should. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #8 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- What Magnus discovered with the few places it is not implemented was done intentionally as it did not make sense from a UX perspective for example when there is 2 search boxes on one tab and 1 on the other. It should work for most daily use cases where this would be helpful. The templates should probably at some point be refactored since there was some duplication of HTML, but that is not needed for this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: 1/ The class name could be more specific to avoid further conflict ('query') 2/ Since a lot of patch will use keep_text JS function, maybe the include of searchbox-keep-text.inc could be done once in doc-head-close.inc 3/ What is the meaning of the different values of the clicked parameter (0, 1, 2)? Please add comment. 4/ Is is intended not to use jQuery selectors in the keep_text JS function? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39112|0 |1 is obsolete| | --- Comment #10 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Created attachment 39462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39462&action=edit Bug 14189 refactor after failed QA. 1) Renamed to "head-searchbox". 2) Good suggestion, I have included it once in doc-head-close.inc. 3) For the algorithm to work when there are just 2 boxes we need to know if the first tab was clicked and since this is JS and run when a href is clicked the easiest way was to send the index as a parameter. 4) Pure JS is faster than jQuery and this code will run on every pageload and I don't think jQuery would make it any clearer than the used document.getElementsByClassName("head-searchbox"). For the rest of the JS it does not rely on names since all searchboxes of the class "head-searchbox" are put into the array "searchboxes". If a new page with any number of searchboxes is added to Koha later this should still work without modification. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39506&action=edit Bug 14189: Use keep_text for the authority header includes/authorities-search.inc already used the same behavior but with another method. For consistency it's better to have only 1 way to do that. Test plan: Go on the authority home page Fill the input in the header and click on tab 'search all headings' and 'keyword search' and confirm that the text you have filled is kept. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39506|0 |1 is obsolete| | --- Comment #15 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Created attachment 39543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39543&action=edit Bug 14189: Use keep_text for the authority header includes/authorities-search.inc already used the same behavior but with another method. For consistency it's better to have only 1 way to do that. Test plan: Go on the authority home page Fill the input in the header and click on tab 'search all headings' and 'keyword search' and confirm that the text you have filled is kept. I tested after applying the patch and the text is kept after removing the part from authorities-search.inc. I also tried applying that jQuery solution instead of my JS loop but could not get it to work for the other pages with a reasonable ammount of effort. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39588&action=edit Bug 14189: Use keep_text for the authority header includes/authorities-search.inc already used the same behavior but with another method. For consistency it's better to have only 1 way to do that. Test plan: Go on the authority home page Fill the input in the header and click on tab 'search all headings' and 'keyword search' and confirm that the text you have filled is kept. I tested after applying the patch and the text is kept after removing the part from authorities-search.inc. I also tried applying that jQuery solution instead of my JS loop but could not get it to work for the other pages with a reasonable ammount of effort. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no> -- You are receiving this mail because: You are watching all bug changes.