https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 170893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170893&action=edit Bug 37766: Fix forms that POST without an op in MARC bibliographic frameworks We intend not to have forms with method="post" without an op variable (so we can check that the op starts with "cud-" as part of the CSRF protection), but because of bug 37728 some were missed. In MARC bibliographic frameworks, that's the tag search form, which should be a GET so the URL includes what you searched for and you can bookmark it or link to the search, and the cancel "No, do not delete" button in the page to confirm deleting a subfield, which should also be a GET to take you back to the page where you were, which was ?tagfield=903&frameworkcode=VR when you clicked Delete. Test plan: 1. No visible change in behavior (only the URL), so start with the patch applied 2. Administration - MARC bibliographic framework - choose one other than Default, since the "&framework=" of Default could be confused with a failure to get the code in there - Actions - MARC structure 3. Type any three digit number higher than 009 (you want something with subfields) in the Search for tag input and hit Enter 4. Verify that your URL has the searchfield and frameworkcode correct and that number or next highest number tag is displayed first 5. Change the In framework select menu to another non-Default framework and click search, and verify that the URL change to that frameworkcode, and that framework is displayed 6. Toggle the Display only used tags/subfields checkbox, search for a different tag, and verify that the state of the checkbox persists as you do more searches 7. On any other listed tag - Actions - View subfields 8. For any displayed subfield click Delete 9. In the confirmation page click No, do not delete 10. Verify that the page you return to has the correct tagfield and frameworkcode for the tag you chose Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170893|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170914&action=edit Bug 37766: Fix forms that POST without an op in MARC bibliographic frameworks We intend not to have forms with method="post" without an op variable (so we can check that the op starts with "cud-" as part of the CSRF protection), but because of bug 37728 some were missed. In MARC bibliographic frameworks, that's the tag search form, which should be a GET so the URL includes what you searched for and you can bookmark it or link to the search, and the cancel "No, do not delete" button in the page to confirm deleting a subfield, which should also be a GET to take you back to the page where you were, which was ?tagfield=903&frameworkcode=VR when you clicked Delete. Test plan: 1. No visible change in behavior (only the URL), so start with the patch applied 2. Administration - MARC bibliographic framework - choose one other than Default, since the "&framework=" of Default could be confused with a failure to get the code in there - Actions - MARC structure 3. Type any three digit number higher than 009 (you want something with subfields) in the Search for tag input and hit Enter 4. Verify that your URL has the searchfield and frameworkcode correct and that number or next highest number tag is displayed first 5. Change the In framework select menu to another non-Default framework and click search, and verify that the URL change to that frameworkcode, and that framework is displayed 6. Toggle the Display only used tags/subfields checkbox, search for a different tag, and verify that the state of the checkbox persists as you do more searches 7. On any other listed tag - Actions - View subfields 8. For any displayed subfield click Delete 9. In the confirmation page click No, do not delete 10. Verify that the page you return to has the correct tagfield and frameworkcode for the tag you chose Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170914|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170942&action=edit Bug 37766: Fix forms that POST without an op in MARC bibliographic frameworks We intend not to have forms with method="post" without an op variable (so we can check that the op starts with "cud-" as part of the CSRF protection), but because of bug 37728 some were missed. In MARC bibliographic frameworks, that's the tag search form, which should be a GET so the URL includes what you searched for and you can bookmark it or link to the search, and the cancel "No, do not delete" button in the page to confirm deleting a subfield, which should also be a GET to take you back to the page where you were, which was ?tagfield=903&frameworkcode=VR when you clicked Delete. Test plan: 1. No visible change in behavior (only the URL), so start with the patch applied 2. Administration - MARC bibliographic framework - choose one other than Default, since the "&framework=" of Default could be confused with a failure to get the code in there - Actions - MARC structure 3. Type any three digit number higher than 009 (you want something with subfields) in the Search for tag input and hit Enter 4. Verify that your URL has the searchfield and frameworkcode correct and that number or next highest number tag is displayed first 5. Change the In framework select menu to another non-Default framework and click search, and verify that the URL change to that frameworkcode, and that framework is displayed 6. Toggle the Display only used tags/subfields checkbox, search for a different tag, and verify that the state of the checkbox persists as you do more searches 7. On any other listed tag - Actions - View subfields 8. For any displayed subfield click Delete 9. In the confirmation page click No, do not delete 10. Verify that the page you return to has the correct tagfield and frameworkcode for the tag you chose Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Very much intentional: the form above, that does the "Yes, delete" action, needs to tell the script the tag, the subfield, and the framework(In reply to Katrin Fischer from comment #4)

- <input type="hidden" name="tagsubfield" value="[% mss.tagsubfield | html %]" />

Is this removal intended here?

Very much intentional: the form above, that does the "Yes, delete" action, needs to tell the script the tag, the subfield, and the framework, but the cancel one only needs to tell it the tag and framework to go back to showing the subfields for that tag. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- I had a special look at this removal when QAing and it is safe. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37766 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |aude.charillon@ptfs-europe. | |com --- Comment #13 from Aude Charillon <aude.charillon@ptfs-europe.com> --- No need for update to Koha Manual. -- You are receiving this mail because: You are watching all bug changes.