https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 --- Comment #1 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 74857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74857&action=edit Bug 20660: AddReturn uses return_date override for new debarments This patches is a minor tweak (single line) to C4::Circulation to use the return_date value as $today when calculating new debarments in AddReturn. I've also added a test in t/db_dependent/Circulation.t TEST PLAN 1) comment out line 1988 in Circulation.pm ("$today = $return_date if $return_date") 2) prove t/db_dependent/Circulation.t (Fail) 3) uncomment the line 4) prove t/db_dependent/Circulation.t (Pass) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |In Discussion --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- (In reply to David Bourgault from comment #1)

Created attachment 74857 [details] [review] Bug 20660: AddReturn uses return_date override for new debarments

This patches is a minor tweak (single line) to C4::Circulation to use the return_date value as $today when calculating new debarments in AddReturn.

I've also added a test in t/db_dependent/Circulation.t

TEST PLAN

1) comment out line 1988 in Circulation.pm ("$today = $return_date if $return_date") 2) prove t/db_dependent/Circulation.t (Fail) 3) uncomment the line 4) prove t/db_dependent/Circulation.t (Pass)

It is better to split the test from the change, so that when you want to prove the problem you just apply the test. Then if you wish to prove the solution also apply the second patch, and have the tests pass. Should dropbox override the return date logic being added? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74857|0 |1 is obsolete| | --- Comment #3 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 74955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74955&action=edit Bug 20660: Test AddReturn with $return_date override -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 --- Comment #5 from David Bourgault <david.bourgault@inlibro.com> --- (In reply to M. Tompsett from comment #2)

Should dropbox override the return date logic being added?

It was already present in the code: $today = $return_date if $return_date; $today = $dropboxdate if $dropbox; first line is my addition, second line is from existing code. So if $dropbox is set, it will override any return_date overrides. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74955|0 |1 is obsolete| | Attachment #74956|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 77426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77426&action=edit Bug 20660: Test AddReturn with $return_date override Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77449&action=edit Bug 20660: Return date override affects debarments in AddReturn Re-did the patch to follow best practices. TEST PLAN: 0. Apply first patch only 1. prove t/db_dependent/Circulation.t 2. Apply second patch 3. prove t/db_dependent/Circulation.t prove should fail the first time and pass the second time. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 [Bug 21188] t/db_dependent/Circulation/issue.t is failing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The description of this bug report and what the patch does are a bit different. There is a change in the behavior that should have been adverted in the commit message, and tested on the UI. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Can we have a short summary of the behavioural change and ui effects for the release notes, please.. I'm happy it's a bugfix, but would like the release notes to be clear there's a change. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer not to push to 17.11.x because of th change in the behavior -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20660 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.