[Bug 21326] New: Add branch param to C4::SIP->checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 Bug ID: 21326 Summary: Add branch param to C4::SIP->checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: benjamin.rokseth@deichman.no QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com For some reason branch is not included in the SIP::ILS::Transaction object, but rather fetched inside C4::Circulation using context. This bug adds branch to object so it can be passed in as param to ILS::Transaction->checkout (this is already present in ILS::Transaction->checkin) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 --- Comment #1 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 78541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78541&action=edit Bug 21326: C4::SIP::ILS add missing branch param ILS::Transaction was missing branch param for unknown reason. Since every transactions needs a branch, it makes sense to include it in the object and allow as param. This patch only adds the param to the object and ILS->checkout so it can be used in submodules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com, | |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Benjamin, Can you please provide a test plan for this? Maybe ensuring it doesn't break anything? Thanks Aleisha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 --- Comment #3 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Well there isn't much to test really, it's just an extra param that isnt used anywhere yet. Afraid I cannot help more, since we dont know if anyone else use it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |benjamin.rokseth@deichman.n |ity.org |o CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Benjamin, please don't forget to assign the bug to yourself when providing a patch! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78541|0 |1 is obsolete| | --- Comment #5 from Ethan <ethan.amohia@gmail.com> --- Created attachment 84014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84014&action=edit Bug 21326: C4::SIP::ILS add missing branch param ILS::Transaction was missing branch param for unknown reason. Since every transactions needs a branch, it makes sense to include it in the object and allow as param. This patch only adds the param to the object and ILS->checkout so it can be used in submodules. Signed-off-by: Ethan Amohia <ethan.amohia@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I can't see that this achieves anything, but please correct me if I'm wrong. For checkouts we use the AddIssue function and that doesn't expect a branch to be passed (and nor are we passing one to any other routines called from within C4::SIP::ILS::Transaction::Checkout->checkout_ok) I can't see that this addition actually goes anywhere.. failing QA for now until I get some feedback/perspective. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21326 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Please clarify 'used in submodules'.. that might be a use case I'm entirely overlooking/not understanding. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org