[Bug 19937] New: Silence warnings t/db_dependent/www/batch.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Bug ID: 19937 Summary: Silence warnings t/db_dependent/www/batch.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 70364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70364&action=edit Bug 19937: Silence warnings t/db_dependent/www/batch.t TEST PLAN --------- 1) Run the following on a kohadevbox: git checkout -b bug_19937 origin/master sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered at the end of the log file: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. 2) Run the following on a kohadevbox: exit git bz apply 19937 restart_all sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The log file will end with the restarting of plack, not the errors. 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70364|0 |1 is obsolete| | --- Comment #2 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 70410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70410&action=edit Bug 19937: Silence warnings t/db_dependent/www/batch.t TEST PLAN --------- 1) Run the following on a kohadevbox: git checkout -b bug_19937 origin/master sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered at the end of the log file: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. 2) Run the following on a kohadevbox: exit git bz apply 19937 restart_all sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The log file will end with the restarting of plack, not the errors. 3) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70410|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 70447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70447&action=edit Bug 19937: Silence warnings t/db_dependent/www/batch.t TEST PLAN --------- 1) Run the following on a kohadevbox: git checkout -b bug_19937 origin/master sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The following errors are triggered at the end of the log file: Use of uninitialized value in array element at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 50. Use of uninitialized value $results_per_page in numeric eq (==) at /home/vagrant/kohaclone/tools/batch_records_ajax.pl line 53. Use of uninitialized value in uc at /home/vagrant/kohaclone/C4/ImportBatch.pm line 1120. 2) Run the following on a kohadevbox: exit git bz apply 19937 restart_all sudo koha-shell -c bash kohadev prove t/db_dependent/www/batch.t cat /var/log/koha/kohadev/plack-error.log The log file will end with the restarting of plack, not the errors. 3) run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended handling of $results_per_page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19937 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org