[Bug 28554] New: In itemsearch sort filters by description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Bug ID: 28554 Summary: In itemsearch sort filters by description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In itemsearch form, there are several filters build with authorized values or item types. There values should be sorted by description. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 121820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121820&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 121821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121821&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- If needed I will create a unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121820|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 121891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121891&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121821|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 121892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121892&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |For item search in the release notes| |staff interface the | |shelving location and item | |type values are now sorted | |by the description, rather | |than the authorized value | |code. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121891|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 121935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121935&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121892|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 121936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121936&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- One test is failing with those 2 patches applied: # Failed test at t/db_dependent/AuthorisedValues.t line 236. # Structures begin differing at: # $got->[0]{opac_description} = 'opac display value 0' # $expected->[0]{opac_description} = 'opac display value undef' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123451&action=edit Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121935|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 123464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123464&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121936|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 123465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123465&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123451|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 123466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123466&action=edit Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27565 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 27565 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also tested for translated item type descriptions. Note: you need to have at least one additional language installed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123464|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124209&action=edit Bug 28554: In Koha::AuthorisedValues sort by description In itemsearch form, there are several filters build with authorized values. There values should be sorted by description. Test plan : 1) Create several values and descriptions in authorized values LOC 2) Go to itemsearch 3) See filter by location sorts on description and not on value Seems change in search_by_marc_field can not be tested in interface Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123465|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124210&action=edit Bug 28554: In itemsearch sort item types filter by description In itemsearch form, the item types filter should be sorted by description. Test plan : 1) Create several values and descriptions in item types 2) Go to itemsearch 3) See filter by item types sorts on description and not on value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123466|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124211&action=edit Bug 28554: Fix t/db_dependent/AuthorisedValues.t Fixes where sort on lib breaks the test. Also removes useless params in search_by_koha_field() Run prove t/db_dependent/AuthorisedValues.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.04 released in| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.04 |21.11.00,21.05.04,20.11.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28554 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org