[Bug 27664] New: pickupNotInHoldGroup is too generic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27664 Bug ID: 27664 Summary: pickupNotInHoldGroup is too generic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com There are actually two codepaths that yield an output of 'pickupNotInHoldGroup' in C4::Reserves::CanItemBeReserved: - The passed pickup location doesn't match the patron's hold group - The passed pickup location doesn't match the item's hold group We could return different error codes and provide better feedback to the end user. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27664 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27071 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27664 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This appears to still be valid: C4/Reserves.pm: { status => pickupNotInHoldGroup }, pickup location is not in hold group, and pickup locations are only allowed from hold groups. C4/Reserves.pm: return { status => 'pickupNotInHoldGroup' }; C4/Reserves.pm: return { status => 'pickupNotInHoldGroup' }; koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: [% ELSIF itemloo.not_holdable == 'pickupNotInHoldGroup' %] koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: pickupNotInHoldGroup: _("Only pickup locations within the same hold group are allowed") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org