[Bug 19630] New: "Hold is suspended" message appears in barcode field in holds table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Bug ID: 19630 Summary: "Hold is suspended" message appears in barcode field in holds table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 69169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69169&action=edit Suspended hold message appears in barcode field In Intranet, when we suspend a hold, the message "hold is suspended" appears in a column titled "barcode". Even when the hold is not suspended, that column doesn't show the barcode. I'm guessing it's just a wording problem... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The barcode and callnumber are only visilble, when the hold is waiting or when it's an item level hold. I think the barcode column is misused for status messages - it also shows when the item is waiting. Maybe a separate status column would be better? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #1)
The barcode and callnumber are only visilble, when the hold is waiting or when it's an item level hold. I think the barcode column is misused for status messages - it also shows when the item is waiting.
Maybe a separate status column would be better?
Hi, could you please specify which Holds table you are talking about? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Hayley, it's the holds table in the patrons's account in staff (look at details and checkouts tabs) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |hayleymapley@catalyst.net.n |ity.org |z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #4 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86633&action=edit Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #5 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Hayley Mapley from comment #4)
Created attachment 86633 [details] [review] Bug 19630: Added Status column to Patron Holds table
When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc.
Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab)
Sponsored-by: Catalyst IT
Note: Step 6 should read "note that id a hold has no status effect", meaning it is not suspended or waiting, etc,. but instead just exists as a hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86633|0 |1 is obsolete| | --- Comment #6 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 86687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86687&action=edit Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86687|0 |1 is obsolete| | --- Comment #7 from Michal Denar <black23@gmail.com> --- Created attachment 87418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87418&action=edit Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 87418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87418 Bug 19630: Added Status column to Patron Holds table Review of attachment 87418: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19630&attachment=87418) ----------------------------------------------------------------- Hi Hayley, found a small issue, see below. I don't really like the new message to be honest - I feel it's too much to read. Could we go without? Some examples: Hold has been placed Item hasn't been transferred yet from Fairview Hold has been placed Item is waiting here ::: koha-tmpl/intranet-tmpl/prog/js/holds.js @@ +132,5 @@
+ { + "mDataProp": function( oObj ) { + var data = ""; + if ( oObj.suspend != 1 && !oObj.itemtype_limit) { + data = _("Hold has been placed\n");
Strings in .js files are not picked up by our translation tools. That is the reason the other messages are using variables that are replaced later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Reading it again: New message = "Hold has been placed" showing up always. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #10 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 87485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87485&action=edit Bug 19630: Removed constant message from Status column Test plan: Same as initial test plan, except that when a hold has no status that the Status column for that hold should be blank instead of saying "Hold has been placed". Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87418|0 |1 is obsolete| | Attachment #87485|0 |1 is obsolete| | --- Comment #11 from Michal Denar <black23@gmail.com> --- Created attachment 87543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87543&action=edit Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #12 from Michal Denar <black23@gmail.com> --- Created attachment 87544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87544&action=edit Bug 19630: Removed constant message from Status column Test plan: Same as initial test plan, except that when a hold has no status that the Status column for that hold should be blank instead of saying "Hold has been placed". Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87543|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87556&action=edit Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87544|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87557&action=edit Bug 19630: Removed constant message from Status column Test plan: Same as initial test plan, except that when a hold has no status that the Status column for that hold should be blank instead of saying "Hold has been placed". Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Haley! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org