[Bug 38328] New: Cannot delete ILL batch statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Bug ID: 38328 Summary: Cannot delete ILL batch statuses Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: phil@chetcolibrary.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 36192 You are permitted to delete ILL batch statuses that you (rather than the system) add, but the UI didn't get the CSRF memo about delete ops needing to be POSTs with op="cud-delete", so it still uses a GET of ?op="delete" and fails. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 173888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173888&action=edit Bug 38328: Cannot delete ILL batch statuses You are permitted to delete ILL batch statuses that you (rather than the system) add, but the UI didn't get the CSRF memo about delete ops needing to be POSTs with op="cud-delete", so it still uses a GET of ?op="delete" and fails. Test plan: 1. Set the preference ILLModule to 'Enable' 2. Administration - Interlibrary loan batch statuses - New batch status 3. Give it a name, an uppercase code, and Save 4. Click the Delete button to the right of your new status 5. The page is blank, and if you navigate back to Interlibrary loan batch statuses, you'll see that yours was not deleted 6. Apply patch, reload page 7. Click the Delete button to the right of your new status, verify it is deleted Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173888|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 174051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174051&action=edit Bug 38328: Cannot delete ILL batch statuses You are permitted to delete ILL batch statuses that you (rather than the system) add, but the UI didn't get the CSRF memo about delete ops needing to be POSTs with op="cud-delete", so it still uses a GET of ?op="delete" and fails. Test plan: 1. Set the preference ILLModule to 'Enable' 2. Administration - Interlibrary loan batch statuses - New batch status 3. Give it a name, an uppercase code, and Save 4. Click the Delete button to the right of your new status 5. The page is blank, and if you navigate back to Interlibrary loan batch statuses, you'll see that yours was not deleted 6. Apply patch, reload page 7. Click the Delete button to the right of your new status, verify it is deleted Sponsored-by: Chetco Community Public Library Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sam.sowanick@corvallisorego | |n.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174051|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174463&action=edit Bug 38328: Cannot delete ILL batch statuses You are permitted to delete ILL batch statuses that you (rather than the system) add, but the UI didn't get the CSRF memo about delete ops needing to be POSTs with op="cud-delete", so it still uses a GET of ?op="delete" and fails. Test plan: 1. Set the preference ILLModule to 'Enable' 2. Administration - Interlibrary loan batch statuses - New batch status 3. Give it a name, an uppercase code, and Save 4. Click the Delete button to the right of your new status 5. The page is blank, and if you navigate back to Interlibrary loan batch statuses, you'll see that yours was not deleted 6. Apply patch, reload page 7. Click the Delete button to the right of your new status, verify it is deleted Sponsored-by: Chetco Community Public Library Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Needs documenting --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- No interface changes to document, just a bugfix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38328 Bug 38328 depends on bug 36192, which changed state. Bug 36192 Summary: [OMNIBUS] CSRF Protection for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org