[Bug 18980] New: Add an explanation when Anyone permission has no actual effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Bug ID: 18980 Summary: Add an explanation when Anyone permission has no actual effect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl This implements an alternative solution for bug 18834. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18834 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65229&action=edit Bug 18980: Add remark next to "Anyone seeing this list" permission This is a follow-up of report 18228 that simplifies the permissions for lists. It reapplies the idea behind bug 10865 by adding a remark next to the Anyone permission if it is not actually effective. A next patch will make it behave dynamically. Note: The Anyone permission is not relevant if it is a private list that has no shares. Note that looking at the prefs OpacAllowPublicListCreation and/or OpacAllowSharingPrivateLists is not decisive. You should look at list permissions and shares in the database; turning off the Sharing pref does not automatically remove all shares in the system. It only blocks creating new shares. We only need changes in opac-shelves.tt and virtualshelves/shelves.tt. Test plan: [1] Verify that you see the remark now in OPAC and staff. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65230&action=edit Bug 18980: Add js to dynamically show/hide the Anyone remark If we we move from Private to Public or vice versa, this should reflect on the Anyone remark from the first patch. If we go back to a private list without shares, we should show it. Handled in a js sub AdjustRemark, triggered by onchange of the category combo or the permission combo. Test plan: [1] Edit a private list without shares in OPAC. Toggle category and/or permissions. Is the remark shown or hidden accordingly? Note: Include a test with OpacAllowPublicListCreation enabled. [2] Edit a shared list or public list in staff. Toggle category/permissions. You should never see the remark. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65231&action=edit Bug 18980: Remove js function Check from opac-shelves This function only serves to check if the shelf name is not empty. It does not even work since it incorrectly refers to f.addshelf (while it should test #shelfname). We can solve this and improve consistency by doing the same as in the staff template with html5 required. Test plan: [1] Without this patch it was possible to add a list without a name in OPAC (with js error: TypeError: f.addshelf is undefined). [2] With this patch, verify that you cannot do this anymore. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 65232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65232&action=edit Bug 18980: Show distinction between shared and private lists in staff Just as we show this distinction in OPAC, this patch adds a type column in the Your lists tab that displays Private or Shared. It always contains Public in the other tab. Test plan: [1] Check if you see Shared for a private lists with shares in staff. [2] Run t/db_dependent/Utils/Datatables_Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I adjusted the patches from 18834 to arrive here. Kept the same division. Note that I removed the signoff from LeeJ on the first two patches. The other two did not really change, but were merely rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18838 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |ldjamison@marywood.edu --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- LeeJ: Any chance to retest and sign off on the first two ? Would be great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65229|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 65273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65273&action=edit Bug 18980: Add remark next to "Anyone seeing this list" permission This is a follow-up of report 18228 that simplifies the permissions for lists. It reapplies the idea behind bug 10865 by adding a remark next to the Anyone permission if it is not actually effective. A next patch will make it behave dynamically. Note: The Anyone permission is not relevant if it is a private list that has no shares. Note that looking at the prefs OpacAllowPublicListCreation and/or OpacAllowSharingPrivateLists is not decisive. You should look at list permissions and shares in the database; turning off the Sharing pref does not automatically remove all shares in the system. It only blocks creating new shares. We only need changes in opac-shelves.tt and virtualshelves/shelves.tt. Test plan: [1] Verify that you see the remark now in OPAC and staff. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65230|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 65274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65274&action=edit Bug 18980: Add js to dynamically show/hide the Anyone remark If we we move from Private to Public or vice versa, this should reflect on the Anyone remark from the first patch. If we go back to a private list without shares, we should show it. Handled in a js sub AdjustRemark, triggered by onchange of the category combo or the permission combo. Test plan: [1] Edit a private list without shares in OPAC. Toggle category and/or permissions. Is the remark shown or hidden accordingly? Note: Include a test with OpacAllowPublicListCreation enabled. [2] Edit a shared list or public list in staff. Toggle category/permissions. You should never see the remark. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65231|0 |1 is obsolete| | --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 65275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65275&action=edit Bug 18980: Remove js function Check from opac-shelves This function only serves to check if the shelf name is not empty. It does not even work since it incorrectly refers to f.addshelf (while it should test #shelfname). We can solve this and improve consistency by doing the same as in the staff template with html5 required. Test plan: [1] Without this patch it was possible to add a list without a name in OPAC (with js error: TypeError: f.addshelf is undefined). [2] With this patch, verify that you cannot do this anymore. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65232|0 |1 is obsolete| | --- Comment #10 from Marc Véron <veron@veron.ch> --- Created attachment 65276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65276&action=edit Bug 18980: Show distinction between shared and private lists in staff Just as we show this distinction in OPAC, this patch adds a type column in the Your lists tab that displays Private or Shared. It always contains Public in the other tab. Test plan: [1] Check if you see Shared for a private lists with shares in staff. [2] Run t/db_dependent/Utils/Datatables_Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marc Véron from comment #10)
Signed-off-by: Marc Véron <veron@veron.ch>
Thanks, Marc ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65273|0 |1 is obsolete| | Attachment #65274|0 |1 is obsolete| | Attachment #65275|0 |1 is obsolete| | Attachment #65276|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65347&action=edit Bug 18980: Add remark next to "Anyone seeing this list" permission This is a follow-up of report 18228 that simplifies the permissions for lists. It reapplies the idea behind bug 10865 by adding a remark next to the Anyone permission if it is not actually effective. A next patch will make it behave dynamically. Note: The Anyone permission is not relevant if it is a private list that has no shares. Note that looking at the prefs OpacAllowPublicListCreation and/or OpacAllowSharingPrivateLists is not decisive. You should look at list permissions and shares in the database; turning off the Sharing pref does not automatically remove all shares in the system. It only blocks creating new shares. We only need changes in opac-shelves.tt and virtualshelves/shelves.tt. Test plan: [1] Verify that you see the remark now in OPAC and staff. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65348&action=edit Bug 18980: Add js to dynamically show/hide the Anyone remark If we we move from Private to Public or vice versa, this should reflect on the Anyone remark from the first patch. If we go back to a private list without shares, we should show it. Handled in a js sub AdjustRemark, triggered by onchange of the category combo or the permission combo. Test plan: [1] Edit a private list without shares in OPAC. Toggle category and/or permissions. Is the remark shown or hidden accordingly? Note: Include a test with OpacAllowPublicListCreation enabled. [2] Edit a shared list or public list in staff. Toggle category/permissions. You should never see the remark. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65349&action=edit Bug 18980: Remove js function Check from opac-shelves This function only serves to check if the shelf name is not empty. It does not even work since it incorrectly refers to f.addshelf (while it should test #shelfname). We can solve this and improve consistency by doing the same as in the staff template with html5 required. Test plan: [1] Without this patch it was possible to add a list without a name in OPAC (with js error: TypeError: f.addshelf is undefined). [2] With this patch, verify that you cannot do this anymore. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65350&action=edit Bug 18980: Show distinction between shared and private lists in staff Just as we show this distinction in OPAC, this patch adds a type column in the Your lists tab that displays Private or Shared. It always contains Public in the other tab. Test plan: [1] Check if you see Shared for a private lists with shares in staff. [2] Run t/db_dependent/Utils/Datatables_Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- On the staff interface: """ Private list: Is managed by you and can be seen only by you. Public list: Can be seen by everybody, but managed only by you. """ Should not we update it? If a list is private but shared, the description is wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- AdjustRemark is a bit awkward, we could show the note only if the shelf is shared, private and changes are allowed by anyone seeing this list. Not blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #17)
AdjustRemark is a bit awkward, we could show the note only if the shelf is shared, private and changes are allowed by anyone seeing this list.
Hmm. Guess that 20 lines are a bit long to accomplish this, right? But apart from that, this sub just does what you say it should. And note it should not only show but it should also hide since it is dynamical and responds to change events on some other controls. I could compress it a bit, but essentially we need all the checks currently there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19255 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #16)
On the staff interface: """ Private list: Is managed by you and can be seen only by you. Public list: Can be seen by everybody, but managed only by you. """
Should not we update it? If a list is private but shared, the description is wrong.
Opened bug 19255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 [Bug 19255] Correct explanation about list types on shelves.pl in staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org