[Bug 23590] New: Allow to modify the manager of a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Bug ID: 23590 Summary: Allow to modify the manager of a suggestion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org When a staff member modifies a suggestion, it is automatically attributed to the logged librarian. It would be very useful to have the option to select another user that will be the one in charge of this suggestion. This other user could also be notified by an email after the suggestion is modified. This feature probably means to create new fields in the ‘suggestions’ table to separate ‘managedby’ / ‘manageddate’ from the ‘lastmodificationby’ / ‘‘lastmodificationdate’ informations, but I think it will ensure a better follow up on the suggestions workflow. The BULAC (http://www.bulac.fr/) would like to sponsor this development. As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Change sponsored?|Seeking developer |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14963, 23594, 23854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Ability to suggest purchase on existing catalogue record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 [Bug 23594] Batch modification for itemtypes on suggestions page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 [Bug 23854] Cannot edit a suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95162&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95163&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95164&action=edit Bug 23590: Cleaning - Remove op_* vars -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95165&action=edit Bug 23590: Batch update manager for suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95166&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95167&action=edit Bug 23590: Add the ability to notify a new manager -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95168&action=edit Bug 23590: Display managed date in 'Your purchase suggestions' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95169&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Séverine Queune <severine.queune@bulac.fr> --- Patch failed on both sandbox and devbox. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23590: Add ability to edit the manager of a suggestion fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 23590: Add ability to edit the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_23590 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The patches need to be applied in the following (reverse) order: Bug 23590: Add lastmodification by and date columns Bug 23590: Display managed date in 'Your purchase suggestions' Bug 23590: Add the ability to notify a new manager Bug 23590: Only return patrons that have the suggestions_manage permission Bug 23590: Batch update manager for suggestions Bug 23590: Cleaning - Remove op_* vars Bug 23590: Clean TT variables for patrons Bug 23590: Add ability to edit the manager of a suggestion Bug 14963: Set status=ORDERED for suggestions created from existing record Bug 14963: Add the ability to suggest purchase on existing title Bug 23854: Fix failure on dates when editing a suggestion Bug 23594: Restore previous view after delete or update itemtype Bug 23594: Fix [un]checkall links Bug 23594: Batch modification for itemtypes on suggestions page Bug 14973: Add missing filters in templates Bug 14973: Remove double declaration of suggestions_loop Bug 14973: Remove double textarea for notes Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) If it can help, I have pushed a branch with all the patches applied: https://gitlab.com/joubu/Koha/commits/bug_23590 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95162|0 |1 is obsolete| | Attachment #95163|0 |1 is obsolete| | Attachment #95164|0 |1 is obsolete| | Attachment #95165|0 |1 is obsolete| | Attachment #95166|0 |1 is obsolete| | Attachment #95167|0 |1 is obsolete| | Attachment #95168|0 |1 is obsolete| | Attachment #95169|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95317&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95318&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95319&action=edit Bug 23590: Cleaning - Remove op_* vars -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95320&action=edit Bug 23590: Batch update manager for suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95321&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95322&action=edit Bug 23590: Add the ability to notify a new manager -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95323&action=edit Bug 23590: Display managed date in 'Your purchase suggestions' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95324&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #19 from Séverine Queune <severine.queune@bulac.fr> --- Hi Jonathan, After I apply the patches, none of my suggestions are displayed. Do you know where it can come from ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95398&action=edit Bug 23590: Add atomic update file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95399&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Séverine Queune <severine.queune@bulac.fr> --- On step 8-9 : when I select a new manager, the checkbox to notify stays disabled even if there is a valid email (I didn't notice that point on my first tests and I correctly received an email at that moment, but I can't reproduce it on my second tests) On step 14 : the pop-up to select the new manager for several suggestions only works on the first "Accepted" tab On step 15 : I don't see the "managed date" on OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95399|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95407&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95408&action=edit Bug 23590: Fix select manager on list for all tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Séverine Queune from comment #22)
On step 8-9 : when I select a new manager, the checkbox to notify stays disabled even if there is a valid email (I didn't notice that point on my first tests and I correctly received an email at that moment, but I can't reproduce it on my second tests)
Fixed
On step 14 : the pop-up to select the new manager for several suggestions only works on the first "Accepted" tab
And fixed!
On step 15 : I don't see the "managed date" on OPAC
Looks ok for me: https://snipboard.io/KZ9bQS.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95420&action=edit Bug 23590: DBIC Changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95317|0 |1 is obsolete| | --- Comment #27 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95421&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95318|0 |1 is obsolete| | --- Comment #28 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95422&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95319|0 |1 is obsolete| | --- Comment #29 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95423&action=edit Bug 23590: Cleaning - Remove op_* vars Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95320|0 |1 is obsolete| | --- Comment #30 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95424&action=edit Bug 23590: Batch update manager for suggestions Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95321|0 |1 is obsolete| | --- Comment #31 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95425&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95322|0 |1 is obsolete| | --- Comment #32 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95426&action=edit Bug 23590: Add the ability to notify a new manager Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95323|0 |1 is obsolete| | --- Comment #33 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95427&action=edit Bug 23590: Display managed date in 'Your purchase suggestions' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95324|0 |1 is obsolete| | --- Comment #34 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95428&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95407|0 |1 is obsolete| | --- Comment #35 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95429&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95408|0 |1 is obsolete| | --- Comment #36 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95430&action=edit Bug 23590: Fix select manager on list for all tabs Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95420|0 |1 is obsolete| | --- Comment #37 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95431&action=edit Bug 23590: DBIC Changes Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #38 from Séverine Queune <severine.queune@bulac.fr> --- Great development, thanks a lot Jonathan ! (In reply to Jonathan Druart from comment #25)
On step 15 : I don't see the "managed date" on OPAC
Looks ok for me: https://snipboard.io/KZ9bQS.jpg My bad, OpacSuggestionManagedBy needs to be enabled.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95398|0 |1 is obsolete| | Attachment #95421|0 |1 is obsolete| | Attachment #95422|0 |1 is obsolete| | Attachment #95423|0 |1 is obsolete| | Attachment #95424|0 |1 is obsolete| | Attachment #95425|0 |1 is obsolete| | Attachment #95426|0 |1 is obsolete| | Attachment #95427|0 |1 is obsolete| | Attachment #95428|0 |1 is obsolete| | Attachment #95429|0 |1 is obsolete| | Attachment #95430|0 |1 is obsolete| | Attachment #95431|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95487&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95488&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95489&action=edit Bug 23590: Cleaning - Remove op_* vars Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95490&action=edit Bug 23590: Batch update manager for suggestions Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95491&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95492&action=edit Bug 23590: Add the ability to notify a new manager Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95493&action=edit Bug 23590: Display managed date in 'Your purchase suggestions' Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95494&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95495&action=edit Bug 23590: Add atomic update file Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95496&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95497&action=edit Bug 23590: Fix select manager on list for all tabs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95498&action=edit Bug 23590: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 [Bug 22784] Archiving Purchase Suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #51 from Liz Rea <wizzyrea@gmail.com> --- This still applies, QA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Bug 23590 depends on bug 14963, which changed state. Bug 14963 Summary: Add the ability to suggest purchase from existing titles https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Onto the next one... Jonathan, can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95487|0 |1 is obsolete| | Attachment #95488|0 |1 is obsolete| | Attachment #95489|0 |1 is obsolete| | Attachment #95490|0 |1 is obsolete| | Attachment #95491|0 |1 is obsolete| | Attachment #95492|0 |1 is obsolete| | Attachment #95493|0 |1 is obsolete| | Attachment #95494|0 |1 is obsolete| | Attachment #95495|0 |1 is obsolete| | Attachment #95496|0 |1 is obsolete| | Attachment #95497|0 |1 is obsolete| | Attachment #95498|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98119&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98120&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98121&action=edit Bug 23590: Cleaning - Remove op_* vars Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98122&action=edit Bug 23590: Batch update manager for suggestions Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98123&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98124&action=edit Bug 23590: Add the ability to notify a new manager Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98126&action=edit Bug 23590: Display managed date in 'Your purchase suggestions' Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98127&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98128&action=edit Bug 23590: Add atomic update file Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98129&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98130&action=edit Bug 23590: Fix select manager on list for all tabs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98131&action=edit Bug 23590: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 98240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98240&action=edit Bug 23590: (QA follow-up) Add missing filters and drop script type Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks like Katrin is on the case here.. so just uploading a followup to silence the warning from the QA scripts and leaving Katrin to finish :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98267&action=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98267|0 |1 is obsolete| | --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98268&action=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) - Remove '- ' displying before the date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #69 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Notes & questions 1) We might want to modify the bug title a little - in addition to allow changing the manager, this will also store the last person to change and date. Also gives a checkbox for TO_PROCESS. We really needs some release notes :) 2) lastmodificationdate and lastmodificationby are quite long. It might be nicer to used something more readable like: last_modified_on and last_modified_by. Not blocker for me, but putting the thought out there. 3) Is there a reason why we don't let the db update thelastmodificationdate? 4) Please check my follow-up Blockers 1) When I change the manager, the lastmodification* are not updated. 2) The TO_PROCESS email goes to the fund owner - this patch is reusing it for the manager. I believe this should be handled separately. ( Bug 13014: Notify budget owner on new suggestion - cronjob) 3) + if ( $notify ) { + my $patron = Koha::Patrons->find( $suggestion_only->{managedby} ); + my $email_address = $patron->notice_email_address; + if ($patron->notice_email_address) { + my $budget = C4::Budgets::GetBudget( $suggestion_only->{budgetid} ); $budget appears not to be used - possibly a copy&paste because of 2). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it would have been nice to split this: - Add last modification* - Add ability to change manager - Add ability to notify - last bit could still be pulled out maybe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #69)
Notes & questions
1) We might want to modify the bug title a little - in addition to allow changing the manager, this will also store the last person to change and date. Also gives a checkbox for TO_PROCESS. We really needs some release notes :)
Any suggestions? :)
2) lastmodificationdate and lastmodificationby are quite long. It might be nicer to used something more readable like: last_modified_on and last_modified_by. Not blocker for me, but putting the thought out there.
I followed the existing pattern As there were already 4 of those I thought it was better to keep names consistent.
3) Is there a reason why we don't let the db update thelastmodificationdate?
We can pick the max date of suggesteddate, manageddate, accepteddate, rejecteddate, is that was you have in mind?
4) Please check my follow-up
They look good, thanks!
Blockers
1) When I change the manager, the lastmodification* are not updated.
That was expected (I think). The field lastmodification* are only updated when the suggestion is edited via the edit form. If we want to update it whenever the table is updated, the change must be moved to ModSuggestion. Séverine, can you confirm the behavior you expect?
2) The TO_PROCESS email goes to the fund owner - this patch is reusing it for the manager. I believe this should be handled separately. ( Bug 13014: Notify budget owner on new suggestion - cronjob)
That was part of the original specification. It makes sense to have 2 different notice templates. Something to suggest? UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER?
3) + if ( $notify ) { + my $patron = Koha::Patrons->find( $suggestion_only->{managedby} ); + my $email_address = $patron->notice_email_address; + if ($patron->notice_email_address) { + my $budget = C4::Budgets::GetBudget( $suggestion_only->{budgetid} ); $budget appears not to be used - possibly a copy&paste because of 2).
Indeed, follow-up coming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98279&action=edit Bug 23590: remove unused variable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Bug 23590 depends on bug 23594, which changed state. Bug 23594 Summary: Batch modification for itemtypes on suggestions page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98119|0 |1 is obsolete| | Attachment #98120|0 |1 is obsolete| | Attachment #98121|0 |1 is obsolete| | Attachment #98122|0 |1 is obsolete| | Attachment #98123|0 |1 is obsolete| | Attachment #98124|0 |1 is obsolete| | Attachment #98126|0 |1 is obsolete| | Attachment #98127|0 |1 is obsolete| | Attachment #98128|0 |1 is obsolete| | Attachment #98129|0 |1 is obsolete| | Attachment #98130|0 |1 is obsolete| | Attachment #98131|0 |1 is obsolete| | Attachment #98240|0 |1 is obsolete| | Attachment #98268|0 |1 is obsolete| | Attachment #98279|0 |1 is obsolete| | --- Comment #73 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100788&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #74 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100789&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100790&action=edit Bug 23590: Cleaning - Remove op_* vars Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100791&action=edit Bug 23590: Batch update manager for suggestions Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100792&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100793&action=edit Bug 23590: Add the ability to notify a new manager Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100794&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100795&action=edit Bug 23590: Add atomic update file Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #81 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100796&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100797&action=edit Bug 23590: Fix select manager on list for all tabs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #83 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100798&action=edit Bug 23590: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #84 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100799&action=edit Bug 23590: (QA follow-up) Add missing filters and drop script type Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #85 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100800&action=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) - Remove '- ' displying before the date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #86 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100801&action=edit Bug 23590: remove unused variable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #87 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100802&action=edit Bug 23590: Update new fields with relevant values We are filling lastmodificationdate and lastmodificationby depending on the max dates between manageddate, accepteddate and rejecteddate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #88 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100803&action=edit Bug 23590: Fix ergonomic issue if last modification by is empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #89 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100804&action=edit Bug 23590: Create a separate template notice NOTIFY_MANAGER To separate the two feature we want to create a distinct template notice. A new NOTIFY_MANAGER notice is added. A follow-up patch will be added for other languages, when this one will be approved by QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow to modify the manager |Allow to modify and notify |of a suggestion |the manager of a suggestion Text to go in the| |This new feature adds the release notes| |ability to modify the | |manager of a suggestion. | |When assigning a suggestion | |to a new manager, a notice | |NOTIFY_MANAGER could be | |sent to the manager to | |alert them. | | | |To keep track | |of the different | |modification, 2 new columns | |are added to the suggestion | |table: lastmodificationby | |and lastmodificationdate, | |which will be updated | |automatically when a | |suggestion is edited. --- Comment #90 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #71)
(In reply to Katrin Fischer from comment #69)
Notes & questions
1) We might want to modify the bug title a little - in addition to allow changing the manager, this will also store the last person to change and date. Also gives a checkbox for TO_PROCESS. We really needs some release notes :)
Any suggestions? :)
2) lastmodificationdate and lastmodificationby are quite long. It might be nicer to used something more readable like: last_modified_on and last_modified_by. Not blocker for me, but putting the thought out there.
I followed the existing pattern As there were already 4 of those I thought it was better to keep names consistent.
3) Is there a reason why we don't let the db update thelastmodificationdate?
We can pick the max date of suggesteddate, manageddate, accepteddate, rejecteddate, is that was you have in mind?
4) Please check my follow-up
They look good, thanks!
Blockers
1) When I change the manager, the lastmodification* are not updated.
That was expected (I think). The field lastmodification* are only updated when the suggestion is edited via the edit form. If we want to update it whenever the table is updated, the change must be moved to ModSuggestion.
Séverine, can you confirm the behavior you expect?
2) The TO_PROCESS email goes to the fund owner - this patch is reusing it for the manager. I believe this should be handled separately. ( Bug 13014: Notify budget owner on new suggestion - cronjob)
That was part of the original specification. It makes sense to have 2 different notice templates. Something to suggest? UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER?
3) + if ( $notify ) { + my $patron = Koha::Patrons->find( $suggestion_only->{managedby} ); + my $email_address = $patron->notice_email_address; + if ($patron->notice_email_address) { + my $budget = C4::Budgets::GetBudget( $suggestion_only->{budgetid} ); $budget appears not to be used - possibly a copy&paste because of 2).
Indeed, follow-up coming.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #91 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #71)
(In reply to Katrin Fischer from comment #69)
Notes & questions
1) We might want to modify the bug title a little - in addition to allow changing the manager, this will also store the last person to change and date. Also gives a checkbox for TO_PROCESS. We really needs some release notes :)
Any suggestions? :)
Done, hope that makes sense.
3) Is there a reason why we don't let the db update thelastmodificationdate?
We can pick the max date of suggesteddate, manageddate, accepteddate, rejecteddate, is that was you have in mind?
I added a follow-up to update the 2 new columns.
Blockers
1) When I change the manager, the lastmodification* are not updated.
That was expected (I think). The field lastmodification* are only updated when the suggestion is edited via the edit form. If we want to update it whenever the table is updated, the change must be moved to ModSuggestion.
Séverine, can you confirm the behavior you expect?
Still waiting for an answer here, but I think we could fix that on a follow-up if needed. The change will be minor compared to the work needed to keep this patchset up-to-date with master.
2) The TO_PROCESS email goes to the fund owner - this patch is reusing it for the manager. I believe this should be handled separately. ( Bug 13014: Notify budget owner on new suggestion - cronjob)
That was part of the original specification. It makes sense to have 2 different notice templates. Something to suggest? UPDATE_MANAGER, SUGGEST_MANAGER, TO_PROCESS_MANAGER?
Done, a new template notice "NOTIFY_MANAGER" has been added. Sending back to the QA queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Almost there - thx for the work on the notice. 1) I think this slipped in from another feature in the tree (22784): + <label for="archived" style="display: inline;">Include archived:</label> + <input type="checkbox" id="archived" name="filter_archived" value="archived" title="Include archived suggestions in the search" /> + </li> + <li> 2) From comment#91
1) When I change the manager, the lastmodification* are not updated.
That was expected (I think). The field lastmodification* are only updated when the suggestion is edited via the edit form. If we want to update it whenever the table is updated, the change must be moved to ModSuggestion.
Séverine, can you confirm the behavior you expect?
Still waiting for an answer here, but I think we could fix that on a follow-up if needed. The change will be minor compared to the work needed to keep this patchset up-to-date with master. -- This one is confusing to me and I keep wondering if this should have been more than one bug :) So at the moment, in suggestions we got: `date` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time the suggestion was updated lastmodificationby INT(11) default NULL, -- borrowernumber for the librarian who edit the suggestion for the last time lastmodificationdate date default NULL, -- date of the last modification So date is actually always updated and should probably be renamed 'datetime' or similar. What is the use case for the additional lastmodificationdate?
From the description it's not clear to me. Do we really need it if we have date?
Please feel free to get others to look at this - 1) should be a quick fix, 2) is a bit puzzling to me right now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100797|0 |1 is obsolete| | --- Comment #93 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100846&action=edit Bug 23590: Fix select manager on list for all tabs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100798|0 |1 is obsolete| | --- Comment #94 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100847&action=edit Bug 23590: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100799|0 |1 is obsolete| | --- Comment #95 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100848&action=edit Bug 23590: (QA follow-up) Add missing filters and drop script type Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100800|0 |1 is obsolete| | --- Comment #96 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100849&action=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) - Remove '- ' displying before the date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100801|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100850&action=edit Bug 23590: remove unused variable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100802|0 |1 is obsolete| | --- Comment #98 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100851&action=edit Bug 23590: Update new fields with relevant values We are filling lastmodificationdate and lastmodificationby depending on the max dates between manageddate, accepteddate and rejecteddate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100803|0 |1 is obsolete| | --- Comment #99 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100852&action=edit Bug 23590: Fix ergonomic issue if last modification by is empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100804|0 |1 is obsolete| | --- Comment #100 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100853&action=edit Bug 23590: Create a separate template notice NOTIFY_MANAGER To separate the two feature we want to create a distinct template notice. A new NOTIFY_MANAGER notice is added. A follow-up patch will be added for other languages, when this one will be approved by QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #101 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #92)
Almost there - thx for the work on the notice.
1) I think this slipped in from another feature in the tree (22784):
+ <label for="archived" style="display: inline;">Include archived:</label> + <input type="checkbox" id="archived" name="filter_archived" value="archived" title="Include archived suggestions in the search" /> + </li> + <li>
Oops, fixed.
2) From comment#91
1) When I change the manager, the lastmodification* are not updated.
That was expected (I think). The field lastmodification* are only updated when the suggestion is edited via the edit form. If we want to update it whenever the table is updated, the change must be moved to ModSuggestion.
Séverine, can you confirm the behavior you expect?
Still waiting for an answer here, but I think we could fix that on a follow-up if needed. The change will be minor compared to the work needed to keep this patchset up-to-date with master. --
This one is confusing to me and I keep wondering if this should have been more than one bug :) So at the moment, in suggestions we got:
`date` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time the suggestion was updated
lastmodificationby INT(11) default NULL, -- borrowernumber for the librarian who edit the suggestion for the last time lastmodificationdate date default NULL, -- date of the last modification
So date is actually always updated and should probably be renamed 'datetime' or similar. What is the use case for the additional lastmodificationdate? From the description it's not clear to me. Do we really need it if we have date?
suggestions.date must be renamed timestamp, I agree with that. I can commit on renaming it on a separate bug report. The lastmodificationdate is the date when lastmodificationby has been updated. And they are updated when a suggestion is modified, explicitly from the UI. It's not set when the suggestion is created, but only when modified. Also not updated when the status is set to ORDERED, for instance. As said early, one advantage is also to follow the same pattern of the 4 existing fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #102 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Lately, we've been sticking to: created_on created_by updated_on updated_by I understand this is not exactly the same as updated_on but... lastmodificationdate? I would stick to updated_on and find something else for the status change (e.g. status_updated_on) My 2 cents -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #103 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would like to stick with the existing pattern: `suggestedby` int(11) DEFAULT NULL, `suggesteddate` date NOT NULL, `managedby` int(11) DEFAULT NULL, `manageddate` date DEFAULT NULL, `acceptedby` int(11) DEFAULT NULL, `accepteddate` date DEFAULT NULL, `rejectedby` int(11) DEFAULT NULL, `rejecteddate` date DEFAULT NULL, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #104 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- If they need to be reworded, they will be reworded on a follow-up bug report. But all at once. I will do if requested. Do not you think it's better than having 2 different patterns for the same table? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #105 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #104)
If they need to be reworded, they will be reworded on a follow-up bug report. But all at once. I will do if requested.
Do not you think it's better than having 2 different patterns for the same table?
I'm fine with doing it on a separate bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24887 [Bug 24887] columns of suggestions need to be renamed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #106 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have opened bug 24887. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Fanny Mion Mouton <fanny.mion-mouton@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fanny.mion-mouton@bulac.fr --- Comment #107 from Fanny Mion Mouton <fanny.mion-mouton@bulac.fr> --- Dear All, very sorry for the delayed answer on this : Séverine is not currently working so we left it unanswered... I will try to answer it, but please don't hesitate to ask for more precisions if needed : 1) When I change the manager, the lastmodification* are not updated.
That was expected (I think). The field lastmodification* are only updated when the suggestion is edited via the edit form. If we want to update it whenever the table is updated, the change must be moved to ModSuggestion.
Séverine, can you confirm the behavior you expect?
Still waiting for an answer here, but I think we could fix that on a follow-up if needed. The change will be minor compared to the work needed to keep this patchset up-to-date with master.
Yes it was the expected behavior. We don't need the last modification to be updated as long as it is not updated with the edit form. We consider that the suggestion has not really begun to be processed as long as the edit form has not beeing used : the relevant librarian to process it was not "manager" of the suggestion. Regarding statistics for delay of suggestion management, it will be more useful not to consider this as a last date of modification. Does it make sense ?
Thanks again and sorry for the delay ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #108 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- One step closer, sorry, found another thing: In the patron search for new manager, I can only find patrons with superlibrarian, but not with manage_suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #109 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101539&action=edit Bug 23590: Fix 'select manager' when creation a suggestion On creating the TT var managedby_patron does not exist yet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24964 --- Comment #110 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #108)
One step closer, sorry, found another thing:
In the patron search for new manager, I can only find patrons with superlibrarian, but not with manage_suggestions
That's a known bug, see bug 24964. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #111 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #109)
Created attachment 101539 [details] [review] Bug 23590: Fix 'select manager' when creation a suggestion
On creating the TT var managedby_patron does not exist yet
That's for another bug I found when trying again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100847|0 |1 is obsolete| | --- Comment #112 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101548&action=edit Bug 23590: DBIC Changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100788|0 |1 is obsolete| | --- Comment #113 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101588&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100789|0 |1 is obsolete| | --- Comment #114 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101589&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100790|0 |1 is obsolete| | --- Comment #115 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101590&action=edit Bug 23590: Cleaning - Remove op_* vars Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100791|0 |1 is obsolete| | --- Comment #116 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101591&action=edit Bug 23590: Batch update manager for suggestions Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100792|0 |1 is obsolete| | --- Comment #117 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101592&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100793|0 |1 is obsolete| | --- Comment #118 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101593&action=edit Bug 23590: Add the ability to notify a new manager Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100794|0 |1 is obsolete| | --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101594&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100795|0 |1 is obsolete| | --- Comment #120 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101595&action=edit Bug 23590: Add atomic update file Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100796|0 |1 is obsolete| | --- Comment #121 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101596&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100846|0 |1 is obsolete| | --- Comment #122 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101597&action=edit Bug 23590: Fix select manager on list for all tabs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100848|0 |1 is obsolete| | --- Comment #123 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101598&action=edit Bug 23590: (QA follow-up) Add missing filters and drop script type Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100849|0 |1 is obsolete| | --- Comment #124 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101599&action=edit Bug 23590: (QA follow-up) Fix some problems created by recent changes and updatedatabase statement - Ensure that the sequence of columns will be the same for new and updated installations (add AFTER ...) - Fix permissions (see bug 22868) - Fix column configuration (see 16784) - Remove '- ' displying before the date Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100850|0 |1 is obsolete| | --- Comment #125 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101600&action=edit Bug 23590: remove unused variable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100851|0 |1 is obsolete| | --- Comment #126 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101601&action=edit Bug 23590: Update new fields with relevant values We are filling lastmodificationdate and lastmodificationby depending on the max dates between manageddate, accepteddate and rejecteddate Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100852|0 |1 is obsolete| | --- Comment #127 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101602&action=edit Bug 23590: Fix ergonomic issue if last modification by is empty Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100853|0 |1 is obsolete| | --- Comment #128 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101603&action=edit Bug 23590: Create a separate template notice NOTIFY_MANAGER To separate the two feature we want to create a distinct template notice. A new NOTIFY_MANAGER notice is added. A follow-up patch will be added for other languages, when this one will be approved by QA. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101539|0 |1 is obsolete| | --- Comment #129 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101604&action=edit Bug 23590: Fix 'select manager' when creation a suggestion On creating the TT var managedby_patron does not exist yet Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101548|0 |1 is obsolete| | --- Comment #130 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101605&action=edit Bug 23590: DBIC Changes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #131 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101606&action=edit Bug 23590: (QA follow-up) Fix links to patron records (TT variable confusion) Fixes links to the patron accounts from the edit and list view of suggestions. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #132 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #133 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101695&action=edit Bug 23590: Add notice template for translated installer files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #134 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow to modify and notify |Add the ability to change |the manager of a suggestion |the manager of a suggestion | |and notify the new manager -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds the |This new feature adds the release notes|ability to modify the |ability to modify the |manager of a suggestion. |manager of a suggestion. |When assigning a suggestion |When assigning a suggestion |to a new manager, a notice |to a new manager, a notice |NOTIFY_MANAGER could be |NOTIFY_MANAGER can be sent |sent to the manager to |to the manager to alert |alert them. |them. | | |To keep track |To keep track of the |of the different |different modification, 2 |modification, 2 new columns |new columns are added to |are added to the suggestion |the suggestion table: |table: lastmodificationby |lastmodificationby and |and lastmodificationdate, |lastmodificationdate, which |which will be updated |will be updated |automatically when a |automatically when a |suggestion is edited. |suggestion is edited. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds the |This enhancement to the release notes|ability to modify the |purchase suggestions |manager of a suggestion. |process adds the ability to |When assigning a suggestion |modify the manager of a |to a new manager, a notice |suggestion. |NOTIFY_MANAGER can be sent | |to the manager to alert |When assigning |them. |a suggestion to a new | |manager, the new notice |To keep track of the |`NOTIFY_MANAGER` will be |different modification, 2 |sent to the manager to |new columns are added to |alert them. |the suggestion table: | |lastmodificationby and |To keep track |lastmodificationdate, which |of the different |will be updated |modifications, 2 new |automatically when a |columns are added to the |suggestion is edited. |suggestion table: | |`lastmodificationby` and | |`lastmodificationdate`, | |which will be updated | |automatically when a | |suggestion is edited. Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 [Bug 26738] Unable to change manager of purchase suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #135 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Should the notice be named NOTIFY_MANAGER_CHANGE? Just in case we want to add other notices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #136 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #135)
Should the notice be named NOTIFY_MANAGER_CHANGE? Just in case we want to add other notices.
This has already been released, so I think better to change when we actually implement another notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26898 [Bug 26898] Notify new manager when updating suggestions from suggestions homepage -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27608 [Bug 27608] Correct 'accepted by' inconsistency in suggestion.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28408 [Bug 28408] Last modification date for suggestions is wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855 [Bug 28855] Purging Suggestions test should not being on timestamp -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28946 [Bug 28946] 500 error when choosing patron for purchase suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29943 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29943 [Bug 29943] Fix typo in notices yaml file -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org