[Bug 21098] New: Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 Bug ID: 21098 Summary: Add missing budget optgroups to parcels.tt and newemptyorder.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org orderreceive.tt uses optgroup tags to organise funds into budgets, but this same functionality is missing on parcels.tt and newemptyorder.tt. If you have funds in different budgets with the same or similar descriptions, it becomes impossible to differentiate funds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 77153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77153&action=edit Bug 21098 - Add missing budget optgroups to parcels.tt and newemptyorder.tt I noticed that orderreceive.tt organizes funds by budget, but neworderempty.tt and parcels.tt do not. That is to say, when placing an order there is no organisation of funds in the drop-down menu, but there is when you recive an order, but not when you receive a shipment (ie choose a Shipping fund). This patch seeks to harmonize the user experience, so that users are always seeing funds organised by budget. _TEST PLAN_ 1. Add two budgets 2. Add one fund to each budget 3. Add a vendor 4. Add a basket 5. Add an order 5b. Note that you can now see funds grouped by budget 6. Close the basket 7. Receive the shipment 7b. Note that you can now see funds groups by budget 8. Receive the order 8b. Note that the organisation of funds is the same as the other two areas (even though the patch doesn't touch this one). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21097 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 John Sterbenz <jsterben@umich.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsterben@umich.edu --- Comment #2 from John Sterbenz <jsterben@umich.edu> --- 20180918: Failed testing Patch applied to master on (new) Bywater sandboxes. Verify fail: Apply patch to master As necessary, create and appropriate a budget As necessary, create and appropriate a fund within that budget As necessary, create a vendor As necessary, create a basket Select "Add to basket" Select "From a new (empty) record: ERROR: Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt line 783: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 122 This also fails for Z39.50 cataloging record selection--perform search, pick a record from results list, click "Order"--same error. Untested for other "Add order to basket" methods. See https://drive.google.com/open?id=1jWM6wIoUTcu5CSQYeGJaYj_V2uIwZLjM (anyone with link can view)--files include a longer version that first replicated the problem. The steps above skip the replication on a system with the patch applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77153|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 82526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82526&action=edit Bug 21098 - Add missing budget optgroups to parcels.tt and newemptyorder.tt I noticed that orderreceive.tt organizes funds by budget, but neworderempty.tt and parcels.tt do not. That is to say, when placing an order there is no organisation of funds in the drop-down menu, but there is when you recive an order, but not when you receive a shipment (ie choose a Shipping fund). This patch seeks to harmonize the user experience, so that users are always seeing funds organised by budget. _TEST PLAN_ 1. Add two budgets 2. Add one fund to each budget 3. Add a vendor 4. Add a basket 5. Add an order 5b. Note that you can now see funds grouped by budget 6. Close the basket 7. Receive the shipment 7b. Note that you can now see funds groups by budget 8. Receive the order 8b. Note that the organisation of funds is the same as the other two areas (even though the patch doesn't touch this one). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82526|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82878&action=edit Bug 21098: Add missing budget optgroups to parcels.tt and newemptyorder.tt I noticed that orderreceive.tt organizes funds by budget, but neworderempty.tt and parcels.tt do not. That is to say, when placing an order there is no organisation of funds in the drop-down menu, but there is when you recive an order, but not when you receive a shipment (ie choose a Shipping fund). This patch seeks to harmonize the user experience, so that users are always seeing funds organised by budget. _TEST PLAN_ 1. Add two budgets 2. Add one fund to each budget 3. Add a vendor 4. Add a basket 5. Add an order 5b. Note that you can now see funds grouped by budget 6. Close the basket 7. Receive the shipment 7b. Note that you can now see funds groups by budget 8. Receive the order 8b. Note that the organisation of funds is the same as the other two areas (even though the patch doesn't touch this one). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Thanks, Owen :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The "Show inactive" does not seem to work on parcels.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #6)
The "Show inactive" does not seem to work on parcels.pl
Thanks, Jonathan. I'll take a look at that when I have a moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #6)
The "Show inactive" does not seem to work on parcels.pl
This is wrong, it works. I had budget_amount==0 The behavior between the 2 views is different, because of: neworderemtpy.pl 324 if (!defined $r->{budget_amount} || $r->{budget_amount} <0) { and parcels.pl 186 if (!defined $r->{budget_amount} || $r->{budget_amount} == 0) { You can forget my comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82878|0 |1 is obsolete| | --- Comment #9 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 83824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83824&action=edit Bug 21098: Add missing budget optgroups to parcels.tt and newemptyorder.tt I noticed that orderreceive.tt organizes funds by budget, but neworderempty.tt and parcels.tt do not. That is to say, when placing an order there is no organisation of funds in the drop-down menu, but there is when you recive an order, but not when you receive a shipment (ie choose a Shipping fund). This patch seeks to harmonize the user experience, so that users are always seeing funds organised by budget. _TEST PLAN_ 1. Add two budgets 2. Add one fund to each budget 3. Add a vendor 4. Add a basket 5. Add an order 5b. Note that you can now see funds grouped by budget 6. Close the basket 7. Receive the shipment 7b. Note that you can now see funds groups by budget 8. Receive the order 8b. Note that the organisation of funds is the same as the other two areas (even though the patch doesn't touch this one). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jose-Mario <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, there is one noticeable and big difference: With the patch you see the optgroups of budgets, even if there are no funds listed below. That makes the list grow long, especially as it also includes the inactive ones by default. Combinations I tested: - Active budget with multi-level funds - ok - Inactive budget with fund - not ok, budget is listed - Locked budget with fund - not ok, budget is listed - Active budget with funds that are not accessible by permission (restricted to owner) - not ok This would for example be used to separate budgets and funds of different libraries in a system and could also make the list quite long. I really like the idea of this improvement, but I think we are not there yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #10)
Hi,
there is one noticeable and big difference: With the patch you see the optgroups of budgets, even if there are no funds listed below. That makes the list grow long, especially as it also includes the inactive ones by default.
Combinations I tested: - Active budget with multi-level funds - ok - Inactive budget with fund - not ok, budget is listed - Locked budget with fund - not ok, budget is listed - Active budget with funds that are not accessible by permission (restricted to owner) - not ok This would for example be used to separate budgets and funds of different libraries in a system and could also make the list quite long.
I really like the idea of this improvement, but I think we are not there yet.
Do you know if this is comparable to orderreceive.tt? My original plan was just to bring parcels.tt and newemptyorder.tt in line with that template. Did inactive and locked budgets not show before the patch? I'm not sure I understand the "accessible by permission" part. I think the code for that is identical before and after the patch? If the list were long, I would think having optgroup tags would be essential for organising them? Otherwise the select list would be difficult to navigate. I'm not sure that I understand this part of the feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- This is a change that I already manage locally so I'm probably unlikely to revise this patch any time soon. I'll remove myself as Assignee, but re-add myself if I do find myself with some time to try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wrote difference because the behaviour is different to the already existing drop down on receive. This one works correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- "By permission" would for example be a fund managed by another library in the system that is restricted to users, owners and staff patrons from this library. With you patch I seee the budget, even if I can't order from any fund below it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- Still relevant but I think the failure is still relevant too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- Looks like this is still a problem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41553 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org