[Bug 14457] Integrate LIBRIS spellchecking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #20)
Looking at the code this seems a very specific feature, like Amazon-Covers, Syndectics, etc.
Koha::SuggestionEngine::Plugin::LibrisSpellcheck; The name does not tell that this is only interesting for Swedish libs.
So if the URL is always the same and there is no other service this plugin works with - a configuration option doesn't seem necessary.
The URL has changed already :) Note that e.g. Syndetics has 12 prefs or so in Koha. (In reply to Eivin Giske Skaaren from comment #21)
It seems like they have changed the url to http://api.libris.kb.se/bibspell/ so perhaps some way of changing it without committing code would be good. Please advise on the preferred solution. I do not really oppose a pref here. But you could use a local pref, or an "undocumented" koha-conf variable. Not ideal, since you would reference it from standard code..
The whole problem here is: How do we adjust Koha to include various language specific features (like this one)? Should they be part of the core code or not? Note that we recently had such a discussion about NorwegianPatronDB. There is no clear answer yet. For the time being, I would not oppose two prefs and toggling this feature via admin/didyoumean. Final word to the RM. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org