[Bug 15317] New: Use Bootstrap modal for MARC and Card preview when ordering from staged files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Bug ID: 15317 Summary: Use Bootstrap modal for MARC and Card preview when ordering from staged files Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/addorderiso2709.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 8290 When adding to an order from a staged file, the "MARC" and "Card" links should trigger a preview in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45447&action=edit Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from a staged file so that the "MARC" and "Card" previews display in Bootstrap modals. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from a staged file. 4. Click "Add orders" from any staged file. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45447|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 45455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45455&action=edit Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from a staged file so that the "MARC" and "Card" previews display in Bootstrap modals. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from a staged file. 4. Click "Add orders" from any staged file. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 45455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45455 Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files Review of attachment 45455: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15317&attachment=45455) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt @@ +10,2 @@
<link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> +<style type="text/css">#dataPreview { width : 80%; margin-left : -40%; } @media (max-width: 767px) { #dataPreview { margin: 0; width : auto; } }</style>
Why do we need a special style for this one? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #3)
Why do we need a special style for this one?
It's not a special style just for this patch. Others have a similar addition. The default Bootstrap modal isn't very wide. I'd be happy to work on follow-ups to get some of that code consolidated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45455|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45642&action=edit Bug 15317 - Use Bootstrap modal for MARC and Card preview when ordering from staged files In order to reduce the number of dependencies for common interactions we should attempt to use Bootstrap modals in place of Greybox ones. This patch modifies the page in Acquisitions for ordering from a staged file so that the "MARC" and "Card" previews display in Bootstrap modals. To test: 1. Apply the patch and navigate to Acquisitions. 2. Locate an exsiting basket or create a new one. 3. Add to the basket using the option to order from a staged file. 4. Click "Add orders" from any staged file. 5. Test the "MARC" and "Card" links for multiple results and confirm that the correct data is shown each time. Followed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15317 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Severity|minor |enhancement --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Switching severity to 'enhancement' as the patch does not fix any bug -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org