[Bug 18789] New: Send a Koha::Patron object to the templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Bug ID: 18789 Summary: Send a Koha::Patron object to the templates Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 18403 The simplify and make uniform the code, the controller scripts should send a Koha::Patron object to the templates and not all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64211&action=edit Bug 18789: Send Koha::Patron object to the templates In order to simplify and make uniform the code, the controller scripts send a Koha::Patron object to the templates instead of all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. The variable "patron" sent to the templates is supposed to represent the patron the librarian is editing the detail. In the members module and some scripts of the circulation module, the patron's detail are sent one by one to the template. That leads to frustration from developpers (making sure everything is passed from all scripts) and to regression (we got tone of bugs in the last year because of this way to do). With this patch set it will be easy access patron's detail, passing only 1 variable from the controllers. Test plan: Play with the patron and circulation module and make sur the detail of the patron you are editing/seeing info are correctly displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64212&action=edit Bug 18789: Pass a Koha::Patron object from returns.pl This is a specific patch for returns.pl Test plan: Do some checkin for a patron and make sure the info are correctly displayed (and info from someone that has placed a hold on this item) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64213&action=edit Bug 18789: Use Koha::Patron->image from the templates Now that we have the 'patron' variable in all our templates, we can call Koha::Patron->image and do the check from the templates. Test plan: On the different pages of the patron module, you should see the default image if there is no image attached or the one that has been attached (see pref patronimages) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64214&action=edit Bug 18789: add tests for is_adult and is_child This patch add 2 methods to the Koha::Patron module: is_adult and is_child. That way the business logic is at only one place and covered by tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64215&action=edit Bug 18789: Use Koha::Patron->is_child where needed Test plan: When you are on a page related to a child you should see the "Update child to adult patron" button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64216&action=edit Bug 18789: Use Koha::Patron->is_adult where needed Test plan: When editing adult's info you must see the "Add child" button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64218&action=edit Bug 18789: Remove useless IS_ADULT variable Test plan: git grep IS_ADULT must not return any results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64219&action=edit Bug 18789: Remove adultborrower from the pay* scripts This flag is not used in the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64221&action=edit Bug 18789: Update other occurences where is->child should be used Trivial changes here, just do a code review on the QA step -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64229&action=edit Bug 18789: (follow-up)Send Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Patch did not apply: $ git bz apply 18789 Bug 18789 - Send a Koha::Patron object to the templates 64211 - Bug 18789: Send Koha::Patron object to the templates 64212 - Bug 18789: Pass a Koha::Patron object from returns.pl 64213 - Bug 18789: Use Koha::Patron->image from the templates 64214 - Bug 18789: add tests for is_adult and is_child 64215 - Bug 18789: Use Koha::Patron->is_child where needed 64216 - Bug 18789: Use Koha::Patron->is_adult where needed 64218 - Bug 18789: Remove useless IS_ADULT variable 64219 - Bug 18789: Remove adultborrower from the pay* scripts 64221 - Bug 18789: Update other occurences where is->child should be used 64229 - Bug 18789: (follow-up)Send Koha::Patron object to the templates Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18789: Send Koha::Patron object to the templates fatal: sha1 information is lacking or useless (acqui/booksellers.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 18789: Send Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- You need to apply the dependencies first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64211|0 |1 is obsolete| | Attachment #64212|0 |1 is obsolete| | Attachment #64213|0 |1 is obsolete| | Attachment #64214|0 |1 is obsolete| | Attachment #64215|0 |1 is obsolete| | Attachment #64216|0 |1 is obsolete| | Attachment #64218|0 |1 is obsolete| | Attachment #64219|0 |1 is obsolete| | Attachment #64221|0 |1 is obsolete| | Attachment #64229|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71301&action=edit Bug 18789: Send Koha::Patron object to the templates In order to simplify and make uniform the code, the controller scripts send a Koha::Patron object to the templates instead of all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. The variable "patron" sent to the templates is supposed to represent the patron the librarian is editing the detail. In the members module and some scripts of the circulation module, the patron's detail are sent one by one to the template. That leads to frustration from developpers (making sure everything is passed from all scripts) and to regression (we got tone of bugs in the last year because of this way to do). With this patch set it will be easy access patron's detail, passing only 1 variable from the controllers. Test plan: Play with the patron and circulation module and make sur the detail of the patron you are editing/seeing info are correctly displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71302&action=edit Bug 18789: Pass a Koha::Patron object from returns.pl This is a specific patch for returns.pl Test plan: Do some checkin for a patron and make sure the info are correctly displayed (and info from someone that has placed a hold on this item) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71303&action=edit Bug 18789: Use Koha::Patron->image from the templates Now that we have the 'patron' variable in all our templates, we can call Koha::Patron->image and do the check from the templates. Test plan: On the different pages of the patron module, you should see the default image if there is no image attached or the one that has been attached (see pref patronimages) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71304&action=edit Bug 18789: add tests for is_adult and is_child This patch add 2 methods to the Koha::Patron module: is_adult and is_child. That way the business logic is at only one place and covered by tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71305&action=edit Bug 18789: Use Koha::Patron->is_child where needed Test plan: When you are on a page related to a child you should see the "Update child to adult patron" button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71306&action=edit Bug 18789: Use Koha::Patron->is_adult where needed Test plan: When editing adult's info you must see the "Add child" button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71307&action=edit Bug 18789: Remove useless IS_ADULT variable Test plan: git grep IS_ADULT must not return any results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71308&action=edit Bug 18789: Remove adultborrower from the pay* scripts This flag is not used in the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71309&action=edit Bug 18789: Update other occurences where is->child should be used Trivial changes here, just do a code review on the QA step -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71310&action=edit Bug 18789: (follow-up)Send Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff Keywords| |RM_priority --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is very hard to rebase and will introduce a lot of issues if not pushed quickly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71311&action=edit Bug 18789: (follow-up) Use Koha::Patron->image from the templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71301|0 |1 is obsolete| | Attachment #71302|0 |1 is obsolete| | Attachment #71303|0 |1 is obsolete| | Attachment #71304|0 |1 is obsolete| | Attachment #71305|0 |1 is obsolete| | Attachment #71306|0 |1 is obsolete| | Attachment #71307|0 |1 is obsolete| | Attachment #71308|0 |1 is obsolete| | Attachment #71309|0 |1 is obsolete| | Attachment #71310|0 |1 is obsolete| | Attachment #71311|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71485&action=edit Bug 18789: Send Koha::Patron object to the templates In order to simplify and make uniform the code, the controller scripts send a Koha::Patron object to the templates instead of all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. The variable "patron" sent to the templates is supposed to represent the patron the librarian is editing the detail. In the members module and some scripts of the circulation module, the patron's detail are sent one by one to the template. That leads to frustration from developpers (making sure everything is passed from all scripts) and to regression (we got tone of bugs in the last year because of this way to do). With this patch set it will be easy access patron's detail, passing only 1 variable from the controllers. Test plan: Play with the patron and circulation module and make sur the detail of the patron you are editing/seeing info are correctly displayed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71486&action=edit Bug 18789: Pass a Koha::Patron object from returns.pl This is a specific patch for returns.pl Test plan: Do some checkin for a patron and make sure the info are correctly displayed (and info from someone that has placed a hold on this item) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71487&action=edit Bug 18789: Use Koha::Patron->image from the templates Now that we have the 'patron' variable in all our templates, we can call Koha::Patron->image and do the check from the templates. Test plan: On the different pages of the patron module, you should see the default image if there is no image attached or the one that has been attached (see pref patronimages) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71488&action=edit Bug 18789: add tests for is_adult and is_child This patch add 2 methods to the Koha::Patron module: is_adult and is_child. That way the business logic is at only one place and covered by tests. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71489&action=edit Bug 18789: Use Koha::Patron->is_child where needed Test plan: When you are on a page related to a child you should see the "Update child to adult patron" button Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71490&action=edit Bug 18789: Use Koha::Patron->is_adult where needed Test plan: When editing adult's info you must see the "Add child" button Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71491&action=edit Bug 18789: Remove useless IS_ADULT variable Test plan: git grep IS_ADULT must not return any results Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71492&action=edit Bug 18789: Remove adultborrower from the pay* scripts This flag is not used in the templates Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71493&action=edit Bug 18789: Update other occurences where is->child should be used Trivial changes here, just do a code review on the QA step Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71494&action=edit Bug 18789: (follow-up)Send Koha::Patron object to the templates Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71495&action=edit Bug 18789: (follow-up) Use Koha::Patron->image from the templates Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71496&action=edit Bug 18789: Fix number of unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71485|0 |1 is obsolete| | Attachment #71486|0 |1 is obsolete| | Attachment #71487|0 |1 is obsolete| | Attachment #71488|0 |1 is obsolete| | Attachment #71489|0 |1 is obsolete| | Attachment #71490|0 |1 is obsolete| | Attachment #71491|0 |1 is obsolete| | Attachment #71492|0 |1 is obsolete| | Attachment #71493|0 |1 is obsolete| | Attachment #71494|0 |1 is obsolete| | Attachment #71495|0 |1 is obsolete| | Attachment #71496|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71679&action=edit Bug 18789: Send Koha::Patron object to the templates In order to simplify and make uniform the code, the controller scripts send a Koha::Patron object to the templates instead of all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. The variable "patron" sent to the templates is supposed to represent the patron the librarian is editing the detail. In the members module and some scripts of the circulation module, the patron's detail are sent one by one to the template. That leads to frustration from developpers (making sure everything is passed from all scripts) and to regression (we got tone of bugs in the last year because of this way to do). With this patch set it will be easy access patron's detail, passing only 1 variable from the controllers. Test plan: Play with the patron and circulation module and make sur the detail of the patron you are editing/seeing info are correctly displayed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71680&action=edit Bug 18789: Pass a Koha::Patron object from returns.pl This is a specific patch for returns.pl Test plan: Do some checkin for a patron and make sure the info are correctly displayed (and info from someone that has placed a hold on this item) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71681&action=edit Bug 18789: Use Koha::Patron->image from the templates Now that we have the 'patron' variable in all our templates, we can call Koha::Patron->image and do the check from the templates. Test plan: On the different pages of the patron module, you should see the default image if there is no image attached or the one that has been attached (see pref patronimages) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71682&action=edit Bug 18789: add tests for is_adult and is_child This patch add 2 methods to the Koha::Patron module: is_adult and is_child. That way the business logic is at only one place and covered by tests. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71683&action=edit Bug 18789: Use Koha::Patron->is_child where needed Test plan: When you are on a page related to a child you should see the "Update child to adult patron" button Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71684&action=edit Bug 18789: Use Koha::Patron->is_adult where needed Test plan: When editing adult's info you must see the "Add child" button Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71685&action=edit Bug 18789: Remove useless IS_ADULT variable Test plan: git grep IS_ADULT must not return any results Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71686&action=edit Bug 18789: Remove adultborrower from the pay* scripts This flag is not used in the templates Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71687&action=edit Bug 18789: Update other occurences where is->child should be used Trivial changes here, just do a code review on the QA step Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71688&action=edit Bug 18789: (follow-up)Send Koha::Patron object to the templates Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71689&action=edit Bug 18789: (follow-up) Use Koha::Patron->image from the templates Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71690&action=edit Bug 18789: add tests for is_adult and is_chil -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71691&action=edit Bug 18789: Use the patron variable in circulation.[pl|tt] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Bug 18789 depends on bug 18403, which changed state. Bug 18403 Summary: Hide patron information if not part of the logged in user library group https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 [Bug 12159] Duplicate borrower_add_additional_fields function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20223 [Bug 20223] Merge members-menu and circ-menu inc files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20226 [Bug 20226] Get rid of CATCODE_MULTI param decision in patron perl scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71679|0 |1 is obsolete| | Attachment #71680|0 |1 is obsolete| | Attachment #71681|0 |1 is obsolete| | Attachment #71682|0 |1 is obsolete| | Attachment #71683|0 |1 is obsolete| | Attachment #71684|0 |1 is obsolete| | Attachment #71685|0 |1 is obsolete| | Attachment #71686|0 |1 is obsolete| | Attachment #71687|0 |1 is obsolete| | Attachment #71688|0 |1 is obsolete| | Attachment #71689|0 |1 is obsolete| | Attachment #71690|0 |1 is obsolete| | Attachment #71691|0 |1 is obsolete| | --- Comment #50 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71713&action=edit Bug 18789: Send Koha::Patron object to the templates In order to simplify and make uniform the code, the controller scripts send a Koha::Patron object to the templates instead of all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. The variable "patron" sent to the templates is supposed to represent the patron the librarian is editing the detail. In the members module and some scripts of the circulation module, the patron's detail are sent one by one to the template. That leads to frustration from developpers (making sure everything is passed from all scripts) and to regression (we got tone of bugs in the last year because of this way to do). With this patch set it will be easy access patron's detail, passing only 1 variable from the controllers. Test plan: Play with the patron and circulation module and make sur the detail of the patron you are editing/seeing info are correctly displayed. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #51 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71714&action=edit Bug 18789: Pass a Koha::Patron object from returns.pl This is a specific patch for returns.pl Test plan: Do some checkin for a patron and make sure the info are correctly displayed (and info from someone that has placed a hold on this item) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #52 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71715&action=edit Bug 18789: Use Koha::Patron->image from the templates Now that we have the 'patron' variable in all our templates, we can call Koha::Patron->image and do the check from the templates. Test plan: On the different pages of the patron module, you should see the default image if there is no image attached or the one that has been attached (see pref patronimages) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #53 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71716&action=edit Bug 18789: Add tests for is_adult and is_child This patch add 2 methods to the Koha::Patron module: is_adult and is_child. That way the business logic is at only one place and covered by tests. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #54 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71717&action=edit Bug 18789: Use Koha::Patron->is_child where needed Test plan: When you are on a page related to a child you should see the "Update child to adult patron" button Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #55 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71718&action=edit Bug 18789: Use Koha::Patron->is_adult where needed Test plan: When editing adult's info you must see the "Add child" button Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #56 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71719&action=edit Bug 18789: Remove useless IS_ADULT variable Test plan: git grep IS_ADULT must not return any results Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #57 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71720&action=edit Bug 18789: Remove adultborrower from the pay* scripts This flag is not used in the templates Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #58 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71721&action=edit Bug 18789: Update other occurences where is_child should be used Trivial changes here, just do a code review on the QA step Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #59 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71722&action=edit Bug 18789: (follow-up) Send Koha::Patron object to the templates Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #60 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71723&action=edit Bug 18789: (follow-up) Use Koha::Patron->image from the templates Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #61 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71724&action=edit Bug 18789: Add tests for is_adult and is_child Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #62 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71725&action=edit Bug 18789: Use the patron variable in circulation.[pl|tt] Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #63 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71726&action=edit Bug 18789: (QA follow-up) Fix tab char Test plan: run koha qa tools, should be green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #64 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71727&action=edit Bug 18789: (QA follow-up) Fix borrowernumber in menu item links Test plan: Go to patrons routing list Try to click Holds history or ILL requests menu link --> without page blank page --> with page desired page Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #65 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71728&action=edit Bug 18789: (QA follow-up) Fix showing the name of basket creator on booksellers page Test plan: 1) Go to Acquisition and search for a vendor, you are presented with vendors and their baskets 2) Look to Created by column --> without patch only firstname is shown --> with patch you should see full name Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #66 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71729&action=edit Bug 18789: (QA follow-up) Use first_valid_email_address on Tranfers to receive page For consistancy with waitng reserves Test plan: 1) Have a hold for patron which need to be transfered, inititate transfer and go to target library 2) Go to Circulation -> transfers to receive page and you should see any first valid email for tha patron in column "On hold for" Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #67 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71730&action=edit Bug 18789: (QA follow-up) Fix loading saved address data to edit patron form Test plan: 1) Have patron with address filled in 2) Edit the patron -- without this patch the fields for address are blank -- with patch the fields are filled with actual data Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #68 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71731&action=edit Bug 18789: (QA follow-up) Fix showing patron name when checking in Test plan: 1) Have a patron with more then one checkouts 2) Check in one of the checkouts --> without patch patron name is not shown in checked-in items table --> with patch the patron is shown with name, category, number of checkouts and both links are working Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #69 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71732&action=edit Bug 18789: (QA follow-up) Fix showing cardnumber when creating a hold Test plan: 1) Try to create a hold request for a patron 2) On place hold form on the first line is shown the patron name --> without patch the cardnumber is not shown --> with patch there is cardnumber right after the patron name Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #70 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71733&action=edit Bug 18789: (QA follow-up) Use patron object in batch checkout template 1) Enable batch checkouts in system preferences and set it on for some patron categories 2) Try to batch checkout for some patron with one of these categories --> without patch the batch checkout page is even not shown --> with patch batch checking out is working as expected Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #71 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71734&action=edit Bug 18789: (QA follow-up) Use is_child in circulation.pl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #72 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71735&action=edit Bug 18789: (QA follow-up) Update holdshistory.pl, fix is_child, is_adult, patron->image, clear template params Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #73 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 71736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71736&action=edit Bug 18789: (QA follow-up) Fix viewlog when accessed via circulation Test plan: Go to any patron and then to Modification log of this patron -- without patch you will not see the left side menu and patron information -- with patch menu and patron information is here, and should be fully working (links) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #74 from Josef Moravec <josef.moravec@gmail.com> --- Good job Jonathan, I just added some small fixes. I think that memberentry.pl and memberentrygen.tt will need some refactoring too, but I am for to do it on another report, so passing qa. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71827&action=edit Bug 18789: Add POD for is_adult and is_child -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71838&action=edit Bug 18789: Fix perlcritic issue - housebound.pl "$branch" is declared but not used at line 65, column 1. Unused variables clutter code and make it harder to read. (Severity: 3) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71841&action=edit Bug 18789: (follow-up) Fix page title when creating a new patron This has been caught by selenium test, the category name must be displayed when we are creating a new patron, and so does not depends on the "patron" variable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20249 [Bug 20249] "Patron has no outstanding fines" now appears alongside fines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |nick@bywatersolutions.com --- Comment #79 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backported for 17.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73293&action=edit Bug 18789: (follow-up) Fix place hold page This patch fixes very weird behaviours introduced by commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates The patron variable was only set when no action was defined. This patch restores the feature the easiest way possible (less changes) even if it is not the best one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #81 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73890&action=edit Bug 18789: (follow-up) Pass a Koha::Patron object from returns.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #83 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #84 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75237&action=edit Bug 18789: Fix borrowernumber on members/files.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 --- Comment #85 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #84)
Created attachment 75237 [details] [review] Bug 18789: Fix borrowernumber on members/files.tt
Pushed to master! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20792 [Bug 20792] Can't go to patron record with TranslateNotices active -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20822 [Bug 20822] Can't find HOLD_SLIP template when printing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 [Bug 21008] pay.pl and paycollect.pl pass unused (and expensive) data to templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21463 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21463 [Bug 21463] Library is not longer displayed in the overdue list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21464 [Bug 21464] Overdues export is missing lot of fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21843 [Bug 21843] Adding a child patron no longer populates information on member entry form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21242 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21242 [Bug 21242] Modification log redirects you to circulation with no borrower if 'Object' field is not populated with borrowernumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21928 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21928 [Bug 21928] CircAutoPrintQuickSlip 'clear' is not working -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21649 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 [Bug 21649] Add child button in the staff client is no longer automatically populating the parent address -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the| |RMaint Note: Followup in release notes| |bug 21928 causes this bug | |to appear in release note.. | |remove before release! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203 [Bug 22203] Holds modal no longer links to patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|RMaint Note: Followup in |RMNOTE: Followup on bug release notes|bug 21928 causes this bug |21928 causes this bug to |to appear in release note.. |appear in release notes, |remove before release! |remove before release! CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|RMNOTE: Followup on bug |RMNOTE - Followup on bug release notes|21928 causes this bug to |21928 causes this bug to |appear in release notes, |appear in release notes, |remove before release! |remove before release! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25247 [Bug 25247] Exporting 'modification log' to a file should not send objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25452 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25452 [Bug 25452] Alternate email contact not displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 [Bug 27011] Warnings in returns.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org