[Bug 30859] New: Upgrade jQuery Validation plugin from v1.19.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 Bug ID: 30859 Summary: Upgrade jQuery Validation plugin from v1.19.1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Koha currently uses v1.19.1 of the jQuery Validation plugin which was released in 2019. We should upgrade to the latest version, which at the time I'm filing the bug is 1.19.4. Updates to the plugin have been made to improve compatibility with the latest version of jQuery. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 135420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135420&action=edit Bug 30859: Upgrade jQuery Validation plugin from v1.19.1 This patch updates the jQuery Validation plugin in both the OPAC and staff interface. This upgrade brings the plugin to the current latest version (1.19.4) which includes compatibility fixes for the latest version of jQuery. To test, apply the patch and test various forms in the OPAC and staff interface to confirm that validation is still working correctly. In the OPAC: - Patron self-registration: Required fields, password match and complexity. Test also the "Forgot password" and "Change password" interfaces. In the staff interface, for example: - Patrons -> Patron password change: Required fields, password match and complexity. - Administration -> Patron categories -> New category: - Required fields - One or the other enrollment period inputs - Digits required in password expiration, age required, upper age limit - Numbers required in enrollment and hold fee. - Administration -> Budgets -> New budget: - Required fields - End date must be after start date - Administration -> Cities & towns: Required fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135420|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 135443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135443&action=edit Bug 30859: Upgrade jQuery Validation plugin from v1.19.1 This patch updates the jQuery Validation plugin in both the OPAC and staff interface. This upgrade brings the plugin to the current latest version (1.19.4) which includes compatibility fixes for the latest version of jQuery. To test, apply the patch and test various forms in the OPAC and staff interface to confirm that validation is still working correctly. In the OPAC: - Patron self-registration: Required fields, password match and complexity. Test also the "Forgot password" and "Change password" interfaces. In the staff interface, for example: - Patrons -> Patron password change: Required fields, password match and complexity. - Administration -> Patron categories -> New category: - Required fields - One or the other enrollment period inputs - Digits required in password expiration, age required, upper age limit - Numbers required in enrollment and hold fee. - Administration -> Budgets -> New budget: - Required fields - End date must be after start date - Administration -> Cities & towns: Required fields Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, but noted these things - these are the same behaviour as in current master: - New patron category: password expiration field is not validated - can enter anything, if not valid is blank on edit (have logged as bug 30864). - Patron changing their password from their account (change your password): this form (as well as the forgotten password form) work "differently", with any error messages shown in a text block above the form instead of highlight errors in red. This is the current behaviour, and things validate as expected. Other testing notes (koha-testing-docker): to enable forgotten password recovery, the system preference is OpacResetPassword. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135443|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 136162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136162&action=edit Bug 30859: Upgrade jQuery Validation plugin from v1.19.1 This patch updates the jQuery Validation plugin in both the OPAC and staff interface. This upgrade brings the plugin to the current latest version (1.19.4) which includes compatibility fixes for the latest version of jQuery. To test, apply the patch and test various forms in the OPAC and staff interface to confirm that validation is still working correctly. In the OPAC: - Patron self-registration: Required fields, password match and complexity. Test also the "Forgot password" and "Change password" interfaces. In the staff interface, for example: - Patrons -> Patron password change: Required fields, password match and complexity. - Administration -> Patron categories -> New category: - Required fields - One or the other enrollment period inputs - Digits required in password expiration, age required, upper age limit - Numbers required in enrollment and hold fee. - Administration -> Budgets -> New budget: - Required fields - End date must be after start date - Administration -> Cities & towns: Required fields Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Needs documenting --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com Resolution|--- |FIXED Status|Needs documenting |CLOSED --- Comment #7 from Aude Charillon <aude.charillon@ptfs-europe.com> --- No update to Koha manual needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34623 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org