https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, Several things here: 1. I think my @sharedlists = Koha::Virtualshelves->search({ 'me.owner' => $self->borrowernumber, 'me.shelfnumber' => { -ident => 'virtualshelfshares.shelfnumber' } }, { prefetch => 'virtualshelfshares' }) Should be a new Koha::Virtualshelves method, like get_public_shelves and get_privates_shelves 2. The following FIXME should be kept # FIXME Could be $patron->get_lists 3. You should provide tests for this change. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.