[Bug 31115] New: Additional fields for invoices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Bug ID: 31115 Summary: Additional fields for invoices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: michaela.sieber@kit.edu QA Contact: testopia@bugs.koha-community.org This new feature adds the ability to define additional fields to store information about vendor invoices in the acquisition module. For further information see attached documentation. Test plan: 1. Create a Vendor (under Acquisition -> New Vendor). 2. Create a Basket 3. Apply patch. 4. Visit Additional fields under administration, and verify that the option for invoices exists 5. Create at least four fields for aqinvoice for each combination of searchable/not-searchable and with/without an authorized value. 6. Create a Vendor invoice (-> Receive shipment) , and verify that all fields are visible and correctly save. 7. Edit the invoice, verifying that changes to these additional fields are saved. 8. Search the invoice by using an additional field (Acquisitions > Invoices) 9. Verify that only the searchable fields show in the form, and that their contents may be searched. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 MichaelaSieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu --- Comment #1 from MichaelaSieber <michaela.sieber@kit.edu> --- Created attachment 137252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137252&action=edit Documentation Bug31115 Additional fields for invoices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 MichaelaSieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15774 Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 MichaelaSieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature adds the release notes| |ability to define | |additional fields to store | |information about vendor | |invoices. | |There is a new | |'Manage invoice fields' | |page in the acquisitions | |administration to configure | |the fields. | |Users can name | |additional fields, tie them | |to authorised values, and | |specify whether the fields | |can be searched in the | |acquisitions module. | |This | |also adds a new entry to | |the admin page for | |additional fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Change sponsored?|Seeking developer |Sponsored CC| |tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142210&action=edit Bug 31115: Add support for additional fields for invoices This patch adds support for additional fields for invoices. A new option is added to the 'Additional fields' admin page, for the 'aqinvoices' table. Adding/editing invoices now supports this additional fields. To test: 1. Apply this patches 2. Verify the original test plan works => SUCCESS: It does! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142211&action=edit Bug 31115: Add invoice fields manage link This patch adds a link on the acquisitions page for reaching the additional fields config for invoices in an easy way. Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142212&action=edit Bug 31115: Add additional_attributes support to GetInvoices This patch adds support for searching additional_fields when retrieving invoices using C4::Acquisition::Invoices. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Acquisition.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 142213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142213&action=edit Bug 31115: Add additional field filtering for invoice search This patch adds support for filtering invoice searches on additional fields. To test: 1. Generate additional fields for invoices 2. Have invoices with additional fields 3. Use invoice searching and play with filtering by additional fields. => SUCCESS: It works! 4. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lukas Koszyk <lukasz.koszyk@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lukas Koszyk <lukasz.koszyk@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142210|0 |1 is obsolete| | --- Comment #6 from Lukas Koszyk <lukasz.koszyk@kit.edu> --- Created attachment 142250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142250&action=edit Bug 31115: Add support for additional fields for invoices This patch adds support for additional fields for invoices. A new option is added to the 'Additional fields' admin page, for the 'aqinvoices' table. Adding/editing invoices now supports this additional fields. To test: 1. Apply this patches 2. Verify the original test plan works => SUCCESS: It does! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lukas Koszyk <lukasz.koszyk@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142211|0 |1 is obsolete| | --- Comment #7 from Lukas Koszyk <lukasz.koszyk@kit.edu> --- Created attachment 142251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142251&action=edit Bug 31115: Add invoice fields manage link This patch adds a link on the acquisitions page for reaching the additional fields config for invoices in an easy way. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lukas Koszyk <lukasz.koszyk@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142212|0 |1 is obsolete| | --- Comment #8 from Lukas Koszyk <lukasz.koszyk@kit.edu> --- Created attachment 142252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142252&action=edit Bug 31115: Add additional_attributes support to GetInvoices This patch adds support for searching additional_fields when retrieving invoices using C4::Acquisition::Invoices. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Acquisition.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lukas Koszyk <lukasz.koszyk@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142213|0 |1 is obsolete| | --- Comment #9 from Lukas Koszyk <lukasz.koszyk@kit.edu> --- Created attachment 142253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142253&action=edit Bug 31115: Add additional field filtering for invoice search This patch adds support for filtering invoice searches on additional fields. To test: 1. Generate additional fields for invoices 2. Have invoices with additional fields 3. Use invoice searching and play with filtering by additional fields. => SUCCESS: It works! 4. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31956 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31956 [Bug 31956] Clean up headings/legends on invoice summary view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142250|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142533&action=edit Bug 31115: Add support for additional fields for invoices This patch adds support for additional fields for invoices. A new option is added to the 'Additional fields' admin page, for the 'aqinvoices' table. Adding/editing invoices now supports this additional fields. To test: 1. Apply this patches 2. Verify the original test plan works => SUCCESS: It does! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142251|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142534&action=edit Bug 31115: Add invoice fields manage link This patch adds a link on the acquisitions page for reaching the additional fields config for invoices in an easy way. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142252|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142535&action=edit Bug 31115: Add additional_attributes support to GetInvoices This patch adds support for searching additional_fields when retrieving invoices using C4::Acquisition::Invoices. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Acquisition.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142253|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142536&action=edit Bug 31115: Add additional field filtering for invoice search This patch adds support for filtering invoice searches on additional fields. To test: 1. Generate additional fields for invoices 2. Have invoices with additional fields 3. Use invoice searching and play with filtering by additional fields. => SUCCESS: It works! 4. Sign off :-D Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142537&action=edit Bug 31115: (QA follow-up) Remove hr The hr created a visible white line with a darker background and doesn't make sense here style wise. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142538&action=edit Bug 31115: (QA follow-up) Use more specific permission for sidebar link Moves from any acq permission to edit_invoices. Manage order baskets uses order_manage, to this is supposed to make things a little more consistent. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Unit tests pass 2) QA tools pass 3) Permission check / links in navigation + [% IF CAN_user_acquisition && CAN_user_parameters_manage_additional_fields %] + <li> + <a href="/cgi-bin/koha/admin/additional-fields.pl?tablename=aqinvoices">Manage invoice fields</a> + </li> + [% END %] [% IF CAN_user_acquisition_order_manage && CAN_user_parameters_manage_additional_fields %] The new link for additional invoice fields will need "any acq permission" + the specific administration permission. The old link for additional basket fields uses the more specific permission "order_manage". I've provided a follow-up using edit_invoices for the first link to make things a bit more consistent. I could also imagine merging the links into "Manage additional fields" might be logical a next step, as we also have bug 11844 hopefully moving soon. 4) Tiny follow up for strange hr Feel free to omit or push at your preference :) I set the background to a darker color for better contrast and that made it show up as a strange white line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/628 CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org