[Bug 19777] New: Move template JavaScript to the footer: Serials, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Bug ID: 19777 Summary: Move template JavaScript to the footer: Serials, part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for even more of the serials templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69621&action=edit Bug 19777: Move template JavaScript to the footer: Serials, part 3 This patch modifies even more staff client serials templates so that JavaScript is included in the footer instead of the header. This patch adds a new JavaScript include, serials-toolbar.js, which is required on pages which include serials-toolbar.inc. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials - Search for a subscription - Tabs, datatables, date pickers - Open a subscription for viewing - Tabs, toolbar buttons for delete, renew, and close. - Serial collection (in the sidebar menu) - Select all / clear all - Datatable - Print slip - Generate next -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69621|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69682&action=edit Bug 19777: Move template JavaScript to the footer: Serials, part 3 This patch modifies even more staff client serials templates so that JavaScript is included in the footer instead of the header. This patch adds a new JavaScript include, serials-toolbar.js, which is required on pages which include serials-toolbar.inc. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials - Search for a subscription - Tabs, datatables, date pickers - Open a subscription for viewing - Tabs, toolbar buttons for delete, renew, and close. - Serial collection (in the sidebar menu) - Select all / clear all - Datatable - Print slip - Generate next Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69682|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69791&action=edit Bug 19777: Move template JavaScript to the footer: Serials, part 3 This patch modifies even more staff client serials templates so that JavaScript is included in the footer instead of the header. This patch adds a new JavaScript include, serials-toolbar.js, which is required on pages which include serials-toolbar.inc. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials - Search for a subscription - Tabs, datatables, date pickers - Open a subscription for viewing - Tabs, toolbar buttons for delete, renew, and close. - Serial collection (in the sidebar menu) - Select all / clear all - Datatable - Print slip - Generate next Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement, not backporting for 17.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 [Bug 20778] Unable to delete a subscription -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org