[Bug 10740] New: date created and modified indexes in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Bug ID: 10740 Summary: date created and modified indexes in ccl.properties Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org date created and modified indexes are defined in bib1.att as : 1011 date-entered-on-file 1012 Date/time-last-modified This should be used in ccl.properties. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 20393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20393&action=edit Bug 10740 - date created and modified indexes in ccl.properties See commit message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Is it really a good idea to put a slash in the index name? What we usually do is replace all punctuation with hyphens. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Jared Camins-Esakov from comment #2)
Is it really a good idea to put a slash in the index name? What we usually do is replace all punctuation with hyphens. The index is actually like this. But I agree to modify. I'd say : Datetime-last-modified What do you say ?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to Fridolyn SOMERS from comment #3)
(In reply to Jared Camins-Esakov from comment #2)
Is it really a good idea to put a slash in the index name? What we usually do is replace all punctuation with hyphens. The index is actually like this. But I agree to modify. I'd say : Datetime-last-modified What do you say ?
I think that's the best idea. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hello Fridolyn I wanted to reword this index in bug 8252 (needs signoff), but changed my mind after Paul's comment. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to mathieu saby from comment #5)
Hello Fridolyn I wanted to reword this index in bug 8252 (needs signoff), but changed my mind after Paul's comment.
Mathieu
Oh, yes. @Jared : What do you think about bug 8252 ? I'd say it is dangerous to use a "/" in indexes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I thought it was dangerous too ;-) But bug 8252 is already quite complex to test, so I won't replace the / in it... Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #8 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Bug 8252 has been signed off by Bernardo Gonzales Kriegel and Frédéric Demians. I'm waiting for its QA. When it is pushed we could do other improvements/corrections, like the one proposed by Fridolyn. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 David Noe <drnoe@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |drnoe@bywatersolutions.com --- Comment #10 from David Noe <drnoe@bywatersolutions.com> --- This patch does not apply. The change appear to have been made already. Both these line are in ccl.properties: att 1011 date-entered-on-file att 1012 Date/time-last-modified -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20393|0 |1 is obsolete| | --- Comment #11 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 22262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22262&action=edit Bug 10740 - date created and modified indexes in ccl.properties Patch rebased (Conflict with Bug 8252) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8252 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #12 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Fridolyn SOMERS from comment #11)
Created attachment 22262 [details] [review] Bug 10740 - date created and modified indexes in ccl.properties
Patch rebased (Conflict with Bug 8252)
Hi Fridolyn As 8252 is pushed to master, can we say that it "block" 10740 ? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #13 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I will test your patch in a DOM UNIMARC this evening. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #14 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Out of the scope of your bug : Each time we add an new index in the list of indexes in Search.pm, my blood is freezing :( I know it's needed now, but would not it be more flexible (if a library wants to add custom index) with a list stored out of Perl code, in some YAML file for ex? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to mathieu saby from comment #14)
Out of the scope of your bug : Each time we add an new index in the list of indexes in Search.pm, my blood is freezing :( I know it's needed now, but would not it be more flexible (if a library wants to add custom index) with a list stored out of Perl code, in some YAML file for ex?
This is how QueryParser works. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #16 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Jared Camins-Esakov from comment #15)
(In reply to mathieu saby from comment #14)
Out of the scope of your bug : Each time we add an new index in the list of indexes in Search.pm, my blood is freezing :( I know it's needed now, but would not it be more flexible (if a library wants to add custom index) with a list stored out of Perl code, in some YAML file for ex?
This is how QueryParser works. :)
Great! So when we decide that pre-QP search could be deprecated, this piece of code could be delete I imagine? But, is there a similar operation to do in QP conf to declare the new index, or is it automatic? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to mathieu saby from comment #16)
Great! So when we decide that pre-QP search could be deprecated, this piece of code could be delete I imagine?
Yup. We talked about that at the hackfest on Sunday.
But, is there a similar operation to do in QP conf to declare the new index, or is it automatic?
There is a similar configuration required: you have to add your new index to etc/searchengine/queryparser.yaml. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #18 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Jared Camins-Esakov from comment #17)
(In reply to mathieu saby from comment #16)
Great! So when we decide that pre-QP search could be deprecated, this piece of code could be delete I imagine?
Yup. We talked about that at the hackfest on Sunday.
But, is there a similar operation to do in QP conf to declare the new index, or is it automatic?
There is a similar configuration required: you have to add your new index to etc/searchengine/queryparser.yaml.
I did not know that... Is there a page on the wiki or elsewere explaining that, or other points about QP? I found http://wiki.koha-community.org/wiki/C_%26_P_Search_Rewrite_RFC but it is a RFC, not a page on "What you absolutely need to know about QP now that it is used by Koha". For example, with QP, is it possible to search for an exact expression using Google syntax (double quotes), like "bla bla" ? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #19 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Jared, I suppose I need to add a followup to this bug I wrote some time ago and which does not take into account the QP : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 and added some fields to Search.pm. I don't know at all how to do this, and in which cases (when Search.pm is altered? when bib1.att is altered? when ccl.properties is altered?). Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #20 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to mathieu saby from comment #19)
I don't know at all how to do this I will provide a QP follow-up for this bug 10740, to add "date-time-last-modified". I noticed that in QP all indexes are lowercase. So in the end I wonder why not use everywhere : "date-time-last-modified" and not "Date/time-last-modified".
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22262|0 |1 is obsolete| | --- Comment #21 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 22391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22391&action=edit Bug 10740 - date created and modified indexes in ccl.properties and QP Revised patch. Date/time-last-modified converted in date-time-last-modified for QP. I think using / in an index would have provoke bugs is future. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #22 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Fridolyn SOMERS from comment #20)
(In reply to mathieu saby from comment #19)
I don't know at all how to do this I will provide a QP follow-up for this bug 10740, to add "date-time-last-modified". I noticed that in QP all indexes are lowercase. So in the end I wonder why not use everywhere : "date-time-last-modified" and not "Date/time-last-modified".
In ccl.properties, there are a lot of aliases differing from the main index only in terms of capitalisation (Notes notes etc). I always wondered if it was necessary or not... Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #23 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- This patch does not deal with DOM indexing. In the biblio-koha-indexdefs.xml/biblio-zebra-indexdefs.xsl files that govern dom indexing (compare them with record.abs for grs1), I see Date/time-last-modified. I think it would be consistent to use the same fieldname here too. Failed QA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org