[Bug 42230] New: DataTables search ( dt-search ) on opac-user.tt contains empty label elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 Bug ID: 42230 Summary: DataTables search ( dt-search ) on opac-user.tt contains empty label elements Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org To recreate: 1. Have a user with checkouts. holds, article requests. 2. Log into the OPAC and go to "Summary" 3. Notice the dataTables search ( dt-search ) contains an empty label: <label for="dt-search-0"></label> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 196685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196685&action=edit Bug 42230: Add accessible label to OPAC summary DataTables search input The DataTables search input on the OPAC summary page is rendered with an empty label due to the use of "_INPUT_" in the DataTables language.search option. This results in markup like: <label for="dt-search-0"></label> which is flagged by accessibility tools as a missing form label. Update the DataTables configuration to include descriptive label text so the search input has an accessible name. Test plan: 1. Have a user with checkouts, holds, or article requests 2. Log into the OPAC and go to "Summary" 3. Inspect the DataTables search input 4. Notice the label is empty: <label for="dt-search-0"></label> 5. Apply the patch 6. Repeat steps 1-2 above 7. Inspect the DataTables search input 8. Confirm the label now contains descriptive text (e.g., "Search:") 9. Run an accessibility checker and confirm the empty label error is resolved 10. Sign off and have a wonderful day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196685|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 197119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197119&action=edit Bug 42230: Add accessible label to OPAC summary DataTables search input The DataTables search input on the OPAC summary page is rendered with an empty label due to the use of "_INPUT_" in the DataTables language.search option. This results in markup like: <label for="dt-search-0"></label> which is flagged by accessibility tools as a missing form label. Update the DataTables configuration to include descriptive label text so the search input has an accessible name. Test plan: 1. Have a user with checkouts, holds, or article requests 2. Log into the OPAC and go to "Summary" 3. Inspect the DataTables search input 4. Notice the label is empty: <label for="dt-search-0"></label> 5. Apply the patch 6. Repeat steps 1-2 above 7. Inspect the DataTables search input 8. Confirm the label now contains descriptive text (e.g., "Search:") 9. Run an accessibility checker and confirm the empty label error is resolved 10. Sign off and have a wonderful day! :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Before the patch, inspecting the HTML source: ... <div class="dt-search"> <input type="search" class="dt-input" id="dt-search-0" placeholder="Search" aria-controls="checkoutst"> <label for="dt-search-0"></label> </div> ... 2. After the patch: ... <div class="dt-search"> updated - now has text --> <label for="dt-search-0">Search:</label> <input type="search" class="dt-input" id="dt-search-0" placeholder="Search" aria-controls="checkoutst"> </div> 3. Note: axe DevTools and Lighthouse did not flag an issue for this (but there are other issues). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DataTables search ( |DataTables search |dt-search ) on opac-user.tt |(dt-search) on a patron's |contains empty label |account summary page |elements |(opac-user.tt) contains | |empty label elements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DataTables search |DataTables search |(dt-search) on a patron's |(dt-search) on a patron's |account summary page |OPAC account summary page |(opac-user.tt) contains |(opac-user.tt) contains |empty label elements |empty label elements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197119|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200199&action=edit Bug 42230: Add accessible label to OPAC summary DataTables search input The DataTables search input on the OPAC summary page is rendered with an empty label due to the use of "_INPUT_" in the DataTables language.search option. This results in markup like: <label for="dt-search-0"></label> which is flagged by accessibility tools as a missing form label. Update the DataTables configuration to include descriptive label text so the search input has an accessible name. Test plan: 1. Have a user with checkouts, holds, or article requests 2. Log into the OPAC and go to "Summary" 3. Inspect the DataTables search input 4. Notice the label is empty: <label for="dt-search-0"></label> 5. Apply the patch 6. Repeat steps 1-2 above 7. Inspect the DataTables search input 8. Confirm the label now contains descriptive text (e.g., "Search:") 9. Run an accessibility checker and confirm the empty label error is resolved 10. Sign off and have a wonderful day! :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 200452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200452&action=edit Bug 42230: (RM follow-up): Remove entry, it already defaults to __(Search:) in datatables.js Patch from commit a4a9e0a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42230 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi guys I think we can just remove it, Failing QA to ask for a signoff on the follow-up before push. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org