https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27526 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122860&action=edit Bug 28689: Extra %s in alert message when saving an items This patch removes an unnecessary %s in the text built to show when there are errors in the cataloging add item form. To reproduce, open the add item form in cataloging and click "Add item" without filling in all mandatory fields. You should see an alert message that contains, "- %s 1 mandatory fields empty (highlighted)" To test, apply the patch and return to the add item form. Now when you save an incomplete form the message should omit the %s: - 1 mandatory fields empty (highlighted) https://bugs.koha-community.org/show_bug.cgi?id=28690 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122860|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 123289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123289&action=edit Bug 28689: Extra %s in alert message when saving an items This patch removes an unnecessary %s in the text built to show when there are errors in the cataloging add item form. To reproduce, open the add item form in cataloging and click "Add item" without filling in all mandatory fields. You should see an alert message that contains, "- %s 1 mandatory fields empty (highlighted)" To test, apply the patch and return to the add item form. Now when you save an incomplete form the message should omit the %s: - 1 mandatory fields empty (highlighted) https://bugs.koha-community.org/show_bug.cgi?id=28690 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes: - To make a field in the add item form mandatory: edit the 952 tag and make a subfield mandatory for the bibliographic framework (Administration > Catalog > MARC bibliographic framework) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123289|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123294&action=edit Bug 28689: Extra %s in alert message when saving an items This patch removes an unnecessary %s in the text built to show when there are errors in the cataloging add item form. To reproduce, open the add item form in cataloging and click "Add item" without filling in all mandatory fields. You should see an alert message that contains, "- %s 1 mandatory fields empty (highlighted)" To test, apply the patch and return to the add item form. Now when you save an incomplete form the message should omit the %s: - 1 mandatory fields empty (highlighted) https://bugs.koha-community.org/show_bug.cgi?id=28690 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Extra %s in alert message |Extra %s in alert message |when saving an items |when saving an item -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28689 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes.