[Bug 37263] New: Creating default article request fees for all patron categories breaks Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Bug ID: 37263 Summary: Creating default article request fees for all patron categories breaks Koha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org To reproduce: 1. Enable ArticleRequests sys pref 2. Visit <staff_url>/cgi-bin/koha/admin/smart-rules.pl 3. Under 'Default article request fees' on 'Patron category' select 'All' and input a numeric Free 4. Click 'Add'. Notice it blows up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168553&action=edit Bug 37263: Fix handling of 'All' values on 'default article request fees' To test: 1. Enable ArticleRequests sys pref 2. Visit <staff_url>/cgi-bin/koha/admin/smart-rules.pl 3. Under 'Default article request fees' on 'Patron category' select 'All' and input a numeric Free 4. Click 'Add'. Notice it blows up. 5. Apply patch. Repeat. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal CC| |chris@bigballofwax.co.nz, | |emmi.takkinen@koha-suomi.fi Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- I found a few problems during testing in KTD, but not sure if they should be new bugs or fixed in this one. Before applying a patch problem is also with adding fee for any single patron category - Koha blows up. But after applying a patch there is another problem - if there is rule for 'All' one can not add rule for specific patron category. If there is no rule for 'All' new rule is added not for selected category but for 'All'. Trying to add new rule (for specific category) with fee value different from fee for 'All' doesn't work, but updates fee value for 'All'. Delete button does not work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Roman Dolny from comment #2)
I found a few problems during testing in KTD, but not sure if they should be new bugs or fixed in this one.
Before applying a patch problem is also with adding fee for any single patron category - Koha blows up.
But after applying a patch there is another problem - if there is rule for 'All' one can not add rule for specific patron category. If there is no rule for 'All' new rule is added not for selected category but for 'All'.
Trying to add new rule (for specific category) with fee value different from fee for 'All' doesn't work, but updates fee value for 'All'.
Delete button does not work.
Can confirm, "Default article request fees" is always saved to database with categorycode as NULL no matter which patron category is used. That's why when you try to save new rule with different patron category, it doesn't appear to the rule list. So now in master any saved rule leads to Koha blowing up. Can also confirm deleting rule with patron category as "All" doesn't work. I changed categorytype in database manually as existing patron category type and after that I was able to delete the rule. My guess is that since "All" value is sent to deleted script as empty value ("") it can't be found from database and thus deleting it fails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168591&action=edit Bug 37263: Fix URL param retrieval This was introduced by bug 34478. To test: Follow the test plan as before, but test for several different patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Creating default article |Creating default article |request fees for all patron |request fees is not working |categories breaks Koha | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi both, thank you for testing. I believe the 2nd patch should fix the follow-up issues, if you can please test again. Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #6 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Pedro Amorim from comment #5)
Hi both, thank you for testing. I believe the 2nd patch should fix the follow-up issues, if you can please test again. Thank you.
Tested and works as described. However deleting rule is still not working at least for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Emmi Takkinen from comment #6)
(In reply to Pedro Amorim from comment #5)
Hi both, thank you for testing. I believe the 2nd patch should fix the follow-up issues, if you can please test again. Thank you.
Tested and works as described. However deleting rule is still not working at least for me.
Right, it seems to work if a category is defined, but not for 'All'. I'll revisit this when I next find the chance. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168593&action=edit Bug 37263: Fix deletion of 'All' patron category in Default article request fees Follow same test plan as before, but attempt to delete a 'All' entry in 'Default article request fees'. Notice it blows up before this patch. It works as expected after the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #9 from Roman Dolny <roman.dolny@jezuici.pl> --- (In reply to Pedro Amorim from comment #8)
Created attachment 168593 [details] [review] Bug 37263: Fix deletion of 'All' patron category in Default article request fees
Follow same test plan as before, but attempt to delete a 'All' entry in 'Default article request fees'. Notice it blows up before this patch. It works as expected after the patch.
Thank you for patches, it works as described - doesn't blow up after applying a patch, adding/deleting rule for category or for 'All' works. Notice one more thing - "Delete" button works when there is "Standard rules for all libraries" selected, but doesn't work when specific library is selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |januszop@gmail.com --- Comment #10 from Janusz Kaczmarek <januszop@gmail.com> --- There is still a problem in the smart-rules.tt file, causing the settings for all libraries to be removed instead of the selected one. (You are trying to remove settings for e.g. Midway, but in fact they remain untouched and the defaults are removed). What should be corrected is--in 8 spots in smart-rules.tt: - ... data-branch"[% current_branch | html %]"> ... + ... data-branch="[% current_branch | html %]"> ... I'm not filling a new bug. Pedro, could you please include this in yours? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Janusz Kaczmarek from comment #10)
There is still a problem in the smart-rules.tt file, causing the settings for all libraries to be removed instead of the selected one. (You are trying to remove settings for e.g. Midway, but in fact they remain untouched and the defaults are removed).
What should be corrected is--in 8 spots in smart-rules.tt:
- ... data-branch"[% current_branch | html %]"> ... + ... data-branch="[% current_branch | html %]"> ...
I'm not filling a new bug. Pedro, could you please include this in yours?
I've opened bug 37290 for this as the scope is clearly wider there. (This current bug 37263 is about article requests specifically) Janusz I've submitted the patch in your name and signed-off. I'll rebase these patches here on top of bug 37290 to avoid unecessary conflicts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37290 [Bug 37290] Deleting circulation rule for a specific library deletes for All libraries instead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168553|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168650&action=edit Bug 37263: Fix handling of 'All' values on 'default article request fees' To test: 1. Enable ArticleRequests sys pref 2. Visit <staff_url>/cgi-bin/koha/admin/smart-rules.pl 3. Under 'Default article request fees' on 'Patron category' select 'All' and input a numeric Free 4. Click 'Add'. Notice it blows up. 5. Apply patch. Repeat. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168591|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168651&action=edit Bug 37263: Fix URL param retrieval This was introduced by bug 34478. To test: Follow the test plan as before, but test for several different patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168593|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168652&action=edit Bug 37263: Fix deletion of 'All' patron category in Default article request fees Follow same test plan as before, but attempt to delete a 'All' entry in 'Default article request fees'. Notice it blows up before this patch. It works as expected after the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Roman Dolny from comment #9)
Notice one more thing - "Delete" button works when there is "Standard rules for all libraries" selected, but doesn't work when specific library is selected.
This should be fixed by bug 37290, please check there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168650|0 |1 is obsolete| | Attachment #168651|0 |1 is obsolete| | Attachment #168652|0 |1 is obsolete| | --- Comment #16 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 168675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168675&action=edit Bug 37263: Fix handling of 'All' values on 'default article request fees' To test: 1. Enable ArticleRequests sys pref 2. Visit <staff_url>/cgi-bin/koha/admin/smart-rules.pl 3. Under 'Default article request fees' on 'Patron category' select 'All' and input a numeric Free 4. Click 'Add'. Notice it blows up. 5. Apply patch. Repeat. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #17 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 168676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168676&action=edit Bug 37263: Fix URL param retrieval This was introduced by bug 34478. To test: Follow the test plan as before, but test for several different patron categories Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #18 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 168677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168677&action=edit Bug 37263: Fix deletion of 'All' patron category in Default article request fees Follow same test plan as before, but attempt to delete a 'All' entry in 'Default article request fees'. Notice it blows up before this patch. It works as expected after the patch. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #19 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Pedro Amorim from comment #11)
I've opened bug 37290 for this as the scope is clearly wider there. (This current bug 37263 is about article requests specifically) Janusz I've submitted the patch in your name and signed-off.
Indeed, my discovery turned out to be wider than just article request fee deletion problem. Thank you, Pedro, for your extra work! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168675|0 |1 is obsolete| | --- Comment #20 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 168690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168690&action=edit Bug 37263: Fix handling of 'All' values on 'default article request fees' To test: 1. Enable ArticleRequests sys pref 2. Visit <staff_url>/cgi-bin/koha/admin/smart-rules.pl 3. Under 'Default article request fees' on 'Patron category' select 'All' and input a numeric Free 4. Click 'Add'. Notice it blows up. 5. Apply patch. Repeat. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168676|0 |1 is obsolete| | --- Comment #21 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 168691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168691&action=edit Bug 37263: Fix URL param retrieval This was introduced by bug 34478. To test: Follow the test plan as before, but test for several different patron categories Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168677|0 |1 is obsolete| | --- Comment #22 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 168692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168692&action=edit Bug 37263: Fix deletion of 'All' patron category in Default article request fees Follow same test plan as before, but attempt to delete a 'All' entry in 'Default article request fees'. Notice it blows up before this patch. It works as expected after the patch. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36672 Keywords| |rel_24_05_candidate Severity|normal |critical CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #23 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Increasing the severity on this one and flagging it for backport, since it crashes the page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672 [Bug 36672] Circulation rules are performing too many lookups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36192 CC| |david@davidnind.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168690|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 169983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169983&action=edit Bug 37263: Fix handling of 'All' values on 'default article request fees' To test: 1. Enable ArticleRequests sys pref 2. Visit <staff_url>/cgi-bin/koha/admin/smart-rules.pl 3. Under 'Default article request fees' on 'Patron category' select 'All' and input a numeric Free 4. Click 'Add'. Notice it blows up. 5. Apply patch. Repeat. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168691|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 169984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169984&action=edit Bug 37263: Fix URL param retrieval This was introduced by bug 34478. To test: Follow the test plan as before, but test for several different patron categories Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168692|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 169985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169985&action=edit Bug 37263: Fix deletion of 'All' patron category in Default article request fees Follow same test plan as before, but attempt to delete a 'All' entry in 'Default article request fees'. Notice it blows up before this patch. It works as expected after the patch. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Switching to major. Critical seems to be overkill ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #30 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Marcel de Rooy from comment #28)
Switching to major. Critical seems to be overkill ?
Sorry if I caused undue alarm! I went for critical based on the phrasing "Koha or component crashes" on the wiki, but of course there's always nuance to these things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37531 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #31 from Lucas Gass <lucas@bywatersolutions.com> --- doesnt apply clean to 24.05.x, please rebase if you think this is needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 --- Comment #32 from Lucas Gass <lucas@bywatersolutions.com> --- Maybe the last patch is not needed in 24.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Keywords|rel_24_05_candidate | Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Bug 37263 depends on bug 36672, which changed state. Bug 36672 Summary: Circulation rules are performing too many lookups https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Needs documenting --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes adding and release notes| |deleting values for | |'Default article request | |fees', so this works as | |expected (Administration > | |Circulation and fine rules | |> Default article request | |fees (when ArticleRequests | |enabled)). (This is related | |to the CSRF changes added | |in Koha 24.05 to improve | |form security.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #35 from David Nind <david@davidnind.com> --- This is a bug fix and there is no change to the user interface - no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Bug 37263 depends on bug 36192, which changed state. Bug 36192 Summary: [OMNIBUS] CSRF Protection for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37263 Bug 37263 depends on bug 37290, which changed state. Bug 37290 Summary: Deleting circulation rule for a specific library deletes for All libraries instead https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37290 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org