[Bug 42540] New: Trap and throw elastic too_many_clauses errors instead of just dying
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42540 Bug ID: 42540 Summary: Trap and throw elastic too_many_clauses errors instead of just dying Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org This started out as an issue with Connexion gateway, but it's not actually directly related. The issue is that during import, a record may contain so many fields to match on that it exceeds the max clauses an es server is configured for. In this case Koha 500's and connex emits the generic "Unsuccessful request" error. It seems the best patch forward would be to trap this error and propagate it as a Koha Exception, rather than simply die. There may be other elastic errors we could add to this pattern but I've not encountered any others so far. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42540 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42540 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42540 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 198687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198687&action=edit Bug 42540: Trap and throw elastic too_many_clauses errors instead of just dying This started out as an issue with Connexion gateway, but it's not actually directly related. The issue is that during import, a record may contain so many fields to match on that it exceeds the max clauses an es server is configured for. In this case Koha 500's and connex emits the generic "Unsuccessful request" error. It seems the best patch forward would be to trap this error and propagate it as a Koha Exception, rather than simply die. There may be other elastic errors we could add to this pattern but I've not encountered any others so far. Test Plan: 1) Ensure your Koha instance is configured to use Elastic, and the maxClauseCount is set to 1024 or less 2) Apply this patch 3) Prove t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42540 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- No idea how to do step 1 using KTD. Some hints on how to do that using KTD would be helpful 8-). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42540 --- Comment #3 from David Nind <david@davidnind.com> --- Also, is Bug 42174 a duplicate, or just related to this issue? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org