[Bug 17821] New: due date in intranet search results should use TT date plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Bug ID: 17821 Summary: due date in intranet search results should use TT date plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Intranet search results displays due date from item onloan. This should use the TT date plugin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 [Bug 7444] Use T::T date plugin to display dates omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7444 Depends on|7444 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 [Bug 7444] Use T::T date plugin to display dates omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 58472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58472&action=edit Bug 17821 - due date in intranet search results should use TT date plugin Intranet search results displays due date from item onloan. This should use the TT date plugin. Test plan : - set syspref dateformat not on yyyy-mm-dd, for example dd/mm/yyyy - checkout an item - at intranet, perform a search where you see the item => You must see : "date due : dd/mm/yyyy" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58472|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 58567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58567&action=edit [SIGNED-OFF] Bug 17821 - due date in intranet search results should use TT date plugin Intranet search results displays due date from item onloan. This should use the TT date plugin. Test plan : - set syspref dateformat not on yyyy-mm-dd, for example dd/mm/yyyy - checkout an item - at intranet, perform a search where you see the item => You must see : "date due : dd/mm/yyyy" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Fridolin, how this is useful? I understand the consistency point of view, but I do not think it is really valuable. Did you check the other calls to this subroutine to make sure that will not affect another script? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 [Bug 15822] STAFF Advanced search error date utils -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
Fridolin, how this is useful? I understand the consistency point of view, but I do not think it is really valuable.
The TT date plugin may one day behave differently from the old code in C4::Search. Also we had some cases where date_due is not correct, the TT plugin handles this.
Did you check the other calls to this subroutine to make sure that will not affect another script? Yep, its not easy since date_due is used a lot. But only intranet results uses it.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Still do not think it's needed. Putting it back to the SO queue to get point of view from other QAers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Some of our instances have sometimes an invalid date in items.onload (like 000-00-00). We don't know why but without this patch the page failes on error : "Can't locate object method \"ymd\" via package \"dateonly\" (perh"...) called at /home/koha/src/Koha/DateUtils.pm line 223 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #6)
Some of our instances have sometimes an invalid date in items.onload (like 000-00-00). We don't know why but without this patch the page failes on error : "Can't locate object method \"ymd\" via package \"dateonly\" (perh"...) called at /home/koha/src/Koha/DateUtils.pm line 223
Ok but you are not fixing anything with this patch, just hide other problems: course_reserves/course-details.tt: [% IF cr.item.onloan %] reserve/request.tt: [% IF ( itemloo.onloan ) %] catalogue/detail.tt: [% UNLESS ( item.itemnotforloan || item.notforloan_per_itemtype || item.onloan || item.itemlost || item.withdrawn || item.damaged || item.transfertwhen || item.reservedate ) %] In all of these tests, onloan will be true when you are expecting it to be false. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58567|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62167&action=edit Bug 17821 - due date in intranet search results should use TT date plugin Intranet search results displays due date from item onloan. This should use the TT date plugin. Test plan : - set syspref dateformat not on yyyy-mm-dd, for example dd/mm/yyyy - checkout an item - at intranet, perform a search where you see the item => You must see : "date due : dd/mm/yyyy" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org