[Bug 33949] New: Replace GetAllIssues with Koha::Checkouts - opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Bug ID: 33949 Summary: Replace GetAllIssues with Koha::Checkouts - opac Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 33947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33947 [Bug 33947] Move GetAllIssues to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33946 [Bug 33946] biblio-title.inc should not add a link if biblio does not exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33951, 33952, 33953, 33954, | |33955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33951 [Bug 33951] normalized_oclc not defined in opac-readingrecord.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33952 [Bug 33952] Add Koha::Biblio->normalized_isbn https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33953 [Bug 33953] Add Koha::Biblio->ratings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33954 [Bug 33954] Add Koha::Biblio->opac_summary_html https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33955 [Bug 33955] Add Koha::Biblio->normalized_upc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152155&action=edit Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac Same as bug 33948 for the OPAC side. Additionally you will test * OPACMySummaryHTML * The different cover images services * Display of ISBN * Display of UPC * Ratings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33958 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33958 [Bug 33958] Add Koha::Biblio->normalized_oclc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152155|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152177&action=edit Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac Same as bug 33948 for the OPAC side. Additionally you will test * OPACMySummaryHTML * The different cover images services * Display of ISBN * Display of UPC * Ratings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Bug 33949 depends on bug 33952, which changed state. Bug 33952 Summary: Add Koha::Biblio->normalized_isbn https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Bug 33949 depends on bug 33953, which changed state. Bug 33953 Summary: Add Koha::Biblio->ratings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33953 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Bug 33949 depends on bug 33954, which changed state. Bug 33954 Summary: Add Koha::Biblio->opac_summary_html https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33954 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152177|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155781&action=edit Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac Same as bug 33948 for the OPAC side. Additionally you will test * OPACMySummaryHTML * The different cover images services * Display of ISBN * Display of UPC * Ratings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155782&action=edit Bug 33949: Fix display of old checkouts if no checkouts exist If we pass an empty array from the perl controller, we retrieve an empty string from the template, and the merge does not work. This patch fixes the following bug: Pick a patron without checkout history Check them an item out and check it in => The table is empty, whereas it should display the item that has been checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155781|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 156440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156440&action=edit Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac Same as bug 33948 for the OPAC side. Additionally you will test * OPACMySummaryHTML * The different cover images services * Display of ISBN * Display of UPC * Ratings Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155782|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 156441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156441&action=edit Bug 33949: Fix display of old checkouts if no checkouts exist If we pass an empty array from the perl controller, we retrieve an empty string from the template, and the merge does not work. This patch fixes the following bug: Pick a patron without checkout history Check them an item out and check it in => The table is empty, whereas it should display the item that has been checked in. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- I've signed off, but I had a couple of questions: 1. I'm not sure where I should be checking for the display of the ISBN and UPC numbers. (I added a UPC code for a record (024$a with 1 and 0 in the indicators)). 2. Old checkouts - I was sure how to replicate this issue. After applying the patch, checking out and checking in an item, things displayed as expected. This worked the same before the patches were applied. Testing notes (using KTD): 1. I added several checkouts for a patron and checked some items in. 2. I added some ratings in the OPAC for items displayed in the history. 3. Enabled a couple of the cover image services - Amazon, OpenLibrary, and local cover images. 4. After apply the patches, I noticed no differences in the display in the OPAC for the patron's Checkout history (including 'Show all items') and their Summary. 5. I noticed that local cover images are not displayed in the checkout history and summary pages - bug 32514 has already been created for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Nind from comment #7)
I've signed off, but I had a couple of questions:
Thanks!
1. I'm not sure where I should be checking for the display of the ISBN and UPC numbers. (I added a UPC code for a record (024$a with 1 and 0 in the indicators)).
Sorry, wrong test plan. The UPC is used by BakerTaylor, and the ISBN for the cover images. They are not directly displayed on the UI.
2. Old checkouts - I was sure how to replicate this issue. After applying the patch, checking out and checking in an item, things displayed as expected. This worked the same before the patches were applied.
Yes, the second patch is a follow-up for the first patch. It's no fixing a bug that is in master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 --- Comment #9 from David Nind <david@davidnind.com> --- Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156440|0 |1 is obsolete| | Attachment #156441|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156957&action=edit Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac Same as bug 33948 for the OPAC side. Additionally you will test * OPACMySummaryHTML * The different cover images services * Display of ISBN * Display of UPC * Ratings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 156958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156958&action=edit Bug 33949: Fix display of old checkouts if no checkouts exist If we pass an empty array from the perl controller, we retrieve an empty string from the template, and the merge does not work. This patch fixes the following bug: Pick a patron without checkout history Check them an item out and check it in => The table is empty, whereas it should display the item that has been checked in. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Bug 33949 depends on bug 33958, which changed state. Bug 33958 Summary: Add Koha::Biblio->normalized_oclc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33958 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Bug 33949 depends on bug 33955, which changed state. Bug 33955 Summary: Add Koha::Biblio->normalized_upc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33955 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38102 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38102 [Bug 38102] Checkout history in OPAC displaying more than 50 items -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org