[Bug 40446] New: DB config used by Cypress (mysql2) is not configurable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Bug ID: 40446 Summary: DB config used by Cypress (mysql2) is not configurable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 40170 It's hardcoded to work with ktd, but it should be more flexible const connectionConfig = { host: "db", user: "koha_kohadev", password: "password", database: "koha_kohadev", }; Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40170 [Bug 40170] Replace cypress-mysql with mysql2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Bug 40446 depends on bug 40170, which changed state. Bug 40170 Summary: Replace cypress-mysql with mysql2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40170 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41362 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- This should work: const connectionConfig = { host: process.env.DB_HOSTNAME || "db", user: process.env.DB_USER || "koha_kohadev", password: process.env.DB_PASSWORD || "password", database: process.env.DB_NAME || "koha_kohadev", }; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |41362 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 [Bug 41362] Allow Cypress tests to use KOHA_USER and KOHA_PASS as override -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190160&action=edit Bug 40446: Allow overriding Cypress DB settings Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com --- Comment #3 from David Nind <david@davidnind.com> --- Changed assignee. Sorry, have no idea how to test this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190921&action=edit Bug 40446: Allow overriding Cypress DB settings Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Amended-by: Jonathan Druart tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- To test I've checked that the 4 env vars were defined in ktd, then adjusted them add made sure the test (eg. t/cypress/integration/t/db.ts) then failed $ env|grep DB_ DB_PASSWORD=password DB_HOSTNAME=db DB_USER=koha_kohadev DB_NAME=xkoha_kohadev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 --- Comment #7 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- All pushed to 25.11.x Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40446 Bug 40446 depends on bug 41362, which changed state. Bug 41362 Summary: Allow Cypress tests to use KOHA_USER and KOHA_PASS as override https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41362 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org