https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16047 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48978&action=edit Bug 16047: Making category code a required field on creating a group This will prevent users from creating a group without a category code, which causes a software error when you try to delete it To test: 1) Go to Admin -> Libraries and groups 2) Create new group without category code 3) Attempt to delete the group you just created and notice software error 4) Apply patch 5) Create new group without category code 6) Notice you now cannot save the group without putting in a category code Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48978|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49266&action=edit [SIGNED-OFF] Bug 16047: Making category code a required field on creating a group This will prevent users from creating a group without a category code, which causes a software error when you try to delete it To test: 1) Go to Admin -> Libraries and groups 2) Create new group without category code 3) Attempt to delete the group you just created and notice software error 4) Apply patch 5) Create new group without category code 6) Notice you now cannot save the group without putting in a category code Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16047 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49267|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 49268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49268&action=edit Bug 16047 [Follow-up] Software error on deleting a group with no category code This follow-up take the original patch a little further, making category name required on the entry form as well. Without a category name there is no label in the interface when selecting a category. That doens't make any sense. Also changed on the group entry form: - Added "required" attribute to labels on required fields. - Changed "Update" submit button label to "Submit." - Added a "Cancel" link. - Added the "validated" class to the form so that our built-in validation script will process it (not strictly necessary but makes the validation appearance more consistent). Followed test plan, form displays and behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16047 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16091 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16015 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49266|0 |1 is obsolete| | Attachment #49268|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49348&action=edit [PASSED QA] Bug 16047: Making category code a required field on creating a group This will prevent users from creating a group without a category code, which causes a software error when you try to delete it To test: 1) Go to Admin -> Libraries and groups 2) Create new group without category code 3) Attempt to delete the group you just created and notice software error 4) Apply patch 5) Create new group without category code 6) Notice you now cannot save the group without putting in a category code Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16047 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49349&action=edit [PASSED QA] Bug 16047 [Follow-up] Software error on deleting a group with no category code This follow-up take the original patch a little further, making category name required on the entry form as well. Without a category name there is no label in the interface when selecting a category. That doens't make any sense. Also changed on the group entry form: - Added "required" attribute to labels on required fields. - Changed "Update" submit button label to "Submit." - Added a "Cancel" link. - Added the "validated" class to the form so that our built-in validation script will process it (not strictly necessary but makes the validation appearance more consistent). Followed test plan, form displays and behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16047 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.