[Bug 11222] New: A regression on label-item-search.pl done by Bug 9239
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Bug ID: 11222 Summary: A regression on label-item-search.pl done by Bug 9239 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label printing Assignee: cnighswonger@foundations.edu Reporter: z.tajoli@cineca.it QA Contact: testopia@bugs.koha-community.org Hi to all, the commit http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=144c7f4e4e023f7a... for bug 9239 insert a regression on the search of items in print labels. In fact it an error only in one line, line 100. The patch is: - $ccl_query .= "acqdate,st-date-normalized,le=" . $datefrom->output("iso"); + $ccl_query .= "acqdate,st-date-normalized,le=" . $dateto->output("iso"); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #1 from Zeno Tajoli <z.tajoli@cineca.it> --- Created attachment 22842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22842&action=edit Fix for bug 11222 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Zeno Tajoli <z.tajoli@cineca.it> --- Test plan: 1)Start with an installation with bibliografic data and items information. 2)Check that in items there are values inside Accession Date Without the patch: a)Go in Home› Tools› Labels and click on 'New batch' b)Click on 'Add Item(s)' c)Try to select items with option "Added on or before date" d)You will receive an error With the patch: Redone points a),b), c) Now you don't receive an error and you can select items -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #3 from Zeno Tajoli <z.tajoli@cineca.it> --- This bug is on 3.12, 3.14, master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> ---
c)Try to select items with option "Added on or before date" d)You will receive an error
I cannot reproduce this error. Nor can I get any results for any date-based search, whether it be the "before" option, the "after," or both. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #5 from Zeno Tajoli <z.tajoli@cineca.it> --- So in you install the two optinons not work ? Do you have date inside 'Acquisition date field' in the iterm section. ? In MARC21 is the field 952$d The search is based on Zebra index acqdate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- My items do have accession date information, and search results can be correctly sorted by accession date, if that is any indication of the index working. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #7 from Zeno Tajoli <z.tajoli@cineca.it> --- I'm sorry for my bad english, but i don't understand the situation. Is not present the bug in your installation ? All work without problem ? And your test version is ? Thank you -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I do not see the bug in master. I do not get errors when searching by date. However, I also get no results when searching by date. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #9 from Zeno Tajoli <z.tajoli@cineca.it> --- Last option: do you use QueryParser ? Because with QueryParser on the bug is not present. See from master, labels/label-item-search.pl: 94 $dateto = C4::Dates->new($dateto); 95 if ($QParser) { 96 $ccl_query .= ' && ' if ( $ccl_textbox || $datefrom ); 97 $ccl_query .= "acqdate(-" . $dateto->output("iso") . ')'; 98 } else { 99 $ccl_query .= ' and ' if ( $ccl_textbox || $datefrom ); 100 $ccl_query .= "acqdate,st-date-normalized,le=" . $datefrom->output("iso"); 101 } In fact line 97 [QueryParser on] is OK. Line 100 [QueryParser off] has the bug -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 22959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22959&action=edit [SIGNED-OFF] Bug 11222 - A regression on label-item-search.pl done by Bug 9239 Searching for items to add to a label batch fails with an error if QueryParser is enabled and you use the "Added on or before date" search option. Test plan: 0) Set "UseQueryParser" to "do not try" 1) Start with an installation with bibliografic data and items information. 2) Check that in items there are values inside Accession Date Without the patch: a) Go in Home› Tools› Labels and click on 'New batch' b) Click on 'Add Item(s)' c) Try to select items with option "Added on or before date" d) You will receive an error With the patch: Redone points a),b), c) Now you don't receive an error and you can select items Signed-off-by: Owen Leonard <oleonard@myacpl.org> Added a description of the problem and copied the test plan from the bug report, with the addition of the information that QueryParser must be off to confirm and test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22842|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22959|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23091&action=edit Bug 11222 - A regression on label-item-search.pl done by Bug 9239 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudolfbyker@gmail.com --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- *** Bug 10867 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Zeno! Unrelated to this patch, it appears that date accessioned searching from this form isn't working at all if QueryParser is on. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- I wrote up the issue with acquisition date searching when QueryParser is enabled in bug 11293. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This patch has been pushed to 3.14.x, will be in 3.14.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Zeno! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org