[Bug 34383] New: Inconsistencies in Patron attributes page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 Bug ID: 34383 Summary: Inconsistencies in Patron attributes page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Patron attributes page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Add patron attribute type' to 'New patron attribute type' - Add patron attribute type code, in single quotes, in the Modify page Breadcrumb - Change 'Add patron attribute type' to 'New patron attribute type' - Add patron attribute type code, in single quotes, in the Modify page Page header - Change 'Add patron attribute type' to 'New patron attribute type' - Add patron attribute type code, in single quotes, in the Modify page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154636&action=edit Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header This patch makes changes to the patron attribute types administration template so that the page title, breadcrumb navigation, and page headers are more consistent with each other and with other parts of Koha. To test, apply the patch and go to Administration -> Patron attribute types. Test these versions of the page to confirm that the breadcrumbs and page title are consistent with each other: - Main view - New patron attribute type - Edit patron attribute type - Confirm deletion of attribute type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154636|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154652&action=edit Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header This patch makes changes to the patron attribute types administration template so that the page title, breadcrumb navigation, and page headers are more consistent with each other and with other parts of Koha. To test, apply the patch and go to Administration -> Patron attribute types. Test these versions of the page to confirm that the breadcrumbs and page title are consistent with each other: - Main view - New patron attribute type - Edit patron attribute type - Confirm deletion of attribute type Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 Christian Nelson <christian.nelson@uwasa.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.nelson@uwasa.fi Status|Needs Signoff |Signed Off --- Comment #3 from Christian Nelson <christian.nelson@uwasa.fi> --- Confirmed that breadcrumbs and page title are consistent with the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154652|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156011&action=edit Bug 34383: Fix inconsistencies in Patron attributes page titles, breadcrumbs, and header This patch makes changes to the patron attribute types administration template so that the page title, breadcrumb navigation, and page headers are more consistent with each other and with other parts of Koha. To test, apply the patch and go to Administration -> Patron attribute types. Test these versions of the page to confirm that the breadcrumbs and page title are consistent with each other: - Main view - New patron attribute type - Edit patron attribute type - Confirm deletion of attribute type Signed-off-by: Christian Nelson <christian.nelson@uwasa.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34383 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org