https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146455&action=edit Bug 32159: Fix heading hierarchy on uncertain prices page This makes sure we don't have 2 level 1 headings on the same page. To test: * Create a new order for a basket in the acq module, make sure the uncertain price checkbox is checked bevor saving * Go to uncertain prices using the link in the toolbar on the basket summary page * Verify that there are 2 almost identical h1 headings and a "/ Fax:" reference at the top of the page * Apply patch * Verify that we now have one level 1 heading and a level 2 heading for each section. The fax reference is also gone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146455|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146646&action=edit Bug 32159: Fix heading hierarchy on uncertain prices page This makes sure we don't have 2 level 1 headings on the same page. To test: * Create a new order for a basket in the acq module, make sure the uncertain price checkbox is checked bevor saving * Go to uncertain prices using the link in the toolbar on the basket summary page * Verify that there are 2 almost identical h1 headings and a "/ Fax:" reference at the top of the page * Apply patch * Verify that we now have one level 1 heading and a level 2 heading for each section. The fax reference is also gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146646|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146907&action=edit Bug 32159: Fix heading hierarchy on uncertain prices page This makes sure we don't have 2 level 1 headings on the same page. To test: * Create a new order for a basket in the acq module, make sure the uncertain price checkbox is checked bevor saving * Go to uncertain prices using the link in the toolbar on the basket summary page * Verify that there are 2 almost identical h1 headings and a "/ Fax:" reference at the top of the page * Apply patch * Verify that we now have one level 1 heading and a level 2 heading for each section. The fax reference is also gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146907|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147207&action=edit Bug 32159: Fix heading hierarchy on uncertain prices page This makes sure we don't have 2 level 1 headings on the same page. To test: * Create a new order for a basket in the acq module, make sure the uncertain price checkbox is checked bevor saving * Go to uncertain prices using the link in the toolbar on the basket summary page * Verify that there are 2 almost identical h1 headings and a "/ Fax:" reference at the top of the page * Apply patch * Verify that we now have one level 1 heading and a level 2 heading for each section. The fax reference is also gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32159 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.