[Bug 40622] New: Bug 38233 not properly applied to 24.11.x+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Bug ID: 40622 Summary: Bug 38233 not properly applied to 24.11.x+ Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org A close examination of the code in "C4/ILSDI/Services.pm" shows that only half the patch from bug 38233 was applied to 24.11.00. It was properly backported to 24.05.06, so anyone upgrading from 24.05.06 to 24.11.00 would experience a regression. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Main |24.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38233 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38233 [Bug 38233] ILS-DI GetRecords should filter out items hidden in OPAC and use OPAC MARCXML -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I suppose I'll say the Version is Main and then it would need to be backported back to 24.11.x... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Since bug 38233 and bug 31224 went in around the same time, it looks like there was probably a merge conflict and the fix wasn't done correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 185262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185262&action=edit Bug 40622: Add missing interface parameter This change adds the missing interface parameter which Bug 38233 initially added. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Leaving as ASSIGNED as I'll need to come back to this with a test plan, verify it, and see about adding a unit test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Indeed, the original bug unit test does not cover this change. We must add a test on item datas in the MARCXML content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #5)
Indeed, the original bug unit test does not cover this change. We must add a test on item datas in the MARCXML content.
So it doesn't need to be item data per se. /cgi-bin/koha/ilsdi.pl?service=GetRecords&id=1+2+99999 also returns the "marcxml". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #6)
(In reply to Fridolin Somers from comment #5)
Indeed, the original bug unit test does not cover this change. We must add a test on item datas in the MARCXML content.
So it doesn't need to be item data per se.
/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=1+2+99999 also returns the "marcxml".
I've run out of time today, but I've nearly got a unit test that will work... It's fiddly but we'll get there... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Created attachment 185617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185617&action=edit Bug 40622: Use OPAC MARCXML for ILS-DI GetRecords This change makes it so that the ILS-DI GetRecords output for "marcxml" will contain the OPAC version of the record. Test plan: 0. Apply the patches 1. prove t/db_dependent/ILSDI_Services.t 2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 3. Click "Settings" to change the framework to Default, and click "Save" 4. Go to http://localhost:8081/cgi-bin/koha/admin/marc_subfields_structure.pl ?op=add_form&tagfield=245&tagsubfield=a&frameworkcode=#subafield 5. Untick the "OPAC" box and click "Save changes" 6. Go to system preferences 7. Change "ILS-DI" to "Enable" 8. Change "ILS-DI:AuthorizedIPs" to 0.0.0.0/0 9. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 10. Note that you cannot see the title in the MARCXML. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Okie dokie... we've got a manual test and a unit test. Huzzah! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |ILS-DI GetRecords will now release notes| |show the OPAC version of | |"marcxml". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185262|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 186000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186000&action=edit Bug 40622: Add missing interface parameter This change adds the missing interface parameter which Bug 38233 initially added. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185617|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 186001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186001&action=edit Bug 40622: Use OPAC MARCXML for ILS-DI GetRecords This change makes it so that the ILS-DI GetRecords output for "marcxml" will contain the OPAC version of the record. Test plan: 0. Apply the patches 1. prove t/db_dependent/ILSDI_Services.t 2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 3. Click "Settings" to change the framework to Default, and click "Save" 4. Go to http://localhost:8081/cgi-bin/koha/admin/marc_subfields_structure.pl ?op=add_form&tagfield=245&tagsubfield=a&frameworkcode=#subafield 5. Untick the "OPAC" box and click "Save changes" 6. Go to system preferences 7. Change "ILS-DI" to "Enable" 8. Change "ILS-DI:AuthorizedIPs" to 0.0.0.0/0 9. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 10. Note that you cannot see the title in the MARCXML. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Passed QA --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving this to the next queue. Not for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #12)
Moving this to the next queue. Not for main.
No, it's needed for main too. 24.11, 25.05, and main all still need it. 24.05 is the only version that got it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #13)
(In reply to Marcel de Rooy from comment #12)
Moving this to the next queue. Not for main.
No, it's needed for main too.
24.11, 25.05, and main all still need it.
24.05 is the only version that got it.
Okay, the title is bit misleading :) Could you change title and status accordingly? Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- I nearly applyed on 24.11.x but seen last comments. I wait ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 38233 not properly |Bug 38233 not properly |applied to 24.11.x+ |applied to 24.11.x, | |25.05.x, and main --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #14)
(In reply to David Cook from comment #13)
(In reply to Marcel de Rooy from comment #12)
Moving this to the next queue. Not for main.
No, it's needed for main too.
24.11, 25.05, and main all still need it.
24.05 is the only version that got it.
Okay, the title is bit misleading :) Could you change title and status accordingly? Thanks
I thought it made sense because it would be all versions from 24.11 onward, but I'll try to rephrase the title :) Not sure what you mean about changing the status though? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #15)
I nearly applyed on 24.11.x but seen last comments. I wait ;)
Basically, Bug 38233 was added to 24.05.06 and 24.11.00 (main at that time). However, there was a merge error in 24.11.00 (main at that time), so it wasn't properly applied. That means that the only version that has the fix for Bug 38233 is 24.05.06. So main needs this fix, and it should be backported to 25.05 and 24.11 (but not 24.05). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #14)
Okay, the title is bit misleading :) Could you change title and status accordingly?
I think that I understand what you mean now. It must've sounded like it was just needed for the older versions because I used the version numbers specifically. Hopefully this re-worded one is better? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #19 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #14)
Okay, the title is bit misleading :) Could you change title and status accordingly?
Regarding the status, do you mean it should go back to "Signed Off" and you're not Passing QA on it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #19)
(In reply to Marcel de Rooy from comment #14)
Okay, the title is bit misleading :) Could you change title and status accordingly?
Regarding the status, do you mean it should go back to "Signed Off" and you're not Passing QA on it?
It didnt really pass QA yet. It was just moved out of SO. But your explanation qualifies it for QA shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186000|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 187474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187474&action=edit Bug 40622: Add missing interface parameter This change adds the missing interface parameter which Bug 38233 initially added. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186001|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 187475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187475&action=edit Bug 40622: Use OPAC MARCXML for ILS-DI GetRecords This change makes it so that the ILS-DI GetRecords output for "marcxml" will contain the OPAC version of the record. Test plan: 0. Apply the patches 1. prove t/db_dependent/ILSDI_Services.t 2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 3. Click "Settings" to change the framework to Default, and click "Save" 4. Go to http://localhost:8081/cgi-bin/koha/admin/marc_subfields_structure.pl ?op=add_form&tagfield=245&tagsubfield=a&frameworkcode=#subafield 5. Untick the "OPAC" box and click "Save changes" 6. Go to system preferences 7. Change "ILS-DI" to "Enable" 8. Change "ILS-DI:AuthorizedIPs" to 0.0.0.0/0 9. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 10. Note that you cannot see the title in the MARCXML. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #20)
(In reply to David Cook from comment #19)
(In reply to Marcel de Rooy from comment #14)
Okay, the title is bit misleading :) Could you change title and status accordingly?
Regarding the status, do you mean it should go back to "Signed Off" and you're not Passing QA on it?
It didnt really pass QA yet. It was just moved out of SO. But your explanation qualifies it for QA shortly.
Looking 10 seconds longer did the job. Sorry for the delay. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41012 [Bug 41012] ILSDI_Services.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 --- Comment #25 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.05 |25.11.00,25.05.05,24.11.11 released in| | --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40622 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #27 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org