[Bug 34114] New: OMNIBUS: Replace the use of jQueryUI sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Bug ID: 34114 Summary: OMNIBUS: Replace the use of jQueryUI sortable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 29222 As discussed in Bug 29222, jQueryUI sortable should be replaced. The last time I checked it was used in these places: - Administration -> MARC frameworks -> Subfield structure -> Tab reordering. - Administration -> Authority types -> Subfield structure -> Tab reordering. - Administration -> System preferences -> Language and OPACLanguage reordering - Cataloging -> Basic MARC editor -> Subfield reordering. - Tools -> Stock rotation -> Stage reordering. It looks like Drupal switched to this library: https://github.com/SortableJS/Sortable Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29222 [Bug 29222] OMNIBUS: Replace the use of jQueryUI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OMNIBUS: Replace the use of |Replace the use of jQueryUI |jQueryUI sortable |sortable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153041&action=edit Bug 34114: Quick test with Sortable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is working very easily and the doc is great. Good catch, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153041|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153395&action=edit Bug 34114: Replace the use of jQueryUI sortable This patch adds a replacement for jQueryUI sortable, a standalone library called Sortable. The patch updates pages which previously used jQueryUI for sorting. The patch updates the style of most sortable elements to use the "grip-vertical" Font Awesome icon. To test, apply the patch and test the following pages, confirming that sortable elements are sortable and that the newly sorted state is saved correctly: - Administration -> System prefernces -> I18N/L10N - With multiple languages installed, test that languages listed in the 'language' and 'OPACLanguages' preferences can be sorted and that after saving your changes the interface relfects your changes: In the footer and header of the OPAC and in the footer of the staff interface. - Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields of a tag. - Test using a tag with multiple subfields, e.g. MARC21 245. - Test that you can click and drag to reorder the tabs in the subfield edit view. - Test that when you save your changes, including changes to the "New" tab position, that fields are ordered correctly both in the display on this page and in the basic MARC editor. - Perform the same tests on Authorities: Administration -> Authority types -> MARC structure -> Edit subfields of a tag. - Authorities -> New (or edit) authority - Multiple subfields of a tag should be sortable. - Multiple copies of the same tag should be sortable relative to each other. - Confirm that your changes are saved correctly and that the detail view of your updated authority record is correct. - Perform the same tests on Cataloging -> New (or edit) record in the basic MARC editor. - Enable the StockRotation system preference if necessary. - Go to Cataloging -> Stock rotation - If necessary, create a new rota and add multiple stages - In the "Manage stages" view you should be able to click and drag to reorder stages. The new position should be saved immediately via AJAX. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34270 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34270 [Bug 34270] Upgrade and prune jQueryUI assets in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153395|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 154626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154626&action=edit Bug 34114: Replace the use of jQueryUI sortable This patch adds a replacement for jQueryUI sortable, a standalone library called Sortable. The patch updates pages which previously used jQueryUI for sorting. The patch updates the style of most sortable elements to use the "grip-vertical" Font Awesome icon. To test, apply the patch and test the following pages, confirming that sortable elements are sortable and that the newly sorted state is saved correctly: - Administration -> System prefernces -> I18N/L10N - With multiple languages installed, test that languages listed in the 'language' and 'OPACLanguages' preferences can be sorted and that after saving your changes the interface relfects your changes: In the footer and header of the OPAC and in the footer of the staff interface. - Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields of a tag. - Test using a tag with multiple subfields, e.g. MARC21 245. - Test that you can click and drag to reorder the tabs in the subfield edit view. - Test that when you save your changes, including changes to the "New" tab position, that fields are ordered correctly both in the display on this page and in the basic MARC editor. - Perform the same tests on Authorities: Administration -> Authority types -> MARC structure -> Edit subfields of a tag. - Authorities -> New (or edit) authority - Multiple subfields of a tag should be sortable. - Multiple copies of the same tag should be sortable relative to each other. - Confirm that your changes are saved correctly and that the detail view of your updated authority record is correct. - Perform the same tests on Cataloging -> New (or edit) record in the basic MARC editor. - Enable the StockRotation system preference if necessary. - Go to Cataloging -> Stock rotation - If necessary, create a new rota and add multiple stages - In the "Manage stages" view you should be able to click and drag to reorder stages. The new position should be saved immediately via AJAX. Signed-off-by: paul <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154626|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155008&action=edit Bug 34114: Replace the use of jQueryUI sortable This patch adds a replacement for jQueryUI sortable, a standalone library called Sortable. The patch updates pages which previously used jQueryUI for sorting. The patch updates the style of most sortable elements to use the "grip-vertical" Font Awesome icon. To test, apply the patch and test the following pages, confirming that sortable elements are sortable and that the newly sorted state is saved correctly: - Administration -> System prefernces -> I18N/L10N - With multiple languages installed, test that languages listed in the 'language' and 'OPACLanguages' preferences can be sorted and that after saving your changes the interface relfects your changes: In the footer and header of the OPAC and in the footer of the staff interface. - Administration -> MARC bibliographic framework -> MARC structure -> Edit subfields of a tag. - Test using a tag with multiple subfields, e.g. MARC21 245. - Test that you can click and drag to reorder the tabs in the subfield edit view. - Test that when you save your changes, including changes to the "New" tab position, that fields are ordered correctly both in the display on this page and in the basic MARC editor. - Perform the same tests on Authorities: Administration -> Authority types -> MARC structure -> Edit subfields of a tag. - Authorities -> New (or edit) authority - Multiple subfields of a tag should be sortable. - Multiple copies of the same tag should be sortable relative to each other. - Confirm that your changes are saved correctly and that the detail view of your updated authority record is correct. - Perform the same tests on Cataloging -> New (or edit) record in the basic MARC editor. - Enable the StockRotation system preference if necessary. - Go to Cataloging -> Stock rotation - If necessary, create a new rota and add multiple stages - In the "Manage stages" view you should be able to click and drag to reorder stages. The new position should be saved immediately via AJAX. Signed-off-by: paul <paul.poulain@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35194 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35194 [Bug 35194] Javascript error: Uncaught TypeError: $(...).sortable is not a function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35304 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35304 [Bug 35304] Add new Sortable library to didyoumean configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34114 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35304 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35304 [Bug 35304] Add new Sortable library to didyoumean configuration -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org