[Bug 31921] New: No confirmation alert when deleting a vendor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Bug ID: 31921 Summary: No confirmation alert when deleting a vendor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 28082 First vendor of the page has a confirmation alert, but the answer is ignored! I guess it's coming from Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 [Bug 28082] Add acquisitions toolbar to vendors on vendor search page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|major |normal --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Can we confirm if this is still the case? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Yes, still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 168668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168668&action=edit Bug 31921: Add confirmation modal when deleting a vendor This patch adds a new modal for confirming vendor deletion. It fixes the previous functionality, showing a confirmation modal for each vendor and appropriately handling the response. To test: 1) Visit Acquisitions home. Under where it says 'Manage orders', click the search bar to bring up the list of vendors. 2) Add a few vendors by clicking 'New' and 'Vendor'. After this, go back to the vendor search so that all the vendors are showing. 3) For each vendor, click on 'Delete vendor' and ensure the modal shows properly. 4) Attempt to delete one of the vendors. Go back to the vendor search and ensure they are deleted correctly. 5) Click on a vendor's name to go their supplier page. Make sure modal works properly and attempt to delete a vendor from here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168668|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168674&action=edit Bug 31921: Add confirmation modal when deleting a vendor This patch adds a new modal for confirming vendor deletion. It fixes the previous functionality, showing a confirmation modal for each vendor and appropriately handling the response. To test: 1) Visit Acquisitions home. Under where it says 'Manage orders', click the search bar to bring up the list of vendors. 2) Add a few vendors by clicking 'New' and 'Vendor'. After this, go back to the vendor search so that all the vendors are showing. 3) For each vendor, click on 'Delete vendor' and ensure the modal shows properly. 4) Attempt to delete one of the vendors. Go back to the vendor search and ensure they are deleted correctly. 5) Click on a vendor's name to go their supplier page. Make sure modal works properly and attempt to delete a vendor from here. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- It will only works from supplier.pl and booksellers.pl For instance it does not work from aqcontract.pl I think you should include the modal code from acquisitions-toolbar.inc to avoid this kind of mistakes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #6 from Sam Lau <samalau@gmail.com> --- Maybe this should be a new bug since there wasn't already a delete button there? If you disagree I could just add it here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #7 from Sam Lau <samalau@gmail.com> --- Created attachment 168749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168749&action=edit Bug 31921: Add confirmation modal to contracts and uncertain prices To test: 1) Have 2 deletable vendors 2) Visit the first vendor's "Contracts" tab 3) Attempt to delete from here, modal shows and deltion is successful 4) Visit the second vendor's "Uncertain prices" tab. 5) Attempt to delete from here, modal shows and deletion is successful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #5)
I think you should include the modal code from acquisitions-toolbar.inc to avoid this kind of mistakes.
Did you try this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #9 from Sam Lau <samalau@gmail.com> --- (In reply to Jonathan Druart from comment #8)
(In reply to Jonathan Druart from comment #5)
I think you should include the modal code from acquisitions-toolbar.inc to avoid this kind of mistakes.
Did you try this?
There is no modal code in acquisitions-toolbar.inc so I'm not sure what you mean. Unless you are saying to include the new 'modals/delete_vendor.inc' inside of the acquisitions toolbar? In which case, no I did not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168749|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168832&action=edit Bug 31921: Include the modal code from acquisitions-toolbar.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- This patch is what I meant. It works on all pages where the modal exists and avoid the code duplication. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #12 from Sam Lau <samalau@gmail.com> --- (In reply to Jonathan Druart from comment #11)
This patch is what I meant. It works on all pages where the modal exists and avoid the code duplication.
Got it, that makes sense. Thanks for the help -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #13 from David Nind <david@davidnind.com> --- The patches still apply. I am getting this error when I go to delete a vendor: 1. Go to Acquisitions > Manage orders > Search (/cgi-bin/koha/acqui/booksellers.pl?supplier=) 2. Add some vendors (+New vendor) 3. Click on "Delete vendor" for any vendor where this option appears. 4. From the pop-up window ("Are you sure you want to delete this vendor"), click "Yes". 5. Error message: Can't call method "baskets" on an undefined value at /kohadevbox/koha/acqui/supplier.pl line 94.... I get the same error from any of the pages that the delete vendor action is available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168674|0 |1 is obsolete| | Attachment #168832|0 |1 is obsolete| | --- Comment #14 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170004&action=edit Bug 31921: Add confirmation modal when deleting a vendor This patch adds a new modal for confirming vendor deletion. It fixes the previous functionality, showing a confirmation modal for each vendor and appropriately handling the response. To test: 1) Visit Acquisitions home. Under where it says 'Manage orders', click the search bar to bring up the list of vendors. 2) Add a few vendors by clicking 'New' and 'Vendor'. After this, go back to the vendor search so that all the vendors are showing. 3) For each vendor, click on 'Delete vendor' and ensure the modal shows properly. 4) Attempt to delete one of the vendors. Go back to the vendor search and ensure they are deleted correctly. 5) Click on a vendor's name to go their supplier page. Make sure modal works properly and attempt to delete a vendor from here. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #15 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 170005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170005&action=edit Bug 31921: Include the modal code from acquisitions-toolbar.inc Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #16 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to David Nind from comment #13)
The patches still apply.
I am getting this error when I go to delete a vendor:
1. Go to Acquisitions > Manage orders > Search (/cgi-bin/koha/acqui/booksellers.pl?supplier=) 2. Add some vendors (+New vendor) 3. Click on "Delete vendor" for any vendor where this option appears. 4. From the pop-up window ("Are you sure you want to delete this vendor"), click "Yes". 5. Error message: Can't call method "baskets" on an undefined value at /kohadevbox/koha/acqui/supplier.pl line 94....
I get the same error from any of the pages that the delete vendor action is available.
I can't recreate this David, added my SO line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170004|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170538&action=edit Bug 31921: Add confirmation modal when deleting a vendor This patch adds a new modal for confirming vendor deletion. It fixes the previous functionality, showing a confirmation modal for each vendor and appropriately handling the response. To test: 1) Visit Acquisitions home. Under where it says 'Manage orders', click the search bar to bring up the list of vendors. 2) Add a few vendors by clicking 'New' and 'Vendor'. After this, go back to the vendor search so that all the vendors are showing. 3) For each vendor, click on 'Delete vendor' and ensure the modal shows properly. 4) Attempt to delete one of the vendors. Go back to the vendor search and ensure they are deleted correctly. 5) Click on a vendor's name to go their supplier page. Make sure modal works properly and attempt to delete a vendor from here. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170005|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170539&action=edit Bug 31921: Include the modal code from acquisitions-toolbar.inc Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice consistency improvement, thanks. All works as expected Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37739 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #21 from David Nind <david@davidnind.com> --- (In reply to Nick Clemens (kidclamp) from comment #16)
(In reply to David Nind from comment #13) ...
I can't recreate this David, added my SO line
I couldn't recreate the error either (after checking out main before the Bootstrap 5 update). Apologies taking so long to respond to your comment! However, after the Bootstrap 5 update, you can no longer delete vendors. I've created bug 37739 for this - I'm assuming it is related to the Bootstrap 5 update, rather than anything else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- Pushed at almost the same time of the bootstrap 5 update, but should have been pushed after with the code adjusted. See bug 37739. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes deleting vendors release notes| |in acquisitions. There is | |now a new confirmation | |pop-up dialogue box. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.04 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31921 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not easy to backport on 23.11.x that has not "cud-" I'd say skip for oldstable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org