[Bug 25805] New: SIP will show hold patron name (DA) as C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Bug ID: 25805 Summary: SIP will show hold patron name (DA) as C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP will show hold patron |SIP will show hold patron |name (DA) as |name (DA) as something like |C4::SIP::SIPServer=HASH(0x8 |C4::SIP::SIPServer=HASH(0x8 |8175c8) if there is no |8175c8) if there is no |patron |patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106009&action=edit Bug 25805: SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106009|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 106029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106029&action=edit Bug 25805: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 106030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106030&action=edit Bug 25805: SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106029|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106078&action=edit Bug 25805: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106030|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106079&action=edit Bug 25805: SIP will show hold patron name (DA) as something like C4::SIP::SIPServer=HASH(0x88175c8) if there is no patron This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, regressions tests present and passes qa scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please adjust the description of the main patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7)
Please adjust the description of the main patch.
How would you like it adjusted? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- To describe what the patch does, not what the problem is (ie. not a copy/paste of the bug report title). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106079|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 106257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106257&action=edit Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode. The subroutine hold_patron_bcode should always return an empty string, not undef. Test Plan: 1) Using the SIP cli emulator, checkin an item that is not checked out 2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)" The hex number will almost certainly be different from this example 3) Apply this patch 4) Restart the SIP server 5) Run the SIP checkin again 6) Note the DA field is no longer present! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in| |19.11.08 Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25805 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08 |19.11.08, 19.05.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org