[Bug 8242] New: Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Priority: P5 - low Change sponsored?: --- Bug ID: 8242 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" Severity: enhancement Classification: Unclassified OS: All Reporter: koha@univ-lyon3.fr Hardware: All Status: NEW Version: rel_3_8 Component: Patrons Product: Koha Created attachment 10256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10256&action=edit Patch members-toolbar.inc Same thing than bug Bogue 7888 but in members tab : allow a use with edit borrowers permission to change the password. Patch changes permisison for "change password" button in members-toolbar.inc from staffaccess to borrowers. To test : To test: - With a staff user with borrowers permission, verify the change password button is shown for a normal patron. - With a staff user without borrowers permission, verify the change password button does not appear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |koha@univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10256|0 |1 is patch| | Attachment #10256|application/octet-stream |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|rel_3_8 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The change is logical and works as expected. I am only wondering under which circumstances it was possible to reach the page with staffaccess but without borrowers permission? Both the memberentry and the passwordchange template require borrowers permission to be accessible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think at some point in time it was not possible for staff users to change their own or the passwords of other staff members. Passwords could be changed in OPAC or by the superlibrarian. I am not sure when this changed, but the change is not dependend on this patch. Do we want it to work this way or should the former feature be restored? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10256|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10331&action=edit [SIGNED-OFF] Permission for change password button in members toolbar should be borrowers instead of staffaccess http://bugs.koha-community.org/show_bug.cgi?id=8242 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|kyle.m.hall@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: Changes permissions for member's password modification. It seems logical. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Severity|enhancement |minor --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- I think it's more a bugfix than an ENH, chris_c, your final decision -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org