[Bug 37262] New: api/v1/extended_attribute_types does not filter additional fields for unmapped tablenames
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Bug ID: 37262 Summary: api/v1/extended_attribute_types does not filter additional fields for unmapped tablenames Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com Depends on: 35197, 37261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 [Bug 35197] Expose additional_field definitions through REST API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37261 [Bug 37261] api/v1/extended_attribute_types does not return additional fields for unmapped tablenames -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168533&action=edit Bug 37262: Tests for filtering unmapped tablename Test plan: 1) Apply this patch only, run tests: prove t/db_dependent/api/v1/extended_attribute_types.t 2) Notice they fail 3) Apply the fix patch, run tests again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168534&action=edit Bug 37262: Fix for unmapped tablename filtering -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Severity|enhancement |normal Patch complexity|--- |Trivial patch Version|unspecified |Main Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35044 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35044 [Bug 35044] Additional fields: Allow for repeatable fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- The tests don't pass after applying the fix patch. With the first patch (and dependent bug 37261) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ prove t/db_dependent/api/v1/extended_attribute_types.t t/db_dependent/api/v1/extended_attribute_types.t .. # Failed test '200 OK' # at t/db_dependent/api/v1/extended_attribute_types.t line 124. # got: '400' # expected: '200' # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/extended_attribute_types.t line 124. # Structures begin differing at: # $got = HASH(0x58ce5bcd0ea0) # $expected = ARRAY(0x58ce5c4ed4e8) # Looks like you failed 2 tests of 23. t/db_dependent/api/v1/extended_attribute_types.t .. 1/1 # Failed test 'list() tests' # at t/db_dependent/api/v1/extended_attribute_types.t line 135. # Looks like you failed 1 test of 1. t/db_dependent/api/v1/extended_attribute_types.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report ------------------- t/db_dependent/api/v1/extended_attribute_types.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 4 wallclock secs ( 0.02 usr 0.00 sys + 3.18 cusr 0.28 csys = 3.48 CPU) Result: FAIL After the fix patch ~~~~~~~~~~~~~~~~~~~ prove t/db_dependent/api/v1/extended_attribute_types.t t/db_dependent/api/v1/extended_attribute_types.t .. # Failed test '200 OK' # at t/db_dependent/api/v1/extended_attribute_types.t line 124. # got: '400' # expected: '200' # Failed test 'exact match for JSON Pointer ""' # at t/db_dependent/api/v1/extended_attribute_types.t line 124. # Structures begin differing at: # $got = HASH(0x643ead195ea8) # $expected = ARRAY(0x643ead191650) # Looks like you failed 2 tests of 23. t/db_dependent/api/v1/extended_attribute_types.t .. 1/1 # Failed test 'list() tests' # at t/db_dependent/api/v1/extended_attribute_types.t line 135. # Looks like you failed 1 test of 1. t/db_dependent/api/v1/extended_attribute_types.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report ------------------- t/db_dependent/api/v1/extended_attribute_types.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 4 wallclock secs ( 0.01 usr 0.01 sys + 3.20 cusr 0.22 csys = 3.44 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168533|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168589&action=edit Bug 37262: Tests for filtering unmapped tablename Test plan: 1) Apply this patch only, run tests: prove t/db_dependent/api/v1/extended_attribute_types.t 2) Notice they fail 3) Apply the fix patch, refresh the API bundle, run: yarn api:bundle 4) Run tests again, notice they pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168534|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168590&action=edit Bug 37262: Fix for unmapped tablename filtering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Thank you David, I missed a step on the test plan and have now updated it. We are required to run: yarn api:bundle Because the API specs have changed I believe. Can you please try again? The api bundle command failed for me today before running ktd pull so please try that if it fails for you the first time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #6)
Thank you David, I missed a step on the test plan and have now updated it. We are required to run: yarn api:bundle
Because the API specs have changed I believe. Can you please try again? The api bundle command failed for me today before running ktd pull so please try that if it fails for you the first time.
Thanks Pedro! That worked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168589|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 168613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168613&action=edit Bug 37262: Tests for filtering unmapped tablename Test plan: 1) Apply this patch only, run tests: prove t/db_dependent/api/v1/extended_attribute_types.t 2) Notice they fail 3) Apply the fix patch, refresh the API bundle, run: yarn api:bundle 4) Run tests again, notice they pass Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168590|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 168614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168614&action=edit Bug 37262: Fix for unmapped tablename filtering Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168613|0 |1 is obsolete| | Attachment #168614|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 168742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168742&action=edit Bug 37262: Tests for filtering unmapped tablename Test plan: 1) Apply this patch only, run tests: prove t/db_dependent/api/v1/extended_attribute_types.t 2) Notice they fail 3) Apply the fix patch, refresh the API bundle, run: yarn api:bundle 4) Run tests again, notice they pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 168743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168743&action=edit Bug 37262: Fix for unmapped tablename filtering Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Edit: amended to tidy the new code (tcohen) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 168744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168744&action=edit Bug 37262: (follow-up) Rename types/tables Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pedro: please review my follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168744|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168752&action=edit Bug 37262: (follow-up) Rename types/tables Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Bug 37262 depends on bug 37261, which changed state. Bug 37261 Summary: api/v1/extended_attribute_types does not return additional fields for unmapped tablenames https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37261 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Missing 24.05.x deps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Bug 37262 depends on bug 35197, which changed state. Bug 35197 Summary: Expose additional_field definitions through REST API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37262 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35197 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 [Bug 35197] Expose additional_field definitions through REST API -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org