[Bug 16782] New: Display public report URL in staff client report interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Bug ID: 16782 Summary: Display public report URL in staff client report interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org If you have marked a report as public, one ought to be able to easily find the URL of the report to use from within the staff client. Possible locations for this are as another column (or link) in the table of saved reports, a link or text from the "Report created, what now?" page, or an automatic category of report that shows all public reports, with their OPAC links. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #1 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 68286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68286&action=edit Bug 16782 - disclose URL for public reports on the saved report page It has always annoyed me that you had to look at the help to divine the url for a public report. This patch works it out and displays it for you. Requirements: - OPACBaseURL must be set for the url to be complete. It's ok if it's not, but it's better if it is. - You must have a saved report that is public to your OPAC. To test: - create a public saved report. It can be anything. - view the saved reports page, note that under Public it says: Avaliable at (opacbaseurl)/cgi-bin/koha/svc/report?id=1 - clicking it should take you to the public results of your report. sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68286|0 |1 is obsolete| | --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 68287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68287&action=edit Bug 16782 - disclose URL for public reports on the saved report page It has always annoyed me that you had to look at the help to divine the url for a public report. This patch works it out and displays it for you. Requirements: - OPACBaseURL must be set for the url to be complete. It's ok if it's not, but it's better if it is. - You must have a saved report that is public to your OPAC. To test: - create a public saved report. It can be anything. - view the saved reports page, note that under Public it says: Avaliable at (opacbaseurl)/cgi-bin/koha/svc/report?id=1 - copying and pasting that into the address bar should take you to the public results of your report. sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #3 from Hugo Agud <hagud@orex.es> --- We have applied the patch we have found 1. It works as expected BUT if you modify the report, the new results doesn't appear until you clean cache and restart plack --> perhaps it is not related with this patch, but it fails. 2. we have seen that the info of the report if given in json format, it is nice for managin that, but is that the expected behaviour? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- This patch does not touch the functionality of the public reports. Set the cache timer to a low value (not 0, 0 means it never refreshes) if you want to have instant-ish updates. Yes, JSON is the expected behaviour. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68287|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 68446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68446&action=edit Bug 16782 - disclose URL for public reports on the saved report page It has always annoyed me that you had to look at the help to divine the url for a public report. This patch works it out and displays it for you. Requirements: - OPACBaseURL must be set for the url to be complete. It's ok if it's not, but it's better if it is. - You must have a saved report that is public to your OPAC. To test: - create a public saved report. It can be anything. - view the saved reports page, note that under Public it says: Avaliable at (opacbaseurl)/cgi-bin/koha/svc/report?id=1 - copying and pasting that into the address bar should take you to the public results of your report. sponsored-by: Catalyst IT Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 68447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68447&action=edit Bug 16782: Fix spelling of 'Available' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Doh thanks for catching that. :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68446|0 |1 is obsolete| | Attachment #68447|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68619&action=edit Bug 16782 - disclose URL for public reports on the saved report page It has always annoyed me that you had to look at the help to divine the url for a public report. This patch works it out and displays it for you. Requirements: - OPACBaseURL must be set for the url to be complete. It's ok if it's not, but it's better if it is. - You must have a saved report that is public to your OPAC. To test: - create a public saved report. It can be anything. - view the saved reports page, note that under Public it says: Avaliable at (opacbaseurl)/cgi-bin/koha/svc/report?id=1 - copying and pasting that into the address bar should take you to the public results of your report. sponsored-by: Catalyst IT Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68620&action=edit Bug 16782: Fix spelling of 'Available' Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68621&action=edit Bug 16782: QA Followup - use a link instead of showing full URL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Display was a bit long, took the liberty of using a link instead of the URL, hope that's okay -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we show the URL for non-public too? They are automatically available under the staff url, when set to not public. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #13 from Liz Rea <liz@catalyst.net.nz> --- Ha, I originally had it as a link, but decided not to in the end because it was awkward when OPACBaseURL wasn't set. Plus you never click on it, you only ever use it in code, so not much reason to be clickable. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #14 from Liz Rea <liz@catalyst.net.nz> --- Regarding showing the non-public, that's fine. I'll do a catchall followup that does it how I want it to be done. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68619|0 |1 is obsolete| | Attachment #68620|0 |1 is obsolete| | Attachment #68621|0 |1 is obsolete| | --- Comment #15 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 68639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68639&action=edit Bug 16782 - disclose JSON URL for reports on the saved report page It has always annoyed me that you had to look at the help to divine the url for a report. This patch works it out and displays it for you in a new column on the saved reports table. Requirements: - OPACBaseURL and staffClientBaseURL preferences must be set for the urls to be complete. It's ok if they are not, but it's better if they are. - You must have a saved report that is public to your OPAC, and one that is not public. To test: - create a public saved report and a private staff report. They can be anything. - view the saved reports page, note that under a new heading of JSON URL the link to the json feed for that report shows. - copying and pasting that link into the address bar, or clicking it, should take you to the results of the selected report. sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display public report URL |Display report URL in staff |in staff client report |client report interface |interface | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68639|0 |1 is obsolete| | --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68648&action=edit Bug 16782 - disclose JSON URL for reports on the saved report page It has always annoyed me that you had to look at the help to divine the url for a report. This patch works it out and displays it for you in a new column on the saved reports table. Requirements: - OPACBaseURL and staffClientBaseURL preferences must be set for the urls to be complete. It's ok if they are not, but it's better if they are. - You must have a saved report that is public to your OPAC, and one that is not public. To test: - create a public saved report and a private staff report. They can be anything. - view the saved reports page, note that under a new heading of JSON URL the link to the json feed for that report shows. - copying and pasting that link into the address bar, or clicking it, should take you to the results of the selected report. sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #17 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 68649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68649&action=edit Bug 16782 - missing </td>, fixed now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #18 from Liz Rea <liz@catalyst.net.nz> --- Thankfully this still applies. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68648|0 |1 is obsolete| | Attachment #68649|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70322&action=edit Bug 16782 - disclose JSON URL for reports on the saved report page It has always annoyed me that you had to look at the help to divine the url for a report. This patch works it out and displays it for you in a new column on the saved reports table. Requirements: - OPACBaseURL and staffClientBaseURL preferences must be set for the urls to be complete. It's ok if they are not, but it's better if they are. - You must have a saved report that is public to your OPAC, and one that is not public. To test: - create a public saved report and a private staff report. They can be anything. - view the saved reports page, note that under a new heading of JSON URL the link to the json feed for that report shows. - copying and pasting that link into the address bar, or clicking it, should take you to the results of the selected report. sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70323&action=edit Bug 16782 - missing </td>, fixed now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70324&action=edit Bug 16782: (QA Followup) Use Koha.Preference for staffClientBaseURL and provide classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70395&action=edit Bug 16782: Use uri filter instead of html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #23 from Liz Rea <liz@catalyst.net.nz> --- You could have asked me to fix those things, I'd have been happy to. Thank you for the extra patches all the same. Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 --- Comment #26 from Liz Rea <liz@catalyst.net.nz> --- Hm, this'd be a feature not a bug. It's harmless but we should remember not to push features to stable branches. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #27 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16782 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display report URL in staff |Display JSON report URL in |client report interface |staff client report | |interface -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org