[Bug 41730] New: Automate change Withdrawn status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Bug ID: 41730 Summary: Automate change Withdrawn status when item is paid for Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org For many libraries, when a lost item is paid for the library does not want the item back -- it should not check in, it should not get marked found, it should not generate a lost fee refund. Functionally, the patron has purchased the book and gets to keep it (should they find it). It would be helpful for Koha to automatically apply a withdrawn status when an item is paid, similar to the UpdateItemLostStatusWhenPaid functionality added in Bug 22740. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192137&action=edit Bug 41730: Add ability to update item withdrawn status when lost item paid This patch implements a new system preference, "UpdateItemWithdrawnStatusWhenPaid" that allows you to specify the withdrawn status to change an item to when the outstanding balance of a lost item is paid. This preference is tied to the WITHDRAWN authorised values set. Test Plan: - Set one the system preference to any of the available values - Set an item as lost - Make a manual invoice for your desired user and assign it to the barcode of the above item - Save and Pay - Select Pay - Pay - Note that the withdrawn status of the item has changed to the status you set with the system preference - Check that when the system preference is left blank and no option is chosen, the withdrawn status does not update. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192138&action=edit Bug 41730: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41731 [Bug 41731] Automate change Withdrawn status when item is written off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Ray Delahunty <raymund.delahunty@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raymund.delahunty@outlook.c | |om --- Comment #3 from Ray Delahunty <raymund.delahunty@outlook.com> --- Attempted signoff, and everything looks OK in a biblibre sandbox (borrowernumber=19). Test plan 100%. Unable to return (for refund) item made 'Withdrawn- item lost' as (my new) WITHDARWN status. Unsure if I should signoff as log file reported an error. Bug 41730 - Automate change Withdrawn status when item is paid for 192137 - Bug 41730: Add ability to update item withdrawn status when lost item paid 192138 - Bug 41730: Unit tests Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 41730: Add ability to update item withdrawn status when lost item paid Applying: Bug 41730: Unit tests DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_41730.pl [11:08:24]: Bug 41730 - Add UpdateItemWithdrawnStatusWhenPaid [31mERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 2 at /kohadevbox/koha/C4/Installer.pm line 825 [0m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192252&action=edit Bug 41730: Correct SQL punctuation in atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192137|0 |1 is obsolete| | Attachment #192138|0 |1 is obsolete| | Attachment #192252|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192255&action=edit Bug 41730: Add ability to update item withdrawn status when lost item paid This patch implements a new system preference, "UpdateItemWithdrawnStatusWhenPaid" that allows you to specify the withdrawn status to change an item to when the outstanding balance of a lost item is paid. This preference is tied to the WITHDRAWN authorised values set. Test Plan: - Set one the system preference to any of the available values - Set an item as lost - Make a manual invoice for your desired user and assign it to the barcode of the above item - Save and Pay - Select Pay - Pay - Note that the withdrawn status of the item has changed to the status you set with the system preference - Check that when the system preference is left blank and no option is chosen, the withdrawn status does not update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192256&action=edit Bug 41730: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192255|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192263&action=edit Bug 41730: Add ability to update item withdrawn status when lost item paid This patch implements a new system preference, "UpdateItemWithdrawnStatusWhenPaid" that allows you to specify the withdrawn status to change an item to when the outstanding balance of a lost item is paid. This preference is tied to the WITHDRAWN authorised values set. Test Plan: - Set one the system preference to any of the available values - Set an item as lost - Make a manual invoice for your desired user and assign it to the barcode of the above item - Save and Pay - Select Pay - Pay - Note that the withdrawn status of the item has changed to the status you set with the system preference - Check that when the system preference is left blank and no option is chosen, the withdrawn status does not update. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192256|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 192264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192264&action=edit Bug 41730: Unit tests Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192263|0 |1 is obsolete| | --- Comment #9 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 192269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192269&action=edit Bug 41730: Add ability to update item withdrawn status when lost item paid This patch implements a new system preference, "UpdateItemWithdrawnStatusWhenPaid" that allows you to specify the withdrawn status to change an item to when the outstanding balance of a lost item is paid. This preference is tied to the WITHDRAWN authorised values set. Test Plan: - Set one the system preference to any of the available values - Set an item as lost - Make a manual invoice for your desired user and assign it to the barcode of the above item - Save and Pay - Select Pay - Pay - Note that the withdrawn status of the item has changed to the status you set with the system preference - Check that when the system preference is left blank and no option is chosen, the withdrawn status does not update. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Ray <raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192264|0 |1 is obsolete| | --- Comment #10 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 192270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192270&action=edit Bug 41730: Unit tests Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Ray <raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41730 --- Comment #11 from Ray Delahunty <raymund.delahunty@outlook.com> --- The test plan worked just fine, and I added a signoff, but as part of the test I did break the rule that WITHDRAWN authorised values must be numerical, when I created a new value for it. Then (as I expected) the change was not made. I’m tempted to add a new bug suggesting that the Description field in the Authorised value screen mentions the numerical requirement, while we wait for a fix to Bug 27512 - Block creation of invalid authorised values for LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN. Just a thought… -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org