[Bug 39087] New: Some files are uglier when tidy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39087 Bug ID: 39087 Summary: Some files are uglier when tidy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 38664 koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.csv.inc koha-tmpl/intranet-tmpl/prog/en/includes/catalogue/itemsearch_item.json.inc a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/* Not a big deal IMO as those files are wrong anyway (we should not build json or csv using TT) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 [Bug 38664] Tidy the whole codebase -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39087 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39087 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #0)
Not a big deal IMO as those files are wrong anyway (we should not build json or csv using TT)
+1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39087 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the problem has been the bits that we need translatable, like header rows and "summary" and "by" between title and author. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39087 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #2)
I think the problem has been the bits that we need translatable, like header rows and "summary" and "by" between title and author.
Yes, and we have Koha::I18N for that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39087 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39112 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39087 Bug 39087 depends on bug 38664, which changed state. Bug 38664 Summary: Tidy the whole codebase https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org