[Bug 9651] New: When deleting a fund, button is wrongly labelled with 'Delete this budget'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9651 Bug ID: 9651 Summary: When deleting a fund, button is wrongly labelled with 'Delete this budget' Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de Created attachment 15441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15441&action=edit screenshot To reproduce: 1) Create a budget 2) Create a fund for it 3) Click on delete link in list of funds 4) Check confirmation message says: Delete fund XXX? Delete this budget. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9651 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9651 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15466&action=edit Bug 9651 - When deleting a fund, button is wrongly labelled with 'Delete this budget' This patch change legends to approve/cancel deletion of a fund. Changed to Delete/Cancel, same messages to delete a Budget. To test: 1) When deleting a fund, confirmation messages said: 'Delete this budget XXX?' to approve 'No, do not delete' to cancel 2) Apply the patch 3) Now the messages are 'Delete'/'Cancel' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9651 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9651 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9651 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15466|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15489&action=edit [SIGNED-OFF] Bug 9651 - When deleting a fund, button is wrongly labelled with 'Delete this budget' This patch change legends to approve/cancel deletion of a fund. Changed to Delete/Cancel, same messages to delete a Budget. To test: 1) When deleting a fund, confirmation messages said: 'Delete this budget XXX?' to approve 'No, do not delete' to cancel 2) Apply the patch 3) Now the messages are 'Delete'/'Cancel' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works perfectly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9651 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |String patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Ergonomic improvement on deleting a fund (same as the confirmation message on deleting a budget). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9651 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15489|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15535&action=edit Bug 9651 - When deleting a fund, button is wrongly labelled with 'Delete this budget' This patch change legends to approve/cancel deletion of a fund. Changed to Delete/Cancel, same messages to delete a Budget. To test: 1) When deleting a fund, confirmation messages said: 'Delete this budget XXX?' to approve 'No, do not delete' to cancel 2) Apply the patch 3) Now the messages are 'Delete'/'Cancel' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works perfectly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9651 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9651 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org