[Bug 28762] New: Item status shows incorrectly on course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Bug ID: 28762 Summary: Item status shows incorrectly on course-details.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: - create a course in course reserves, add an item to it. - confirm your item shows Available for its status on course-details.pl - edit your item to be withdrawn, lost, damaged, notforloan, and restricted use - reload course-details.pl, confirm it still shows available filed bug 28761 for this on the OPAC. On the OPAC, withdrawn, lost, and damaged *do* update the status. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 123233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123233&action=edit Bug 28762: Handle different item statuses in course details To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl https://bugs.koha-community.org/show_bug.cgi?id=28761 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123233|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 123234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123234&action=edit Bug 28762: add staff item-status.inc and better handle statues on course-details.tt This patch adds an item-status.inc to the staff side much like what is already in place on the OPAC. To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 123236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123236&action=edit Bug 28762: handle notforloan better -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123236|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 123237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123237&action=edit Bug 28762: handle notforloan better -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham@catalyst.net.n | |z Status|Needs Signoff |Failed QA --- Comment #5 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Hi Lucas, I can confirm that the patch fixes the Status of the course reserve item to show whether it is withdrawn, damaged, etc. However, if it is none of those, the status column no longer shows Available, but instead is blank. I am assuming it should say available if none of those values you listed are true? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 124661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124661&action=edit Bug 28762: (follow-up) fix template logic with Available -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Hayley Pelham from comment #5)
Hi Lucas,
I can confirm that the patch fixes the Status of the course reserve item to show whether it is withdrawn, damaged, etc.
However, if it is none of those, the status column no longer shows Available, but instead is blank.
I am assuming it should say available if none of those values you listed are true?
Cheers, Hayley
Thanks Haley! I am have made a correction and I am reseting the status of this one to 'Needs sign-off' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123234|0 |1 is obsolete| | Attachment #123237|0 |1 is obsolete| | Attachment #124661|0 |1 is obsolete| | --- Comment #8 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Created attachment 124666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124666&action=edit Bug 28762: add staff item-status.inc and better handle statues on course-details.tt This patch adds an item-status.inc to the staff side much like what is already in place on the OPAC. To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #9 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Created attachment 124667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124667&action=edit Bug 28762: handle notforloan better Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #10 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Created attachment 124668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124668&action=edit Bug 28762: (follow-up) fix template logic with Available Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- My concern here is introducing a item-status.inc that will be deviating from the opac version quite a bit already. Thinking about how we could keep them together. Maybe a few more lines here or there, but if they could be the same? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 124744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124744&action=edit Bug 28762: (QA follow-up) A first attempt to sync the includes This is just a start. Should we resolve all differences? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |In Discussion CC| |jonathan.druart+koha@gmail. | |com --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Jonathan: What do you think? Get the includes correct here and enforce synced changes or just push them while different, and hope to keep them closer? ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Obviously you would need to pass staff => 1 now too in the course reserves page in staff client.. If we go this direction? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #14)
Jonathan: What do you think? Get the includes correct here and enforce synced changes or just push them while different, and hope to keep them closer? ;)
Hard call, I don't think we should have them all in sync. Maybe we could have a 'common' directory with some include files that would be identically both sides? We even could have a test to ensure it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- + [% IF ( OPACShowCheckoutName ) %] this is wrong for staff, there is no test on "opac". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #17)
+ [% IF ( OPACShowCheckoutName ) %]
this is wrong for staff, there is no test on "opac".
Yeah. I did not finish this sync operation. But wanted to get some discussion first. It should be possible to add some opac/staff checks and have them exactly identical. But it might be to hard to require that here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124744|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 124744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124744 Bug 28762: (QA follow-up) A first attempt to sync the includes Coming here again, I think we are asking too much when insisting on a synced item status include. So I am obsoleting this follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- So from this perspective looking at a new include, I see things like: [% IF item.isa('Koha::Item') %] .. [% IF NOT ( item.isa('Koha::Item') ) AND item.transfertwhen %] Which is awful. Yes, I know that it comes from the opac include, but we should really solve its twisted usage. When we are starting at staff here, please use one consistent approach. Either always pass a Koha object, or do something else. But keep it consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Changing status for comment17 and comment20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29095 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 29095 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, this certainly needs some work.. if we're going to introduce an 'item-status' include here I feel it should really be re-usable and simple/clear. For that to be the case we should really be expecting a simple 'item' object to be passed and not deal with special cases for weird structures. I propose updating the minimal controller to use Koha:: Objects instead of C4:: classes and methods for these item details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125220&action=edit Bug 28762: Use Koha::Course in course-details controller This patch updates Koha::Course to include the 'instructors' relation accessor and then update the course-details controller to use the Koha::Course object and pass it to the template instead of building a hash using GetCourse. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- My follow-up should allow us to switch out the `isa` in the template include now I believe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125228&action=edit Bug 28762: Update item-status include This patch updates the item-status include so that it expects just an item object making if simpler and more widely re-usable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125228|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125229&action=edit Bug 28762: Update item-status include This patch updates the item-status include so that it expects just an item object making if simpler and more widely re-usable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The include here was heavily inspired by the opac equivalent, the status cell of the holdings table in catalogue/detail.tt and the equivalent include included in bug 28854/bug 24023. What I'm least familiar with here is holds and independent branches, so please test that area carefully. The challenge is holds in the holds table vs holds in the tmp_holdsqueue.. they have different cases but I think I've handled both. As for IndependantBranches.. there's some really funky code in catalogue/details and GetItemInfo that deals with that.. we should be moving to Koha::Item objects in catalogue/details as soon as possible with this patch in my opinion.. but I feel that area may need some work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125233&action=edit Bug 28762: Move notforloan fallback into object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #30 from Kelly McElligott <kelly@bywatersolutions.com> --- Upon testing this, I found that the Not for Loan status was not showing accurately in the Course Reserve table on the OPAC. Testing for the status availability is correct on Staff Interface. A not-for-loan status shows available regardless of what is chosen (Ordered, Staff Collection, Not for Loan) in the Course Reserve table on the OPAC. Looking at the specific item within the OPAC, the not-for-loan status is showing correctly- specifically, it is using what is on the Authorized Value OPAC description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Dani Elder <danielle.elder@law.utexas.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder@law.utexas.e | |du -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #31 from Dani Elder <danielle.elder@law.utexas.edu> --- It would be nice if the course reserves status would show in course reserves. When items are long long over due this keeps staff from hunting down a book that may look available in the staff interface. They can toggle to the opac to check, but they shouldn't have to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124666|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161563&action=edit Bug 28762: add staff item-status.inc and better handle statues on course-details.tt This patch adds an item-status.inc to the staff side much like what is already in place on the OPAC. To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124667|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161564&action=edit Bug 28762: handle notforloan better Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124668|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161565&action=edit Bug 28762: (follow-up) fix template logic with Available Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125220|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161566&action=edit Bug 28762: Use Koha::Course in course-details controller This patch updates Koha::Course to include the 'instructors' relation accessor and then update the course-details controller to use the Koha::Course object and pass it to the template instead of building a hash using GetCourse. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125229|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161567&action=edit Bug 28762: Update item-status include This patch updates the item-status include so that it expects just an item object making if simpler and more widely re-usable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125233|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161568&action=edit Bug 28762: Move notforloan fallback into object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161563|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161569&action=edit Bug 28762: add staff item-status.inc and better handle statues on course-details.tt This patch adds an item-status.inc to the staff side much like what is already in place on the OPAC. To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161564|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161570&action=edit Bug 28762: handle notforloan better Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161565|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161571&action=edit Bug 28762: (follow-up) fix template logic with Available Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161566|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161572&action=edit Bug 28762: Use Koha::Course in course-details controller This patch updates Koha::Course to include the 'instructors' relation accessor and then update the course-details controller to use the Koha::Course object and pass it to the template instead of building a hash using GetCourse. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161567|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161573&action=edit Bug 28762: Update item-status include This patch updates the item-status include so that it expects just an item object making if simpler and more widely re-usable. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161568|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161574&action=edit Bug 28762: Move notforloan fallback into object Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161569|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161584&action=edit Bug 28762: add staff item-status.inc and better handle statues on course-details.tt This patch adds an item-status.inc to the staff side much like what is already in place on the OPAC. To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161570|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161585&action=edit Bug 28762: handle notforloan better Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161571|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161586&action=edit Bug 28762: (follow-up) fix template logic with Available Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161572|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161587&action=edit Bug 28762: Use Koha::Course in course-details controller This patch updates Koha::Course to include the 'instructors' relation accessor and then update the course-details controller to use the Koha::Course object and pass it to the template instead of building a hash using GetCourse. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161573|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161588&action=edit Bug 28762: Update item-status include This patch updates the item-status include so that it expects just an item object making if simpler and more widely re-usable. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161574|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161589&action=edit Bug 28762: Move notforloan fallback into object Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161590&action=edit Bug 28762: Add test for new 'instructors' accessor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161591&action=edit Bug 28762: Unit tests for not_for_loan accessor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161584|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163310&action=edit Bug 28762: add staff item-status.inc and better handle statues on course-details.tt This patch adds an item-status.inc to the staff side much like what is already in place on the OPAC. To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161585|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163311&action=edit Bug 28762: handle notforloan better Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161586|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163312&action=edit Bug 28762: (follow-up) fix template logic with Available Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161587|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163313&action=edit Bug 28762: Use Koha::Course in course-details controller This patch updates Koha::Course to include the 'instructors' relation accessor and then update the course-details controller to use the Koha::Course object and pass it to the template instead of building a hash using GetCourse. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161588|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163314&action=edit Bug 28762: Update item-status include This patch updates the item-status include so that it expects just an item object making if simpler and more widely re-usable. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161589|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163315&action=edit Bug 28762: Move notforloan fallback into object Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161590|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163316&action=edit Bug 28762: Add test for new 'instructors' accessor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161591|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163317&action=edit Bug 28762: Unit tests for not_for_loan accessor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another rebase done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #61 from Victor Grousset/tuxayo <victor@tuxayo.net> --- there might be an issue found in comment 30 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #61)
there might be an issue found in comment 30
This patchset only touches the staff client and the comment appears to say the results here are correct. I think if we want to sync the OPAC back to follow the logic here we should do that in a follow-up bug rather than hold this patch back any longer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163310|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165843&action=edit Bug 28762: add staff item-status.inc and better handle statues on course-details.tt This patch adds an item-status.inc to the staff side much like what is already in place on the OPAC. To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163311|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165844&action=edit Bug 28762: handle notforloan better Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163312|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165845&action=edit Bug 28762: (follow-up) fix template logic with Available Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163313|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165846&action=edit Bug 28762: Use Koha::Course in course-details controller This patch updates Koha::Course to include the 'instructors' relation accessor and then update the course-details controller to use the Koha::Course object and pass it to the template instead of building a hash using GetCourse. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163314|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165847&action=edit Bug 28762: Update item-status include This patch updates the item-status include so that it expects just an item object making if simpler and more widely re-usable. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163315|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165848&action=edit Bug 28762: Move notforloan fallback into object Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163316|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165849&action=edit Bug 28762: Add test for new 'instructors' accessor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163317|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165850&action=edit Bug 28762: Unit tests for not_for_loan accessor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just another quick rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Still looking here Marcel? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #73 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #72)
Still looking here Marcel?
Feel free to take over if I didnt touch it very recently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I've reset the assignee. Can't take it on for QA as it looks like I was heavily involved in it's development in the end. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #75 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 169172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169172&action=edit Bug 28762: (QA follow-up): fix number of tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #76 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Fixed number of tests mismatching and causing a failure. (maybe we put the number of tests for a reason and not just to fix it blindly?) --- Are the diag("item-level_itypes: 0"); and diag("item-level_itypes: 1"); still needed? (removed from QA queue pending the two previous points) ---- string change looks good 👍 +msgid "Lost" +msgid "Due: %s" +msgid "Pending hold" +msgid "Waiting at %s since %s." +msgid "Item-level hold (placed %s) for delivery at %s." +msgid "Restricted" -msgid "Restricted" -msgid "Lost" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Those 'diag' might be better as 'note' but I do like them in as I find they split up the output of a prove -vv more clearly personally.. I'm not especially worried though if you want them removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165843|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169273&action=edit Bug 28762: add staff item-status.inc and better handle statues on course-details.tt This patch adds an item-status.inc to the staff side much like what is already in place on the OPAC. To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165844|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169274&action=edit Bug 28762: handle notforloan better Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165845|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169275&action=edit Bug 28762: (follow-up) fix template logic with Available Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165846|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169276&action=edit Bug 28762: Use Koha::Course in course-details controller This patch updates Koha::Course to include the 'instructors' relation accessor and then update the course-details controller to use the Koha::Course object and pass it to the template instead of building a hash using GetCourse. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165847|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169277&action=edit Bug 28762: Update item-status include This patch updates the item-status include so that it expects just an item object making if simpler and more widely re-usable. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165848|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169278&action=edit Bug 28762: Move notforloan fallback into object Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165849|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169279&action=edit Bug 28762: Add test for new 'instructors' accessor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165850|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169280&action=edit Bug 28762: Unit tests for not_for_loan accessor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169281&action=edit Bug 28762: (follow-up) Remove warning in tests Looks like a recent bug introduced a superflous warning, we just clean that up here whilst we're in the code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #76)
Fixed number of tests mismatching and causing a failure. (maybe we put the number of tests for a reason and not just to fix it blindly?)
Rebase error introduced the count discrepancy.. just fixing the number was the right thing to do.. I've rebased it now anyway.
---
Are the diag("item-level_itypes: 0"); and diag("item-level_itypes: 1");
Replaced with 'note' which makes the tests quieter Added a follow-up to clean up a superfluous warning introduced in another patch recently pushed.. no reason not to whilst were in the code. Back to NQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169311&action=edit Bug 28762: Confirm return of not_for_loan in boolean context matches is_notforloan This patch is simply here to prove that is_notforloan is just not_for_loan but in a boolean context.. we'll remove it in the next patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169312&action=edit Bug 28762: Replace is_notforloan with not_for_loan This patch replaces the use of is_notforloan with not_for_loan and removes the older is_notforloan method and tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169313&action=edit Bug 28762: Rename not_for_loan as effective_not_for_loan_status This patch updates the method name to follow current conventions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Last three patches can happily be squashed.. they were submitted distinctly to help QA follow the flow of events. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169313|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169314&action=edit Bug 28762: Rename not_for_loan as effective_not_for_loan_status This patch updates the method name to follow current conventions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169172|0 |1 is obsolete| | --- Comment #93 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169354&action=edit Bug 28762: (QA follow-up): fix number of tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169273|0 |1 is obsolete| | --- Comment #94 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169355&action=edit Bug 28762: add staff item-status.inc and better handle statues on course-details.tt This patch adds an item-status.inc to the staff side much like what is already in place on the OPAC. To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169274|0 |1 is obsolete| | --- Comment #95 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169356&action=edit Bug 28762: handle notforloan better Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169275|0 |1 is obsolete| | --- Comment #96 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169357&action=edit Bug 28762: (follow-up) fix template logic with Available Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169276|0 |1 is obsolete| | --- Comment #97 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169358&action=edit Bug 28762: Use Koha::Course in course-details controller This patch updates Koha::Course to include the 'instructors' relation accessor and then update the course-details controller to use the Koha::Course object and pass it to the template instead of building a hash using GetCourse. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169277|0 |1 is obsolete| | --- Comment #98 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169359&action=edit Bug 28762: Update item-status include This patch updates the item-status include so that it expects just an item object making if simpler and more widely re-usable. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169278|0 |1 is obsolete| | --- Comment #99 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169360&action=edit Bug 28762: Move notforloan fallback into object Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169279|0 |1 is obsolete| | --- Comment #100 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169361&action=edit Bug 28762: Add test for new 'instructors' accessor Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169280|0 |1 is obsolete| | --- Comment #101 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169362&action=edit Bug 28762: Unit tests for not_for_loan accessor Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169281|0 |1 is obsolete| | --- Comment #102 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169363&action=edit Bug 28762: (follow-up) Remove warning in tests Looks like a recent bug introduced a superflous warning, we just clean that up here whilst we're in the code. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169311|0 |1 is obsolete| | --- Comment #103 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169364&action=edit Bug 28762: Confirm return of not_for_loan in boolean context matches is_notforloan This patch is simply here to prove that is_notforloan is just not_for_loan but in a boolean context.. we'll remove it in the next patch. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169312|0 |1 is obsolete| | --- Comment #104 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169365&action=edit Bug 28762: Replace is_notforloan with not_for_loan This patch replaces the use of is_notforloan with not_for_loan and removes the older is_notforloan method and tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169314|0 |1 is obsolete| | --- Comment #105 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169366&action=edit Bug 28762: Rename not_for_loan as effective_not_for_loan_status This patch updates the method name to follow current conventions. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #106 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 169367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169367&action=edit Bug 28762: (QA follow-up) Restore protection against unknown itemtypes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #107 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Wait! ILSDI_Services.t fails (found while trying to check if the minor change in C4/ILSDI/Services.pm is covered (likely is)) kohadev-koha@kohadevbox:koha(testing-SO-QA)$ prove t/db_dependent/ILSDI_Services.t t/db_dependent/ILSDI_Services.t .. 12/14 # No tests run! # Failed test 'No tests run for subtest "GetAvailability itemcallnumber"' # at t/db_dependent/ILSDI_Services.t line 1045. The method Koha::Item->effective_notforloan is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 971 Koha::Object::AUTOLOAD('Koha::Item=HASH(0x57fb9279d480)') called at /kohadevbox/koha/C4/ILSDI/Services.pm line 973 C4::ILSDI::Services::_availability(989) called at /kohadevbox/koha/C4/ILSDI/Services.pm line 122 C4::ILSDI::Services::GetAvailability('CGI=HASH(0x57fb901401d8)') called at t/db_dependent/ILSDI_Services.t line 1000 main::__ANON__ at /usr/share/perl/5.28/Test/Builder.pm line 339 eval {...} at /usr/share/perl/5.28/Test/Builder.pm line 339 Test::Builder::subtest('Test::Builder=HASH(0x57fb87b01678)', 'GetAvailability itemcallnumber', 'CODE(0x57fb92334470)') called at /usr/share/perl/5.28/Test/More.pm line 807 Test::More::subtest('GetAvailability itemcallnumber', 'CODE(0x57fb92334470)') called at t/db_dependent/ILSDI_Services.t line 1045 # Looks like your test exited with 255 just after 13. t/db_dependent/ILSDI_Services.t .. Dubious, test returned 255 (wstat 65280, 0xff00) ----- Thanks Nick for QAing the rest that was out of my reach 👍 ---- (In reply to Martin Renvoize from comment #77)
Those 'diag' might be better as 'note' but I do like them in as I find they split up the output of a prove -vv more clearly personally.. I'm not especially worried though if you want them removed.
Nice, good to know about the difference between diag and note. No problem to have these, just needed to be sure it wasn't forgotten. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169393&action=edit Bug 28762: (follow-up) Fix missed not_for_loan_status rename -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37453 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37453 [Bug 37453] The new item-status.inc include should be used throughout the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.04 released in| | Status|Pushed to main |Pushed to stable --- Comment #110 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #111 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oh big changes, I prefer not impact oldstable 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |david@davidnind.com --- Comment #112 from David Nind <david@davidnind.com> --- Bug fix, no change to UI, no changes required to the documentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37334 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40053 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40053 [Bug 40053] Koha::Item->effective_not_for_loan_status incorrect? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org