[Bug 16659] New: Add the possibility to search for multiple branches (libraries) or groups in the advanced search in the opac and the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16659 Bug ID: 16659 Summary: Add the possibility to search for multiple branches (libraries) or groups in the advanced search in the opac and the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: gaetan.boisson@biblibre.com QA Contact: testopia@bugs.koha-community.org At the moment, in advanced search it is possible to pre-select a library to filter results on. However we can only select one library at a time. This patch will allow users to select multiple libraries. It would be consistent with the current interface to add this feature as a tab, next to item types, locations, and collection codes, with multiple checkboxes. While we need to keep the feature of searching a group of libraries, if we make it possible to check libraries in the first part of the form and keep the dropdown menu, conflicts will arise between choices made in the two parts of the form. For this reason the dropdown menu will be removed, and library groups will appear along libraries in the checkboxes. Right now, the interface groups "location and availability" under the same title. We will only keep availability as a checkbox here. In advanced search if the searchmylibraryfirst system preference is activated, the library of the logged in patron is preselected in the dropdown menu. We need to keep the functionality by checking the appropriate box in the new form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16659 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16659 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16659 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52029&action=edit Bug 16659: Add the possibility to search for multiple branches At the moment, in advanced search it is possible to pre-select a library to filter results on. However we can only select one library at a time. This patch will allow users to select multiple libraries. This patch replaces the dropdown list of libraries with inputs to make several libraries searchable. Note that this patch is a bit ugly and is only for demo purpose. And also only work on the intranet interface. Test plan: 1/ Go to the adv search form 2/ Select 1 or more libraries ticking the checkboxes 3/ Make sure the results are consistent. 4/ When 1 or more checkboxes are checked, the dropdown list of group of libraries should be disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16659 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- It's great works perfectly! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16659 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52029|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 52030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52030&action=edit [SIGNED OFF] Bug 16659: Add the possibility to search for multiple branches At the moment, in advanced search it is possible to pre-select a library to filter results on. However we can only select one library at a time. This patch will allow users to select multiple libraries. This patch replaces the dropdown list of libraries with inputs to make several libraries searchable. Note that this patch is a bit ugly and is only for demo purpose. And also only work on the intranet interface. Test plan: 1/ Go to the adv search form 2/ Select 1 or more libraries ticking the checkboxes 3/ Make sure the results are consistent. 4/ When 1 or more checkboxes are checked, the dropdown list of group of libraries should be disabled Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16659 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 52030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52030 [SIGNED OFF] Bug 16659: Add the possibility to search for multiple branches Review of attachment 52030: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16659&attachment=52030) ----------------------------------------------------------------- Patch is a good start, but... ::: catalogue/search.pl @@ +406,5 @@
+my @branch = map uri_unescape($_), $cgi->multi_param('branch'); +if( @branch ) { + push @limits, '(' . join (" or ", map {'branch: ' . $_ } @branch ) . ')'; +} +
You should do this differently... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16659 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- some comment with good reasons and helpful ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16659 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- This bug was used to demo the community workflow for contributing to koha. Its content can be ignored. Bug 16663 has been opened to manage this feature request specifically. *** This bug has been marked as a duplicate of bug 16663 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org