https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168285&action=edit Bug 37222: Standardize markup for sidebar menus This patch updates sidebar menu markup so that it's consistent, with a common class (".sidebar_menu") and a unique ID. The style is tied to the class rather than the ID, simplifying the CSS. Note: This patch contains indentation changes so ignore whitespace when viewing the diff. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check pages which contain each modified menu: - Circulation -> Check out to a patron - Catalog -> View a bibliographic record - Administration -> View system preferences - Acquisitions -> Acquisitions home - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation - Cataloging -> Stage MARC records for import - Reports -> Acquisitions statistics - Reports -> View dictionary - Point of sale - E-resource management - Preservation - Serials - Tools -> Patron lists Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> ---

From my testing, the sidebar menu items are not highlighted when you are on the respective page, or a page related to that menu area.

Here are my initial notes for each area I checked: - Circulation > Check out to a patron: is a bullet pointed list without styling - Catalog > View a bibliographic record: OK - Administration > View system preferences: selected group does not have a light background for sections - Acquisitions > Acquisitions home: Acquisitions home not highlighted - Cataloging > Stock rotation > Manage stages and manage items for a rotation: . Stock rotation sidebar menu item not highlighted . When on other pages (Manage stages, Manage items), those are highlighted as expected at the top of the sidebar menu, but stock rotation further down the sidebar isn't (it is highlighted before the patch) - Cataloging > Stage MARC records for import: Stage records for import sidebar menu item not highlighted (same for Managed staged records sidebar menu item) - Reports > Acquisitions statistics: sidebar menu item not highlighted, and not highlighted on the report results page (same for other reports) - Reports > View dictionary: sidebar menu item not highlighted - Point of sale: sidebar menu items not highlighted - E-resource management: tree of sub menu items not indented - Preservation: seems OK, but I didn't add any data - Serials: seems OK - Tools > Patron lists: sidebar menu items not highlighted Happy to add some screenshots if that would make it easy to understand my notes. Testing notes (using KTD): 1. Rebuild the CSS and JS: yarn build 2. Enable these system preferences (and add appropriate data): - StockRotation: add a rota and items to the rota - ERMModule - PreservationModule - EnablePointOfSale - UseCashRegisters (and add a cash register) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168285|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168560&action=edit Bug 37222: Standardize markup for sidebar menus This patch updates sidebar menu markup so that it's consistent, with a common class (".sidebar_menu") and a unique ID. The style is tied to the class rather than the ID, simplifying the CSS. Note: This patch contains indentation changes so ignore whitespace when viewing the diff. The updated patch contains corrections to JavaScript which needed selectors to be changed to match the new markup. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check pages which contain each modified menu: - Circulation -> Check out to a patron - Catalog -> View a bibliographic record - Administration -> View system preferences - Acquisitions -> Acquisitions home - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation - Cataloging -> Stage MARC records for import - Reports -> Acquisitions statistics - Reports -> View dictionary - Point of sale - E-resource management - Preservation - Serials - Tools -> Patron lists Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Owen! I've had another go at testing. These items remain: 1. Circulation > Check out to a patron: I went to Circulation from the home page, then "Check out" from the circulation page. The sidebar menu is still a bulleted list without styling - this is the same for all other areas of Circulation where the sidebar menu is displayed: . In the patch, I can't match the before markup (<div id="menu">) with what is on the actual page HTML before the patch is applied . In the patch, the updated markup is: <div id="circ-menu" class="sidebar_menu"> . On the page after the patch is applied, the markup is: <div id="circ-menu"> (both for Firefox and Chromium) 2. Administration > View system preferences: no change from previous testing - the section you are on (such as Administration) does not have a light background for the sub sidebar menu options for that section (for example - CAS authentication to Share anonymous usage statistics has the normal gray background, not the light gray background). (As an aside, I think I preferred the way it was before the theme update - with the submenus aligned to the right and the same text size as the group heading.) 3. Cataloging > Stock rotation > Manage stages and manage items for a rotation: . When on other pages (Manage stages, Manage items), those are highlighted as expected at the top of the sidebar menu, but stock rotation further down the sidebar isn't (it was highlighted before the patch). Other areas - either fixed or the same behavour as before the patch =================================================================== - Catalog > View a bibliographic record: OK - Acquisitions > Acquisitions home: OK and improvements (when on vendor page, highlights appropriate vendor sidebar menu items - didn't before) (fixed - Acquisitions home not highlighted): . Note that while the behavour remains the same for the vendor sidebar menu, it is a little inconsistent, but outside the scope of this bug I think: . Baskets: displays vendor sidebar menu + the full sidebar menu . Basket groups: displays vendor sidebar menu + the full sidebar menu . Contracts: vendor sidebar menu disappears, and displays the full sidebar menu . Vendor issues: only shows the vendor sidebar menu . Invoices: vendor sidebar menu disappears, and displays the search filters and the full sidebar menu with Invoices highlighted . Uncertain prices: only shows the vendor sidebar menu - Cataloging > Stage MARC records for import: OK (fixed - Stage records for import sidebar menu item not highlighted (same for Managed staged records sidebar menu item)) - Reports > Acquisitions statistics: OK (fixed - sidebar menu item not highlighted, and not highlighted on the report results page (same for other reports)) - Reports > View dictionary: OK (fixed - sidebar menu item not highlighted) - Point of sale: OK (fixed - sidebar menu items not highlighted) - E-resource management: OK (fixed - tree of sub menu items not indented) - Preservation: seems OK, but I didn't add any data - Serials: OK - Tools > Patron lists: OK (fixed - sidebar menu items not highlighted) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168562|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168595&action=edit Bug 37222: Standardize markup for sidebar menus This patch updates sidebar menu markup so that it's consistent, with a common class (".sidebar_menu") and a unique ID. The style is tied to the class rather than the ID, simplifying the CSS. Note: This patch contains indentation changes so ignore whitespace when viewing the diff. The updated patch contains corrections to JavaScript which needed selectors to be changed to match the new markup. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check pages which contain each modified menu: - Circulation -> Check out to a patron - Catalog -> View a bibliographic record - Administration -> View system preferences - Acquisitions -> Acquisitions home - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation - Cataloging -> Stage MARC records for import - Reports -> Acquisitions statistics - Reports -> View dictionary - Point of sale - E-resource management - Preservation - Serials - Tools -> Patron lists Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169426|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 169739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169739&action=edit Bug 37222: Standardize markup for sidebar menus This patch updates sidebar menu markup so that it's consistent, with a common class (".sidebar_menu") and a unique ID. The style is tied to the class rather than the ID, simplifying the CSS. Note: This patch contains indentation changes so ignore whitespace when viewing the diff. The updated patch contains corrections to JavaScript which needed selectors to be changed to match the new markup. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check pages which contain each modified menu: - Circulation -> Check out to a patron - Catalog -> View a bibliographic record - Administration -> View system preferences - Acquisitions -> Acquisitions home - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation - Cataloging -> Stage MARC records for import - Reports -> Acquisitions statistics - Reports -> View dictionary - Point of sale - E-resource management - Preservation - Serials - Tools -> Patron lists Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169739|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170640&action=edit Bug 37222: Standardize markup for sidebar menus This patch updates sidebar menu markup so that it's consistent, with a common class (".sidebar_menu") and a unique ID. The style is tied to the class rather than the ID, simplifying the CSS. Note: This patch contains indentation changes so ignore whitespace when viewing the diff. The updated patch contains corrections to JavaScript which needed selectors to be changed to match the new markup. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check pages which contain each modified menu: - Circulation -> Check out to a patron - Catalog -> View a bibliographic record - Administration -> View system preferences - Acquisitions -> Acquisitions home - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation - Cataloging -> Stage MARC records for import - Reports -> Acquisitions statistics - Reports -> View dictionary - Point of sale - E-resource management - Preservation - Serials - Tools -> Patron lists Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Sukhmandeep <sukhmandeep.benipal@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170997|0 |1 is obsolete| | --- Comment #13 from Sukhmandeep <sukhmandeep.benipal@inLibro.com> --- Created attachment 171151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171151&action=edit Bug 37222: Standardize markup for sidebar menus This patch updates sidebar menu markup so that it's consistent, with a common class (".sidebar_menu") and a unique ID. The style is tied to the class rather than the ID, simplifying the CSS. Note: This patch contains indentation changes so ignore whitespace when viewing the diff. The updated patch contains corrections to JavaScript which needed selectors to be changed to match the new markup. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check pages which contain each modified menu: - Circulation -> Check out to a patron - Catalog -> View a bibliographic record - Administration -> View system preferences - Acquisitions -> Acquisitions home - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation - Cataloging -> Stage MARC records for import - Reports -> Acquisitions statistics - Reports -> View dictionary - Point of sale - E-resource management - Preservation - Serials - Tools -> Patron lists Sponsored-by: Athens County Public Libraries Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171151|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173971&action=edit Bug 37222: Standardize markup for sidebar menus This patch updates sidebar menu markup so that it's consistent, with a common class (".sidebar_menu") and a unique ID. The style is tied to the class rather than the ID, simplifying the CSS. Note: This patch contains indentation changes so ignore whitespace when viewing the diff. The updated patch contains corrections to JavaScript which needed selectors to be changed to match the new markup. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check pages which contain each modified menu: - Circulation -> Check out to a patron - Catalog -> View a bibliographic record - Administration -> View system preferences - Acquisitions -> Acquisitions home - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation - Cataloging -> Stage MARC records for import - Reports -> Acquisitions statistics - Reports -> View dictionary - Point of sale - E-resource management - Preservation - Serials - Tools -> Patron lists Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Everything looks right except in ERM and Preservation modules. There I am seeing an extra pseudo element (::after) making things look a bit off: .breadcrumb-item + .breadcrumb-item::before { background: transparent url("data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIxNiIgaGVpZ2h0PSIxNiIgZmlsbD0iY3VycmVudENvbG9yIiBjbGFzcz0iYmkgYmktY2hldnJvbi1yaWdodCI+PHBhdGggZmlsbC1ydWxlPSJldmVub2RkIiBkPSJNNy4zNyAwbDUuMzUgNy4zYy4yLjIuMi41MSAwIC43bC01LjM4IDhoLTQuMmw1LjY0LTguMzVMMy4xMy4wMXoiLz48L3N2Zz4=") 50% 50% no-repeat; If I remove this CSS it looks right. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174477|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175333&action=edit Bug 37222: Standardize markup for sidebar menus This patch updates sidebar menu markup so that it's consistent, with a common class (".sidebar_menu") and a unique ID. The style is tied to the class rather than the ID, simplifying the CSS. Note: This patch contains indentation changes so ignore whitespace when viewing the diff. The updated patch contains corrections to JavaScript which needed selectors to be changed to match the new markup. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check pages which contain each modified menu: - Circulation -> Check out to a patron - Catalog -> View a bibliographic record - Administration -> View system preferences - Acquisitions -> Acquisitions home - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation - Cataloging -> Stage MARC records for import - Reports -> Acquisitions statistics - Reports -> View dictionary - Point of sale - E-resource management - Preservation - Serials - Tools -> Patron lists Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 175969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175969&action=edit Screenshots - ERM - Before and after I've re-tested and only have a couple of comments. Not sure if these are show stoppers for signing off. Change of behavour/not working as expected =========================================== Cataloging -> Stock rotation -> Manage stages and manage items for a rotation ----------------------------------------------------------------------------- When on other pages (Manage stages, Manage items), those are highlighted as expected at the top of the sidebar menu. However, the stock rotation sidebar menu item further isn't - it was highlighted before the patch. ERM --- There is a slight change to the sidebar menu items - see the screenshots attached. After the patch, there is a darker grey vertical bar before each sub menu item. Before the patch, this was not there and a green vertical bar was only shown when you were on that menu section. Existing behavour - no change, but may need fixing on another bug ================================================================= Point of sale - breadcrumbs and page titles ------------- Cash summary for Centerville: the breadcrumbs and browser title in the Cash summary for Centerville/Transaction history are not correct. However, there is no change from before the patch. Examples: - When on Cash summary for Centerville, the breadcrumb and browser page title are just "Cash summary for Centerville", instead of "Point of sale > Cash summary for Centerville". - When in the transaction history for a cash register, no menu items are highlighted and there are no proper breadcrumb or browser page title, just "Transaction history....". ERM and Preservation -------------------- All sidebar menu items are in italic, which is different from all the other sidebars in Koha. I don't know if this is a specific design choice, or has accidentally changed. I do recall that they weren't originally italicised (as far as I can remember). Preservation ------------ For any action for any of the menus, the sidebar menu is not highlighted, for example: - Trains > New train, or Trains > select an existing train This is the same behavour as before the patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from Lisette Scheer <lisette@bywatersolutions.com> --- The breadcrumbs are strange in the ERM E-resource management <correct eHoldings < class="current disabled" no link and marked as current Local < class="current disabled" no link and marked as current Packages < link and not marked as current This change and the grey bars in the erm are why I'm going to fail qa on this. I think the rest could be handled separately if needed, but aren't blockers. It looks like the italics in the sidebar are from the bootstrap 5 update, so I'll file a bug related to that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176469&action=edit Bug 37222: (follow-up) More corrections to sidebar style -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle@bywatersolutions.com --- Comment #24 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Could you check to see if your patches still apply to main? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 37222: Standardize markup for sidebar menus Applying: Bug 37222: (follow-up) Correct style of Vue sidebars Applying: Bug 37222: (follow-up) More corrections to sidebar style error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue). error: could not build fake ancestor Patch failed at 0001 Bug 37222: (follow-up) More corrections to sidebar style -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175333|0 |1 is obsolete| | Attachment #175334|0 |1 is obsolete| | Attachment #176469|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176732&action=edit Bug 37222: Standardize markup for sidebar menus This patch updates sidebar menu markup so that it's consistent, with a common class (".sidebar_menu") and a unique ID. The style is tied to the class rather than the ID, simplifying the CSS. Note: This patch contains indentation changes so ignore whitespace when viewing the diff. The updated patch contains corrections to JavaScript which needed selectors to be changed to match the new markup. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check pages which contain each modified menu: - Circulation -> Check out to a patron - Catalog -> View a bibliographic record - Administration -> View system preferences - Acquisitions -> Acquisitions home - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation - Cataloging -> Stage MARC records for import - Reports -> Acquisitions statistics - Reports -> View dictionary - Point of sale - E-resource management - Preservation - Serials - Tools -> Patron lists Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 176734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176734&action=edit Bug 37222: (follow-up) More corrections to sidebar style -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176733|0 |1 is obsolete| | --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177289&action=edit Bug 37222: (follow-up) Correct style of Vue sidebars NavigationItem.vue generates both breadcrumb menus and sidebar menus. Sidebar menus should not have the same markers between list elements. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177291&action=edit Bug 37222: (follow-up) Remove obsolete CSS from NavigationItem.vue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177288|0 |1 is obsolete| | --- Comment #34 from David Nind <david@davidnind.com> --- Created attachment 177409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177409&action=edit Bug 37222: Standardize markup for sidebar menus This patch updates sidebar menu markup so that it's consistent, with a common class (".sidebar_menu") and a unique ID. The style is tied to the class rather than the ID, simplifying the CSS. Note: This patch contains indentation changes so ignore whitespace when viewing the diff. The updated patch contains corrections to JavaScript which needed selectors to be changed to match the new markup. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) Check pages which contain each modified menu: - Circulation -> Check out to a patron - Catalog -> View a bibliographic record - Administration -> View system preferences - Acquisitions -> Acquisitions home - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation - Cataloging -> Stage MARC records for import - Reports -> Acquisitions statistics - Reports -> View dictionary - Point of sale - E-resource management - Preservation - Serials - Tools -> Patron lists Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177290|0 |1 is obsolete| | --- Comment #36 from David Nind <david@davidnind.com> --- Created attachment 177411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177411&action=edit Bug 37222: (follow-up) More corrections to sidebar style Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #38 from David Nind <david@davidnind.com> --- I've added my sign off as well, in case Lucas's sign off can count as the QA (and to get this one through). I've also added my testing notes - it points out some inconsistencies and things I find odd, but fixing these are for other bugs. Some specific items for fixing elsewhere (same behavour as before the patch): - Cataloguing: Fast cataloging menu item missing when in any of the other cataloging sections - Circulation: . No "Bookings to collect" menu item shown in the sidebar . Holds section on the circulation page - title is now "Holds and bookings", however the sidebar menu title is just "Holds" - Preservation: when you edit a train (Trains menu) or edit a processing step (Settings), the sidebar menu is not highlighted and the breadcrumb and browser page title don't really match) Testing notes (using KTD) ========================= - Catalog -> View a bibliographic record: OK - Administration -> View system preferences: OK - Acquisitions -> Acquisitions home: OK (same behvour as before the patch, see notes) . Administration sidebar: . Displays as Budgets, Funds, Currencies, Manage invoice fields, Manage order basket fields, Manage order line fields . When you change to Budgets or Funds you still in the acquisitions sidebar . For all the other administration areas the sidebar changes to the administration sidebar menu (the order is Currencies and exchange rates, Budgets, Funds) . Note that while the behavour remains the same for the vendor sidebar menu, it is a little inconsistent, but outside the scope of this bug: . Baskets: displays vendor sidebar menu + the full sidebar menu . Basket groups: displays vendor sidebar menu + the full sidebar menu . Contracts: vendor sidebar menu disappears, and displays the full sidebar menu . Vendor issues: only shows the vendor sidebar menu . Invoices: vendor sidebar menu disappears, and displays the search filters and the full sidebar menu with Invoices highlighted . Uncertain prices: only shows the vendor sidebar menu - Cataloging -> Stock rotation -> Manage stages and manage items for a rotation: OK . Enable the StockRotation system preference - Cataloging -> Stage MARC records for import: OK - Cataloging: OK (same behvour as before the patch, see note) . Fast cataloging menu item missing when in any of the other cataloging sections Circulation: OK (same behvour as before the patch, see note) - Holds and bookings > Bookings to collect: . "Bookings to collect" menu item not shown in the sidebar when any of the other items selected - Holds section - title is now "Holds and bookings", however the sidebar menu title is just "Holds" - Reports -> Acquisitions statistics: OK (see note for reports) - Reports -> View dictionary: OK (see note for reports) - Reports: OK (same behvour as before the patch) . Other section on the reports home page: Koha database scheme + Koha reports library - not shown in the sidebar . Guided reports section on home page: options on the home page are Create guided report, Create from SQL, Use saved, and Search by keyword (+ search box) . On sidebar when in any other area (such as statistics wizards) the options are: Guided reports (totally different sidebar menu - where page title is "Build a report"), Guideed reports, Build new, Use saved, and Create from SQL . When in the "Guided reports" area, the sidebar menu is: Run reports Saved reports Reports dictionary View dictionary Useful resources Koha report library Koha database schema - Point of sale: OK (same behavour as before the patch) . Enable EnablePointOfSale system preference . Enable UseCashRegisters . Add some debit tables . Add a cash register . Add a couple of sales in the point of sale module . Cash summary for Centerville: the breadcrumbs and browser title in the Cash summary for Centerville/Transaction history are not correct. However, there is no change from before the patch. . When on Cash summary for Centerville, the breadcrumb and browser page title are just "Cash summary for Centerville", instead of "Point of sale > Cash summary for Centerville". . When in the transaction history for a cash register, no menu items are highlighted and there are no proper breadcrumb or browser page title, just "Transaction history....". . Maybe this is because "Cash management" is under Tools as well, and these are just links to that? - E-resource management: OK . Enable ERMModule - Preservation: OK (same behavour as before the patch) . Enable PreservationModule . Settings > Add a processing step (for example "Step 1") . Settings > Status for item added to waiting list: select any value . Waiting list: add an item to the waiting list, for example 39999000011418 . Trains > New train . Note that when you edit a train (Trains menu) or edit a processing step (Settings), the sidebar menu is not highlighted and the breadcrumb and browser page title don't really match) - Serials: OK (same behavour as before the patch) . Add a subscription: no sidebar menu . Serials > [be on the page for a subscription] > Create routing list: no serials menu item (breadcrumb is Serials > [Serial name] > New routing list . When you have arouting list, the menu item changes to "Edit routing list", and not shown in sidebar menu when you edit - Tools -> Patron lists: OK -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch standardizes the release notes| |way side navigation menus | |are built in the staff | |client. Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177870&action=edit Bug 37222: (follow-up) Correct style of Vue sidebars NavigationItem.vue generates both breadcrumb menus and sidebar menus. Sidebar menus should not have the same markers between list elements. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #42 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177872&action=edit Bug 37222: (follow-up) Remove obsolete CSS from NavigationItem.vue Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178439&action=edit Bug 37222: (follow-up) Correct style of Vue sidebars NavigationItem.vue generates both breadcrumb menus and sidebar menus. Sidebar menus should not have the same markers between list elements. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #47 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178441&action=edit Bug 37222: (follow-up) Remove obsolete CSS from NavigationItem.vue Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37222 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40854 [Bug 40854] Staff interface search results browsing is broken -- You are receiving this mail because: You are watching all bug changes.