[Bug 33031] New: Update OPAC lists page to use Bootstrap markup for tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Bug ID: 33031 Summary: Update OPAC lists page to use Bootstrap markup for tabs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 32969 The OPAC's lists page (specifically, the list of lists view) uses jQueryUI markup to display tabs, which I missed in my round of Bootstrap tab updates because they're not triggered by JavaScript. We can replace the markup with Bootstrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 [Bug 32969] Remove references to jQueryUI assets and style in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147086&action=edit Bug 33031: Update OPAC lists page to use Bootstrap markup for tabs This patch updates the OPAC lists page with Bootstrap markup for the static tabs used to link to private and public shelves. These tabs are not dependent on JavaScript. To test, apply the patch and click "Lists" -> "Public lists" in the OPAC. The "Your lists" and "Public lists" tabs should look correct, and each should link to the correct view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147086|0 |1 is obsolete| | --- Comment #2 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 147112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147112&action=edit Bug 33031: Update OPAC lists page to use Bootstrap markup for tabs This patch updates the OPAC lists page with Bootstrap markup for the static tabs used to link to private and public shelves. These tabs are not dependent on JavaScript. To test, apply the patch and click "Lists" -> "Public lists" in the OPAC. The "Your lists" and "Public lists" tabs should look correct, and each should link to the correct view. Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147112|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147265&action=edit Bug 33031: Update OPAC lists page to use Bootstrap markup for tabs This patch updates the OPAC lists page with Bootstrap markup for the static tabs used to link to private and public shelves. These tabs are not dependent on JavaScript. To test, apply the patch and click "Lists" -> "Public lists" in the OPAC. The "Your lists" and "Public lists" tabs should look correct, and each should link to the correct view. Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Architecture, internals, | |and plumbing CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Templates |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org