[Bug 38426] New: Node.js v18 EOL around 25.05 release time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Bug ID: 38426 Summary: Node.js v18 EOL around 25.05 release time Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org We need to plan to migrate our used Node.js version to the latest LTS available. EOL dates: https://endoflife.date/nodejs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |paul.derscheid@lmscloud.de, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I made a quick check in `KTD` which was not successful: ```shell sudo vim /etc/apt/sources.list.d/nodesource.list # switched 18 -> 20 sudo apt update; sudo apt install nodejs ``` after that, I tried to reinstall our node-related tools, replicating what the `KTD` build does: ```shell sudo su - $ cp /kohadevbox/koha/package.json . $ cp /kohadevbox/koha/yarn.lock . $ yarn install --modules-folder /kohadevbox/node_modules yarn install v1.22.22 [1/4] Resolving packages... [2/4] Fetching packages... error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "20.18.0" error Found incompatible module. info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. ``` I then tried telling yarn to upgrade things ```shell rm -rf /kohadevbox/node_modules/* yarn --modules-folder /kohadevbox/node_modules upgrade chown -R 501 /kohadevbox/node_modules/ mv /root/.cache/Cypress /kohadevbox && chown -R 501 /kohadevbox/Cypress cp package.json /kohadevbox/koha cp yarn.lock /kohadevbox/koha ``` Things that worked: * yarn api:bundle * yarn cypress run * yarn prettier koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts Things that DIDN'T work * yarn js:build * yarn css:build -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com, | |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- It seems that @vue/cli-service | vue-cli is in maintenance mode and its use is discouraged. We should remove it because I think we are not using it anyway since we are past the scaffolding. https://github.com/vuejs/vue-cli?tab=readme-ov-file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174422&action=edit Bug 38426: Remove @vue/cli-service as it's scheduled for deprecation and not in use anymore -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Correction: @vue/cli-service is used by Cypress unfortunately. Looking for a way around it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Confirmed that @vue/cli-service really really doesn't seem needed. I also ended up proposing it's removal in a commit in Bug 38167 and I remember asking around stuff to test in our JS tooling to spot regressions. (for that ticket and another were I submitted other changes like that.) And no issue found :)
Correction: @vue/cli-service is used by Cypress unfortunately. Looking for a way around it.
It's use is actually dead code: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167#c4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38167 Status|NEW |Needs Signoff --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- It would maybe make sense to make this bug dependent on Bug 38149 and Bug 38167, so that we don't duplicate what needs to be done for compat with node v22. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 [Bug 38167] ESLint: migrate config to flat format + cleanup some node dependencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Because tuxayo's patches already solve the problems lined out by Tomás here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com --- Comment #8 from Jake Deery <jake.deery@ptfs-europe.com> --- Hey all, Can confirm that these set of steps are what I did today, 14th Nov: ```shell $ sudo sed 's/18.x/20.x/g' -i /etc/apt/sources.list.d/nodesource.list $ sudo apt update ; sudo apt install nodejs -y $ sudo su - $ rm -rf /kohadevbox/node_modules $ cp /kohadevbox/koha/package.json . $ cp /kohadevbox/koha/yarn.lock . $ yarn install --modules-folder /kohadevbox/node_modules $ exit ## out of sudo $ yarn api:bundle ## ok $ yarn cypress run ## fail $ yarn prettier koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts ## ok $ yarn js:build ## ok $ yarn css:build ## ok ``` So, once Cypress is sorted, I think we'd be in a good shape to look at next steps. Jake. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Now that this depends on Bug 38167, there is no effective diff remaining in the patch here after applying on top of Bug 38167 and solving the conflicts. Should the patch be obsoleted? While keeping the usual signoff workflow. Because we have a test plan even without the patch. Because we are testing a change in the node version with the test plan. It fits the process in the end. If some other patch is needed for node upgrade then we would have patches again here. ----- In Bug 38503 we test by upgrading to node 22. And here it's node 20. Both are LTS? Should we aim for 22? v20 with it's EOL 30 Apr 2026 won't outlast Koha 25.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- What's the issue with the Cypress tests? I had a lot of flaky tests but by telling Cypress to retry they pass on the 1st retry. (Instead of rerunning them) +++ b/cypress.config.ts @@ -6,6 +6,7 @@ export default defineConfig({ videosFolder: "t/cypress/videos", defaultCommandTimeout: 10000, requestTimeout: 10000, + retries: 2, ------------------------------------ Except UsageReports_spec.ts AssertionError: Timed out retrying after 10000ms: expected '[{"erm_usage_muses.year":"2023","erm_usage_muses.report_type":"PR","erm_usage_muses.month":[1,2,3,4],"erm_usage_muses.metric_type":["Searches_Platform","Total_Item_Investigations","Total_Item_Requests","Unique_Item_Investigations","Unique_Item_Requests","Unique_Title_Investigations","Unique_Title_Requests"]}]' to include '2022' at Context.eval (webpack://koha/./t/cypress/integration/ERM/UsageReports_spec.ts:337:13) With the screenshots of retries showing and empty table. "No data available in the table" ------------------------------------ But that's not the topic as it happens with node 18,20 and 22. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174422|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|38167 |38770 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 [Bug 38167] ESLint: migrate config to flat format + cleanup some node dependencies https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38770 [Bug 38770] Remove @vue/cli-service and babel -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- bug 38770 is for the removal of @vue/cli-service and babel which is needed here and in another ticket. That's why it has it's own ticket. Because here we might identify more stuff needed for node > 18 support. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #12 from David Nind <david@davidnind.com> --- Not sure of the "Needs signoff" status - no patches to sign off... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- We have pieces of a test plan even without a patch: Comment 1. And comment 8 for a bit more test cases at the end. And there is the dependency on the patch from bug 38770. But yes it looks weird. Because the change will be outside of Koha's repository. So not having an explicit test plan doesn't help. === Test plan === 1. Follow Bug 38770 test plan 2. Test the following things to actually test the node upgrade (It's not the main point of Bug 38770) 3. yarn api:bundle 4. yarn cypress run 5. sudo yarn add prettier --modules-folder /kohadevbox/node_modules 6. yarn prettier koha-tmpl/intranet-tmpl/prog/js/vue/modules/erm.ts 7. sudo yarn remove prettier --modules-folder /kohadevbox/node_modules That mess is because we don't have bug 38149 8. yarn js:build 9. yarn css:build Feel free to post an updated version if I forgot or mistaken things while piecing things together. comment 1 mentions these not working. * yarn js:build * yarn css:build and comment 8 mentions cypress not working These work on my side. So if they work for someone else, we can safely signoff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #14 from David Nind <david@davidnind.com> --- Thanks Victor! I'll attempt to test once bug 38770 applies again. David -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from David Nind <david@davidnind.com> --- Everything as per the test plan in comment #13 worked for me. Signing off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is no patch here and no link in URL - where is the code? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #17 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #16)
There is no patch here and no link in URL - where is the code? :)
The bug is umbrella-ish, and depends on others. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Bug 38426 depends on bug 38770, which changed state. Bug 38770 Summary: Remove @vue/cli-service and babel https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38770 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Any news here about using version 20 ? If I am not mistaken, KTD is still pinned to version 18 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #18)
Any news here about using version 20 ? If I am not mistaken, KTD is still pinned to version 18 ?
Everything listed in the test plan above worked for me. v20.19.5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Changing status. Keeping this in SO without patches does not make sense to me. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- We need someone else to confirm that it works. BLOCKED won't help here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #22 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I've just added a temporary build for a Node.js driven image: https://gitlab.com/koha-community/koha-testing-docker/-/pipelines/2106017515 I will duplicate `Koha_Main` using this image afterwards. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #23 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- ``` koha-1 | error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "20.19.5" koha-1 | error Found incompatible module. koha-1 | info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. koha-1 exited with code 1 ``` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #24 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #23)
``` koha-1 | error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "20.19.5" koha-1 | error Found incompatible module. koha-1 | info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. koha-1 exited with code 1 ```
That was wrong, the box I spun had a really old checkout. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #25 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I just updated all KTD images with Node.js 20. It will be an easy revert if it is a disaster. I'd like to note that the CI doesn't launch trixie correctly. It is supposed to be released already? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #26 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I believe this is done, as all tests are passing, and builds too. We now need to file a new bug for Node.js 20 :-P -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41080 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- I think bug 41080 is caused by this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41080 [Bug 41080] xt/tt_tidy.t is failing randomly (on U22 only?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- I *think* we should have adjusted yarn.lock when we upgraded. But it will require extensive testing to make sure we haven't broken something. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188403&action=edit Bug 38426: Adjust yarn.lock after node upgrade (18 to 30) Generated using: rm -rf node_modules yarn.lock yarn install -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |In Discussion Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #30 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #28)
I *think* we should have adjusted yarn.lock when we upgraded. But it will require extensive testing to make sure we haven't broken something.
It was a chicken-egg issue. Now we have Node.js 20 in KTD, we can update the `yarn.lock` file and not break things for devs. Looking at the patch: if I don't apply it, and run: ```bash sudo yarn install --modules-folder /kohadevbox/node_modules ``` a `git diff` doesn't show any change. Does it make sense? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #30)
(In reply to Jonathan Druart from comment #28)
I *think* we should have adjusted yarn.lock when we upgraded. But it will require extensive testing to make sure we haven't broken something.
It was a chicken-egg issue. Now we have Node.js 20 in KTD, we can update the `yarn.lock` file and not break things for devs.
Looking at the patch: if I don't apply it, and run:
```bash sudo yarn install --modules-folder /kohadevbox/node_modules ```
a `git diff` doesn't show any change. Does it make sense?
Yes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189710&action=edit Bug 38426: Adjust yarn.lock after node upgrade (18 to 20) Generated using: rm -rf node_modules yarn.lock yarn install Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I corrected the commit message (30 -> 20) and added my SO line. I believe this is all working, I ran various tests and builds and all succeeded.. I think we should go with this and see if it resolves the failures on 41080 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- pushed to main for 25.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190009&action=edit Bug 38426: Correct types/ws version error "webpack-dev-server##@types/ws@^8.5.5" doesn't satisfy found match of "webpack-dev-server#@types/ws@8.5.3" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190010&action=edit Bug 38426: yarn.lock changes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #37 from Jonathan Druart <jonathan.druart@gmail.com> --- Last 2 patches pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41327 [Bug 41327] `yarn css:build` generates several warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41328 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41328 [Bug 41328] All KohaTable table broken in Vue components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41329 [Bug 41329] yarn install generates 2 warnings regarding datatables-.net-vue3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 --- Comment #38 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- We are encountering issues building 24.11, getting the error mentioned by Tomas on comment 1: error @achrinza/node-ipc@9.2.5: The engine "node" is incompatible with this module. Expected version "8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18". Got "20.19.6" Thrown by: prove xt/verify-yarnlock.t It appears that that particular dependency was removed by bug 38770 but that was not backported to 24.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42353 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42353 [Bug 42353] Tell which version of node to use -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42356 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42356 [Bug 42356] New yarn build warning: if() syntax is deprecated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38426 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to main |Pushed to stable --- Comment #39 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Hi, I'm a bit confused on the process of this for applying the patches for release maintenance. For 25.05 do I need to apply the patches and then run the tests from Comment 13? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org