[Bug 28859] New: Table Settings should control Checked out by field in Checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Bug ID: 28859 Summary: Table Settings should control Checked out by field in Checkout history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: sally.healey@cheshiresharedservices.gov.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Koha Administration > Table Settings controls all whether fields are visible/can be toggled by users. 'Checked out by' is solely controlled by a system preference (RecordStaffUserOnCheckout) - and is not an option in the Table Settings controls. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to the item's Checkout history - cgi-bin/koha/catalogue/issuehistory.pl - Note that 'Checked out by' column is visible - Go to Koha > Administration > Table Settings - Choose Catalog - Choose Page: detail - Choose Table id: checkoutshistory-table - Note that 'Checked out by' is not an option This also has the effect of targeting the wrong field via Table Settings. To replicate: - Set system preference: RecordStaffUserOnCheckout to 'record' - Check an item out to a patron - Go to the item's Checkout history - cgi-bin/koha/catalogue/issuehistory.pl - Note that 'Checked out by' column is visible - Go to Koha > Administration > Table Settings - Choose Catalog - Choose Page: detail - Choose Table id: checkoutshistory-table - Check some fields to be 'Is hidden by default' i.e. 'checked_out_from' and 'renewed' - Reload the item's Checkout history - Note that the columns 'Checked out from' and 'Checked out by' are hidden, but 'Renewed' is not This is because 'Checked out by' is sitting in the original 'Renewed' position in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28858 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23916 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood@ptfs-europ | |e.com, | |jonathan.druart+koha@gmail. | |com See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23916 | Depends on| |23916 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Caused by commit eb283d13fab70d8a32216a5bee8fb4a71e6d875e Bug 23916: Record and display item issuer Andrew, can you fix this please? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 [Bug 23916] Issuer should be recorded and visible in patron circulation history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 28916 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 124986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124986&action=edit Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124986|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124990&action=edit Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but the table configuration is broken with this patch applied and the preference set to "don't record". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Uncaught TypeError: b.settings()[0].aoColumns[d] is undefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Severity|enhancement |normal Assignee|andrew.isherwood@ptfs-europ |jonathan.druart+koha@gmail. |e.com |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29218 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29218 [Bug 29218] "hidden" class is not working for DT if column visibility button is used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126146&action=edit Bug 28859: Correctly handle 'Checked out by' visibility We must have the column in the table and let DT deal with the visibility. This patch hides the "Checked out by" column by default if RecordStaffUserOnCheckout is off, but the DT column settings is aware of its existence and the end user can still display the column. IMO that's the most optimal situation considering both maintenance and ergonomic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 28858 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124990|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127030&action=edit Bug 28859: Fix missing column setting This commit adds the missing checked_out_by column to columns_settings.yaml Test plan: - Follow the test plans in the bug description and note that the symptoms are no longer seen Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126146|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127031&action=edit Bug 28859: Correctly handle 'Checked out by' visibility We must have the column in the table and let DT deal with the visibility. This patch hides the "Checked out by" column by default if RecordStaffUserOnCheckout is off, but the DT column settings is aware of its existence and the end user can still display the column. IMO that's the most optimal situation considering both maintenance and ergonomic. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I tested the whole bug series together (and separately for the individual QA's). This all works as expected now, thanks for working through it Jonathan. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28859 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org