http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 44965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44965&action=edit Bug 15210 - Novelist throws an error if no ISBN This patch makes opac-detail.tt check for an ISBN before attempting to load Novelist content and prevents a js error which breaks other code. To test: 1 - Enable novelist 2 - Add a visible change to OPACUserJS eg: $(document).ready(function() {$("body").css("background-color","pink");}); 3 - Load a record with no ISBN 4 - Note you do not see a color change in the body and that there is an error in the console 5 - Apply patch 6 - Reload the record 7 - You should see the color change and no error in the js -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45787|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45802&action=edit Bug 15210 - Novelist throws an error if no ISBN This patch makes opac-detail.tt check for an ISBN before attempting to load Novelist content and prevents a js error which breaks other code. To test: 1 - Enable novelist 2 - Add a visible change to OPACUserJS eg: $(document).ready(function() {$("body").css("background-color","pink");}); 3 - Load a record with no ISBN 4 - Note you do not see a color change in the body and that there is an error in the console 5 - Apply patch 6 - Reload the record 7 - You should see the color change and no error in the js Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45802|0 |1 is obsolete| | --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46064&action=edit Bug 15210 - Novelist throws an error if no ISBN This patch makes opac-detail.tt check for an ISBN before attempting to load Novelist content and prevents a js error which breaks other code. To test: 1 - Enable novelist 2 - Add a visible change to OPACUserJS eg: $(document).ready(function() {$("body").css("background-color","pink");}); 3 - Load a record with no ISBN 4 - Note you do not see a color change in the body and that there is an error in the console 5 - Apply patch 6 - Reload the record 7 - You should see the color change and no error in the js Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.