[Bug 40517] New: Allow grouping existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Bug ID: 40517 Summary: Allow grouping existing holds Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |chloe.zermatten@openfifth.c | |o.uk, | |martin.renvoize@openfifth.c | |o.uk, | |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15516, 40395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40395 [Bug 40395] Allow selecting multiple holds in patron detail page to perform actions on -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184640&action=edit Bug 40517: Add hold groups relationship to patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184641&action=edit Bug 40517: Move creation of hold group into Patron class. Add exceptions Refactor: Update controller logic to make use of patron->create_hold_group This ensures consistency when creating a new hold group for a patron, regardless if on the Staff UI or REST API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184642&action=edit Bug 40517: REST API: Hold groups endpoint list and add actions: /patrons/{patron_id}/hold_groups New test file: prove t/db_dependent/api/v1/patrons_hold_groups.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184643&action=edit Bug 40517: Add visual_group_id to hold_groups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184644&action=edit Bug 40517: Patron holds table: Add 'group selected holds' functionality This adds the UI elements required to group selected holds from the patron pages as well as 2 new concepts: Visual group ID: The visual group ID is designed to be easy to understand from a UI/UX perspective and not show the user an indefinitely incremented value. When holds are cancelled, filled or moved to a different group, if the old group is left empty or with a single hold, the hold group is deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184645&action=edit Bug 40517: Patron page holds table buttons rearrangement This table now has 4 total buttons, 3 of which relate to a selection of holds. Rearranging the buttons is now necessary to present them nicely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184646&action=edit Bug 40517: Add unit tests Run the updated test file: prove ./t/db_dependent/Koha/Patron.t Relevant tests worth running to ensure no regressions are added to existing covered functionality: prove ./t/db_dependent/Circulation* prove ./t/db_dependent/Hold* prove ./t/db_dependent/Reserves* Test plan, k-t-d: 1) Apply patches, enable DisplayAddHoldGroups system preference 2) Do a search for 'test': <staff_url>/cgi-bin/koha/catalogue/search.pl?q=test 3) Click the 'Select all' link at the top of the search results, click the 'Place hold' button. 4) Enter the 'koha' user 5) Pick a pickup location for each of the holds and click 'Place holds'. 6) Visit the 'koha' patron: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'holds' tab. Notice a new 'Group selected' button now exists 8) Pick any number of holds (more than 2) and click the 'Group selected' button. Confirm 9) Notice the hold group shows '1'. If you click on it you're presented the hold group modal. 10) Group multiple holds multiple times. 11) Notice you can't group a hold that has already been found. 12) Notice you can't click the 'Group selected' button unless at least 2 holds are selected. 13) Notice a hold group is deleted if left with 0 or 1 hold e.g. make a group of 2 holds, cancel 1, notice the remaining hold is left without a group. prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Patron.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/openfift | |h/koha/commits/group_existi | |ng_holds/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 184641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184641 Bug 40517: Move creation of hold group into Patron class. Add exceptions Review of attachment 184641: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=40517&attachment=184641) ----------------------------------------------------------------- ::: reserve/placerequest.pl @@ +140,1 @@
hold_group_id => $hold_group ? $hold_group->id : undef,
I haven't tried yet but guessing this line needs to be removed? @@ +165,1 @@
hold_group_id => $hold_group ? $hold_group->id : undef,
I haven't tried yet but guessing this line needs to be removed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Apologies for my delay on this one. I've run out of time today for a meaningful review, but I will take a look at this one and bug 40395. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #10 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to David Cook from comment #8)
Comment on attachment 184641 [details] [review] Bug 40517: Move creation of hold group into Patron class. Add exceptions
Review of attachment 184641 [details] [review]: -----------------------------------------------------------------
::: reserve/placerequest.pl @@ +140,1 @@
hold_group_id => $hold_group ? $hold_group->id : undef,
I haven't tried yet but guessing this line needs to be removed?
@@ +165,1 @@
hold_group_id => $hold_group ? $hold_group->id : undef,
I haven't tried yet but guessing this line needs to be removed?
Good spot, yes most definitely an oversight, these should be removed. I'll correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #11 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 184729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184729&action=edit Bug 40517: (QA follow-up): Cleanup obsolete code The patch 'Move creation of hold group into Patron class' is moving the creation of the hold group logic to the Patron.pm class file but it didn't remove all the obsolete code. This is fixed here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184640|0 |1 is obsolete| | --- Comment #12 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 184732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184732&action=edit Bug 40517: Add hold groups relationship to patron Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184641|0 |1 is obsolete| | --- Comment #13 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 184733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184733&action=edit Bug 40517: Move creation of hold group into Patron class. Add exceptions Refactor: Update controller logic to make use of patron->create_hold_group This ensures consistency when creating a new hold group for a patron, regardless if on the Staff UI or REST API Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184642|0 |1 is obsolete| | --- Comment #14 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 184734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184734&action=edit Bug 40517: REST API: Hold groups endpoint list and add actions: /patrons/{patron_id}/hold_groups New test file: prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184643|0 |1 is obsolete| | --- Comment #15 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 184735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184735&action=edit Bug 40517: Add visual_group_id to hold_groups Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184644|0 |1 is obsolete| | --- Comment #16 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 184736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184736&action=edit Bug 40517: Patron holds table: Add 'group selected holds' functionality This adds the UI elements required to group selected holds from the patron pages as well as 2 new concepts: Visual group ID: The visual group ID is designed to be easy to understand from a UI/UX perspective and not show the user an indefinitely incremented value. When holds are cancelled, filled or moved to a different group, if the old group is left empty or with a single hold, the hold group is deleted. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184645|0 |1 is obsolete| | --- Comment #17 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 184737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184737&action=edit Bug 40517: Patron page holds table buttons rearrangement This table now has 4 total buttons, 3 of which relate to a selection of holds. Rearranging the buttons is now necessary to present them nicely. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184646|0 |1 is obsolete| | --- Comment #18 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 184738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184738&action=edit Bug 40517: Add unit tests Run the updated test file: prove ./t/db_dependent/Koha/Patron.t Relevant tests worth running to ensure no regressions are added to existing covered functionality: prove ./t/db_dependent/Circulation* prove ./t/db_dependent/Hold* prove ./t/db_dependent/Reserves* Test plan, k-t-d: 1) Apply patches, enable DisplayAddHoldGroups system preference 2) Do a search for 'test': <staff_url>/cgi-bin/koha/catalogue/search.pl?q=test 3) Click the 'Select all' link at the top of the search results, click the 'Place hold' button. 4) Enter the 'koha' user 5) Pick a pickup location for each of the holds and click 'Place holds'. 6) Visit the 'koha' patron: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'holds' tab. Notice a new 'Group selected' button now exists 8) Pick any number of holds (more than 2) and click the 'Group selected' button. Confirm 9) Notice the hold group shows '1'. If you click on it you're presented the hold group modal. 10) Group multiple holds multiple times. 11) Notice you can't group a hold that has already been found. 12) Notice you can't click the 'Group selected' button unless at least 2 holds are selected. 13) Notice a hold group is deleted if left with 0 or 1 hold e.g. make a group of 2 holds, cancel 1, notice the remaining hold is left without a group. prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Patron.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184729|0 |1 is obsolete| | --- Comment #19 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 184739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184739&action=edit Bug 40517: (QA follow-up): Cleanup obsolete code The patch 'Move creation of hold group into Patron class' is moving the creation of the hold group logic to the Patron.pm class file but it didn't remove all the obsolete code. This is fixed here. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |anneli.osterman@koha-suomi. | |fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40529 [Bug 40529] Update how hold groups work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40551 [Bug 40551] Make patron page holds table use API endpoint for cancellation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40551 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40551 [Bug 40551] Make patron page holds table use API endpoint for cancellation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40552 [Bug 40552] Allow selecting all holds from a group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #20 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185217&action=edit Bug 40517: (QA follow-up): Fix 'group selected' button active with just 1 hold selected This fixes the following bug: 1) Select 1 hold, notice the 'group selected' button is still disabled 2) Select a 2nd hold, notice the 'group selected' button becomes enabled 3) Unselect one of the holds, notice the 'group select' is kept enabled (this is wrong, it should become disabled) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pedro, can you please give this a rebase? I started QA but hit more merge errors than I was entirely comfortable sorting out on my own. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184732|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186672&action=edit Bug 40517: Add hold groups relationship to patron Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184733|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186673&action=edit Bug 40517: Move creation of hold group into Patron class. Add exceptions Refactor: Update controller logic to make use of patron->create_hold_group This ensures consistency when creating a new hold group for a patron, regardless if on the Staff UI or REST API Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184734|0 |1 is obsolete| | --- Comment #24 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186674&action=edit Bug 40517: REST API: Hold groups endpoint list and add actions: /patrons/{patron_id}/hold_groups New test file: prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184735|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186675&action=edit Bug 40517: Add visual_group_id to hold_groups Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184736|0 |1 is obsolete| | --- Comment #26 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186676&action=edit Bug 40517: Patron holds table: Add 'group selected holds' functionality This adds the UI elements required to group selected holds from the patron pages as well as 2 new concepts: Visual group ID: The visual group ID is designed to be easy to understand from a UI/UX perspective and not show the user an indefinitely incremented value. When holds are cancelled, filled or moved to a different group, if the old group is left empty or with a single hold, the hold group is deleted. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184737|0 |1 is obsolete| | --- Comment #27 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186677&action=edit Bug 40517: Patron page holds table buttons rearrangement This table now has 4 total buttons, 3 of which relate to a selection of holds. Rearranging the buttons is now necessary to present them nicely. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184738|0 |1 is obsolete| | --- Comment #28 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186678&action=edit Bug 40517: Add unit tests Run the updated test file: prove ./t/db_dependent/Koha/Patron.t Relevant tests worth running to ensure no regressions are added to existing covered functionality: prove ./t/db_dependent/Circulation* prove ./t/db_dependent/Hold* prove ./t/db_dependent/Reserves* Test plan, k-t-d: 1) Apply patches, enable DisplayAddHoldGroups system preference 2) Do a search for 'test': <staff_url>/cgi-bin/koha/catalogue/search.pl?q=test 3) Click the 'Select all' link at the top of the search results, click the 'Place hold' button. 4) Enter the 'koha' user 5) Pick a pickup location for each of the holds and click 'Place holds'. 6) Visit the 'koha' patron: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'holds' tab. Notice a new 'Group selected' button now exists 8) Pick any number of holds (more than 2) and click the 'Group selected' button. Confirm 9) Notice the hold group shows '1'. If you click on it you're presented the hold group modal. 10) Group multiple holds multiple times. 11) Notice you can't group a hold that has already been found. 12) Notice you can't click the 'Group selected' button unless at least 2 holds are selected. 13) Notice a hold group is deleted if left with 0 or 1 hold e.g. make a group of 2 holds, cancel 1, notice the remaining hold is left without a group. prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Patron.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184739|0 |1 is obsolete| | --- Comment #29 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186679&action=edit Bug 40517: (QA follow-up): Cleanup obsolete code The patch 'Move creation of hold group into Patron class' is moving the creation of the hold group logic to the Patron.pm class file but it didn't remove all the obsolete code. This is fixed here. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185217|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 186680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186680&action=edit Bug 40517: (QA follow-up): Fix 'group selected' button active with just 1 hold selected This fixes the following bug: 1) Select 1 hold, notice the 'group selected' button is still disabled 2) Select a 2nd hold, notice the 'group selected' button becomes enabled 3) Unselect one of the holds, notice the 'group select' is kept enabled (this is wrong, it should become disabled) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186672|0 |1 is obsolete| | --- Comment #31 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186745&action=edit Bug 40517: Add hold groups relationship to patron Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186673|0 |1 is obsolete| | --- Comment #32 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186746&action=edit Bug 40517: Move creation of hold group into Patron class. Add exceptions Refactor: Update controller logic to make use of patron->create_hold_group This ensures consistency when creating a new hold group for a patron, regardless if on the Staff UI or REST API Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186674|0 |1 is obsolete| | --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186747&action=edit Bug 40517: REST API: Hold groups endpoint list and add actions: /patrons/{patron_id}/hold_groups New test file: prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186675|0 |1 is obsolete| | --- Comment #34 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186748&action=edit Bug 40517: Add visual_group_id to hold_groups Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186676|0 |1 is obsolete| | --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186749&action=edit Bug 40517: Patron holds table: Add 'group selected holds' functionality This adds the UI elements required to group selected holds from the patron pages as well as 2 new concepts: Visual group ID: The visual group ID is designed to be easy to understand from a UI/UX perspective and not show the user an indefinitely incremented value. When holds are cancelled, filled or moved to a different group, if the old group is left empty or with a single hold, the hold group is deleted. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186677|0 |1 is obsolete| | --- Comment #36 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186750&action=edit Bug 40517: Patron page holds table buttons rearrangement This table now has 4 total buttons, 3 of which relate to a selection of holds. Rearranging the buttons is now necessary to present them nicely. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186678|0 |1 is obsolete| | --- Comment #37 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186751&action=edit Bug 40517: Add unit tests Run the updated test file: prove ./t/db_dependent/Koha/Patron.t Relevant tests worth running to ensure no regressions are added to existing covered functionality: prove ./t/db_dependent/Circulation* prove ./t/db_dependent/Hold* prove ./t/db_dependent/Reserves* Test plan, k-t-d: 1) Apply patches, enable DisplayAddHoldGroups system preference 2) Do a search for 'test': <staff_url>/cgi-bin/koha/catalogue/search.pl?q=test 3) Click the 'Select all' link at the top of the search results, click the 'Place hold' button. 4) Enter the 'koha' user 5) Pick a pickup location for each of the holds and click 'Place holds'. 6) Visit the 'koha' patron: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'holds' tab. Notice a new 'Group selected' button now exists 8) Pick any number of holds (more than 2) and click the 'Group selected' button. Confirm 9) Notice the hold group shows '1'. If you click on it you're presented the hold group modal. 10) Group multiple holds multiple times. 11) Notice you can't group a hold that has already been found. 12) Notice you can't click the 'Group selected' button unless at least 2 holds are selected. 13) Notice a hold group is deleted if left with 0 or 1 hold e.g. make a group of 2 holds, cancel 1, notice the remaining hold is left without a group. prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Patron.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186679|0 |1 is obsolete| | --- Comment #38 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186752&action=edit Bug 40517: (QA follow-up): Cleanup obsolete code The patch 'Move creation of hold group into Patron class' is moving the creation of the hold group logic to the Patron.pm class file but it didn't remove all the obsolete code. This is fixed here. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186680|0 |1 is obsolete| | --- Comment #39 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 186753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186753&action=edit Bug 40517: (QA follow-up): Fix 'group selected' button active with just 1 hold selected This fixes the following bug: 1) Select 1 hold, notice the 'group selected' button is still disabled 2) Select a 2nd hold, notice the 'group selected' button becomes enabled 3) Unselect one of the holds, notice the 'group select' is kept enabled (this is wrong, it should become disabled) Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Staff can now group release notes| |existing patron holds | |together directly from the | |patron holds table, in | |addition to creating hold | |groups when placing new | |holds. | | | |Previously, hold groups | |could only be created when | |placing new holds (if the | |DisplayAddHoldGroups system | |preference was enabled). | |With this enhancement, | |staff can now select | |multiple existing holds | |from a patron's holds list | |and group them together | |using a new "Group | |selected" button. | | | |**Key features:** | | | |- **Group selected | |button**: Select two or | |more holds from the patron | |holds table and click | |"Group selected" to create | |a new hold group | |- **Visual group IDs**: | |Hold groups are displayed | |with easy-to-understand | |sequential numbers (1, 2, | |3, etc.) rather than | |internal database IDs | |- **Automatic cleanup**: If | |a hold group is left with | |only one hold (or none) | |after cancellations or | |fulfilment, the group is | |automatically deleted | |- **Smart restrictions**: | |You cannot group holds that | |have already been found | |(waiting for pickup) | |- **Multiple groups**: | |Create as many different | |hold groups as needed for a | |patron | | | |**Using hold groups:** | | | |1. Navigate to a patron's | |record and click the | |"Holds" tab | |2. Select two or more holds | |using the checkboxes | |3. Click the "Group | |selected" button and | |confirm | |4. The holds are now | |grouped together with a | |visual group ID displayed | |in the holds table | |5. Click on the group | |number to view or manage | |the hold group | | | |**For administrators:** | | | |This feature requires the | |DisplayAddHoldGroups system | |preference to be enabled. | |The new "Group selected" | |button appears alongside | |other hold management | |buttons on patron holds | |pages. | | | |**REST API:** | | | |A new API endpoint | |`/api/v1/patrons/{patron_id | |}/hold_groups` has been | |added to support listing | |and creating hold groups | |programmatically. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #40 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Can you separate the schema changes from the other database updates? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186745|0 |1 is obsolete| | --- Comment #41 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187789&action=edit Bug 40517: Add hold groups relationship to patron Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186746|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187790&action=edit Bug 40517: Move creation of hold group into Patron class. Add exceptions Refactor: Update controller logic to make use of patron->create_hold_group This ensures consistency when creating a new hold group for a patron, regardless if on the Staff UI or REST API Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186747|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187791&action=edit Bug 40517: REST API: Hold groups endpoint list and add actions: /patrons/{patron_id}/hold_groups New test file: prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186748|0 |1 is obsolete| | --- Comment #44 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187792&action=edit Bug 40517: Add visual_group_id to hold_groups Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186749|0 |1 is obsolete| | --- Comment #45 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187793&action=edit Bug 40517: Patron holds table: Add 'group selected holds' functionality This adds the UI elements required to group selected holds from the patron pages as well as 2 new concepts: Visual group ID: The visual group ID is designed to be easy to understand from a UI/UX perspective and not show the user an indefinitely incremented value. When holds are cancelled, filled or moved to a different group, if the old group is left empty or with a single hold, the hold group is deleted. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186750|0 |1 is obsolete| | --- Comment #46 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187794&action=edit Bug 40517: Patron page holds table buttons rearrangement This table now has 4 total buttons, 3 of which relate to a selection of holds. Rearranging the buttons is now necessary to present them nicely. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186751|0 |1 is obsolete| | --- Comment #47 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187795&action=edit Bug 40517: Add unit tests Run the updated test file: prove ./t/db_dependent/Koha/Patron.t Relevant tests worth running to ensure no regressions are added to existing covered functionality: prove ./t/db_dependent/Circulation* prove ./t/db_dependent/Hold* prove ./t/db_dependent/Reserves* Test plan, k-t-d: 1) Apply patches, enable DisplayAddHoldGroups system preference 2) Do a search for 'test': <staff_url>/cgi-bin/koha/catalogue/search.pl?q=test 3) Click the 'Select all' link at the top of the search results, click the 'Place hold' button. 4) Enter the 'koha' user 5) Pick a pickup location for each of the holds and click 'Place holds'. 6) Visit the 'koha' patron: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'holds' tab. Notice a new 'Group selected' button now exists 8) Pick any number of holds (more than 2) and click the 'Group selected' button. Confirm 9) Notice the hold group shows '1'. If you click on it you're presented the hold group modal. 10) Group multiple holds multiple times. 11) Notice you can't group a hold that has already been found. 12) Notice you can't click the 'Group selected' button unless at least 2 holds are selected. 13) Notice a hold group is deleted if left with 0 or 1 hold e.g. make a group of 2 holds, cancel 1, notice the remaining hold is left without a group. prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Patron.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186752|0 |1 is obsolete| | --- Comment #48 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187796&action=edit Bug 40517: (QA follow-up): Cleanup obsolete code The patch 'Move creation of hold group into Patron class' is moving the creation of the hold group logic to the Patron.pm class file but it didn't remove all the obsolete code. This is fixed here. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186753|0 |1 is obsolete| | --- Comment #49 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187797&action=edit Bug 40517: (QA follow-up): Fix 'group selected' button active with just 1 hold selected This fixes the following bug: 1) Select 1 hold, notice the 'group selected' button is still disabled 2) Select a 2nd hold, notice the 'group selected' button becomes enabled 3) Unselect one of the holds, notice the 'group select' is kept enabled (this is wrong, it should become disabled) Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #50 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187801&action=edit Bug 40517: dbic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #51 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187802&action=edit Bug 40517: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #52 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187803&action=edit Bug 40517: atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187789|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187804&action=edit Bug 40517: Add hold groups relationship to patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187790|0 |1 is obsolete| | --- Comment #54 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187805&action=edit Bug 40517: Move creation of hold group into Patron class. Add exceptions Refactor: Update controller logic to make use of patron->create_hold_group This ensures consistency when creating a new hold group for a patron, regardless if on the Staff UI or REST API Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187791|0 |1 is obsolete| | --- Comment #55 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187806&action=edit Bug 40517: REST API: Hold groups endpoint list and add actions: /patrons/{patron_id}/hold_groups New test file: prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187792|0 |1 is obsolete| | --- Comment #56 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187807&action=edit Bug 40517: Add visual_group_id to hold_groups Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187793|0 |1 is obsolete| | --- Comment #57 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187808&action=edit Bug 40517: Patron holds table: Add 'group selected holds' functionality This adds the UI elements required to group selected holds from the patron pages as well as 2 new concepts: Visual group ID: The visual group ID is designed to be easy to understand from a UI/UX perspective and not show the user an indefinitely incremented value. When holds are cancelled, filled or moved to a different group, if the old group is left empty or with a single hold, the hold group is deleted. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187794|0 |1 is obsolete| | --- Comment #58 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187809&action=edit Bug 40517: Patron page holds table buttons rearrangement This table now has 4 total buttons, 3 of which relate to a selection of holds. Rearranging the buttons is now necessary to present them nicely. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187795|0 |1 is obsolete| | --- Comment #59 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187810&action=edit Bug 40517: Add unit tests Run the updated test file: prove ./t/db_dependent/Koha/Patron.t Relevant tests worth running to ensure no regressions are added to existing covered functionality: prove ./t/db_dependent/Circulation* prove ./t/db_dependent/Hold* prove ./t/db_dependent/Reserves* Test plan, k-t-d: 1) Apply patches, enable DisplayAddHoldGroups system preference 2) Do a search for 'test': <staff_url>/cgi-bin/koha/catalogue/search.pl?q=test 3) Click the 'Select all' link at the top of the search results, click the 'Place hold' button. 4) Enter the 'koha' user 5) Pick a pickup location for each of the holds and click 'Place holds'. 6) Visit the 'koha' patron: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'holds' tab. Notice a new 'Group selected' button now exists 8) Pick any number of holds (more than 2) and click the 'Group selected' button. Confirm 9) Notice the hold group shows '1'. If you click on it you're presented the hold group modal. 10) Group multiple holds multiple times. 11) Notice you can't group a hold that has already been found. 12) Notice you can't click the 'Group selected' button unless at least 2 holds are selected. 13) Notice a hold group is deleted if left with 0 or 1 hold e.g. make a group of 2 holds, cancel 1, notice the remaining hold is left without a group. prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Patron.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187796|0 |1 is obsolete| | --- Comment #60 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187811&action=edit Bug 40517: (QA follow-up): Cleanup obsolete code The patch 'Move creation of hold group into Patron class' is moving the creation of the hold group logic to the Patron.pm class file but it didn't remove all the obsolete code. This is fixed here. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187797|0 |1 is obsolete| | --- Comment #61 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187812&action=edit Bug 40517: (QA follow-up): Fix 'group selected' button active with just 1 hold selected This fixes the following bug: 1) Select 1 hold, notice the 'group selected' button is still disabled 2) Select a 2nd hold, notice the 'group selected' button becomes enabled 3) Unselect one of the holds, notice the 'group select' is kept enabled (this is wrong, it should become disabled) Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187801|0 |1 is obsolete| | --- Comment #62 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187965&action=edit Bug 40517: dbic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187802|0 |1 is obsolete| | --- Comment #63 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187966&action=edit Bug 40517: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187803|0 |1 is obsolete| | --- Comment #64 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187967&action=edit Bug 40517: atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187804|0 |1 is obsolete| | --- Comment #65 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187968&action=edit Bug 40517: Add hold groups relationship to patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187805|0 |1 is obsolete| | --- Comment #66 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187969&action=edit Bug 40517: Move creation of hold group into Patron class. Add exceptions Refactor: Update controller logic to make use of patron->create_hold_group This ensures consistency when creating a new hold group for a patron, regardless if on the Staff UI or REST API Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187806|0 |1 is obsolete| | --- Comment #67 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187970&action=edit Bug 40517: REST API: Hold groups endpoint list and add actions: /patrons/{patron_id}/hold_groups New test file: prove t/db_dependent/api/v1/patrons_hold_groups.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187807|0 |1 is obsolete| | --- Comment #68 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187971&action=edit Bug 40517: Add visual_group_id to hold_groups Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187808|0 |1 is obsolete| | --- Comment #69 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187972&action=edit Bug 40517: Patron holds table: Add 'group selected holds' functionality This adds the UI elements required to group selected holds from the patron pages as well as 2 new concepts: Visual group ID: The visual group ID is designed to be easy to understand from a UI/UX perspective and not show the user an indefinitely incremented value. When holds are cancelled, filled or moved to a different group, if the old group is left empty or with a single hold, the hold group is deleted. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187809|0 |1 is obsolete| | --- Comment #70 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187973&action=edit Bug 40517: Patron page holds table buttons rearrangement This table now has 4 total buttons, 3 of which relate to a selection of holds. Rearranging the buttons is now necessary to present them nicely. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187810|0 |1 is obsolete| | --- Comment #71 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187974&action=edit Bug 40517: Add unit tests Run the updated test file: prove ./t/db_dependent/Koha/Patron.t Relevant tests worth running to ensure no regressions are added to existing covered functionality: prove ./t/db_dependent/Circulation* prove ./t/db_dependent/Hold* prove ./t/db_dependent/Reserves* Test plan, k-t-d: 1) Apply patches, enable DisplayAddHoldGroups system preference 2) Do a search for 'test': <staff_url>/cgi-bin/koha/catalogue/search.pl?q=test 3) Click the 'Select all' link at the top of the search results, click the 'Place hold' button. 4) Enter the 'koha' user 5) Pick a pickup location for each of the holds and click 'Place holds'. 6) Visit the 'koha' patron: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Click the 'holds' tab. Notice a new 'Group selected' button now exists 8) Pick any number of holds (more than 2) and click the 'Group selected' button. Confirm 9) Notice the hold group shows '1'. If you click on it you're presented the hold group modal. 10) Group multiple holds multiple times. 11) Notice you can't group a hold that has already been found. 12) Notice you can't click the 'Group selected' button unless at least 2 holds are selected. 13) Notice a hold group is deleted if left with 0 or 1 hold e.g. make a group of 2 holds, cancel 1, notice the remaining hold is left without a group. prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/Koha/Patron.t Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187811|0 |1 is obsolete| | --- Comment #72 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187975&action=edit Bug 40517: (QA follow-up): Cleanup obsolete code The patch 'Move creation of hold group into Patron class' is moving the creation of the hold group logic to the Patron.pm class file but it didn't remove all the obsolete code. This is fixed here. Signed-off-by: Anneli <anneli.osterman@koha-suomi.fi> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187812|0 |1 is obsolete| | --- Comment #73 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 187976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187976&action=edit Bug 40517: (QA follow-up): Fix 'group selected' button active with just 1 hold selected This fixes the following bug: 1) Select 1 hold, notice the 'group selected' button is still disabled 2) Select a 2nd hold, notice the 'group selected' button becomes enabled 3) Unselect one of the holds, notice the 'group select' is kept enabled (this is wrong, it should become disabled) Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #74 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188293&action=edit Bug 40517: (follow-up) Add a new line to EOF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #75 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188294&action=edit Bug 40517: (follow-up) Fix GNU license links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #76 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- With this patchset applied xt/api.t fails: kohadev-koha@kohadevbox:koha(main)$ prove -v xt/api.t xt/api.t .. 1..8 ok 1 - GET /api/v1/ ok 2 # Subtest: The spec passes the swagger-cli validation 1..1 not ok 1 - Validation exit code is 0 # Failed test 'Validation exit code is 0' # at xt/api.t line 103. # got: '256' # expected: '0' # Validation failed. /paths/patrons/{patron_id}/hold_groups/post is missing path parameter(s) for {patron_id} # Looks like you failed 1 test of 1. not ok 3 - The spec passes the swagger-cli validation # Failed test 'The spec passes the swagger-cli validation' # at xt/api.t line 108. # Subtest: tags tests 1..1 not ok 1 - No tag errors in the spec # Failed test 'No tag errors in the spec' # at xt/api.t line 130. # Structures begin differing at: # $got->[0] = 'get /patrons/{patron_id}/hold_groups -> uses tag 'hold_groups' not present in top level list' # $expected->[0] = Does not exist get /patrons/{patron_id}/hold_groups -> uses tag 'hold_groups' not present in top level list post /patrons/{patron_id}/hold_groups -> uses tag 'hold_groups' not present in top level list # Looks like you failed 1 test of 1. not ok 4 - tags tests # Subtest: 400 response tests # Failed test 'tags tests' # at xt/api.t line 135. 1..1 ok 1 - No errors in 400 definitions in the spec ok 5 - 400 response tests # Subtest: POST (201) have location header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #77 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188343&action=edit Bug 40517: (QA follow-up): Fix xt/api.t prove -v xt/api.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #78 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- If I push this as is we will break Koha_Main_MariaDB_update. kohastructure.sql must match the DB structure: Schema dump completed. Running [sudo koha-shell kohadev -p -c 'git diff && git diff --quiet || { echo "ERROR - There is a diff in DBIC schema files" && exit 1; }']... Running [sudo koha-dump --schema-only kohadev]... Dumping Koha site kohadev: * schema to /var/spool/koha/kohadev/kohadev-schema-2025-10-24.sql Running [sed -n '/-- Table structure/,/-- Dump completed/{//!p;}' /var/spool/koha/kohadev/kohadev-schema-$(date '+%Y-%m-%d').sql > /tmp/upgraded_db.sql]... Running [sed -n '/-- Table structure/,/-- Dump completed/{//!p;}' installer/data/mysql/kohastructure.sql > /tmp/current_db.sql]... Running [diff /tmp/current_db.sql /tmp/upgraded_db.sql && diff -q /tmp/current_db.sql /tmp/upgraded_db.sql || { echo "ERROR - DB structures are not identical" && exit 1; }]... 3537a3538
PRIMARY KEY (`hold_group_id`), 3539,3540c3540 < CONSTRAINT `hold_groups_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE, < PRIMARY KEY (`hold_group_id`)
CONSTRAINT `hold_groups_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ERROR - DB structures are not identical
Can you look Pedro? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #79 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188422&action=edit Bug 40517: (QA follow-up): Fix kohstructure.sql The order was wrong, PRIMARY KEY must come first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #80 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Follow-up pushed. Sorry for the mishap Lucas and thank you for your patience! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Keywords|rel_25_11_candidate | Status|Passed QA |Pushed to main --- Comment #81 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Pushed to main for 25.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart@gmail.com --- Comment #82 from Jonathan Druart <jonathan.druart@gmail.com> --- t/db_dependent/api/v1/patrons_holds.t .. # Failed test 'Only old holds retrieved' # at t/db_dependent/api/v1/patrons_holds.t line 70. # Structures begin differing at: # $got->[0]{hold_group_id} = undef # $expected->[0]{hold_group_id} = '1' # Failed test 'Old holds even after item and library removed' # at t/db_dependent/api/v1/patrons_holds.t line 78. # Structures begin differing at: # $got->[1]{hold_group_id} = undef # $expected->[1]{hold_group_id} = '3' # Failed test 'Old holds even after biblio removed' # at t/db_dependent/api/v1/patrons_holds.t line 85. # Structures begin differing at: # $got->[1]{hold_group_id} = undef # $expected->[1]{hold_group_id} = '3' # Looks like you failed 3 tests of 21. t/db_dependent/api/v1/patrons_holds.t .. 1/3 # Failed test 'list() tests' # at t/db_dependent/api/v1/patrons_holds.t line 101. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #83 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 188923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188923&action=edit Bug 40517: (QA follow-up): Fix tests Enforce no hold group when creating hold object When a hold is created by build_object, it's auto-assigned a hold_group_id (as expected). When a hold is ->fill, it's hold_group_id is cleared by cleanup_hold_group (as expected). The problem is then this causes the object before ->fill to be out of sync with the up to date object returned by the API (i.e. the latter has an empty hold_group_id, as expected, but the former has the auto-assigned hold_group_id). Using ->discard_changes or ->get_from_storage doesnt work because the became a after ->fill. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #84 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Follow-up pushed to main, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 --- Comment #85 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Pedro Amorim from comment #83)
Using ->discard_changes or ->get_from_storage doesnt work because the became a after ->fill.
This was supposed to be read: Using ->discard_changes or ->get_from_storage doesnt work because the $hold became a $old_hold after ->fill But was filtered in the commit message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #86 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40517 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41878 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org